Issues in HasTask.php (master) - Issues in master - SierraTecnologia/Telefonica - Measure and Improve Code Quality continuously with Scrutinizer

Issues (80)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Traits/HasTask.php (20 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Telefonica\Traits;

use InvalidArgumentException;
use Illuminate\Database\Eloquent\Model;
use Illuminate\Database\Eloquent\Builder;
use Illuminate\Database\Eloquent\Collection;
use Illuminate\Database\Eloquent\Relations\MorphToMany;
use Casa\Models\Calendar\Task;

trait HasTask
{
    protected $queuedTask = [];

    public static function getTaskClassName(): string
    {
        return Task::class;
    }

    public static function bootHasTask()

    {
        static::created(
            function (Model $taskableModel) {
                if (count($taskableModel->queuedTask) > 0) {
                    $taskableModel->attachTask($taskableModel->queuedTask);

                    $taskableModel->queuedTask = [];
                }
            }
        );

        static::deleted(
            function (Model $deletedModel) {
                $tasks = $deletedModel->tasks()->get();

                $deletedModel->detachTask($tasks);
            }
        );
    }

    public function tasks(): MorphToMany
    {
        return $this
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            ->morphToMany(self::getTaskClassName(), 'taskable')
            ->ordered();
    }

    /**
     * @param string $locale
     */
    public function tasksTranslated($locale = null): MorphToMany

    {
        $locale = ! is_null($locale) ? $locale : app()->getLocale();

        return $this
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            ->morphToMany(self::getTaskClassName(), 'taskable')
            ->select('*')
            ->selectRaw("JSON_UNQUOTE(JSON_EXTRACT(name, '$.\"{$locale}\"')) as name_translated")
            ->selectRaw("JSON_UNQUOTE(JSON_EXTRACT(slug, '$.\"{$locale}\"')) as slug_translated")
            ->ordered();
    }

    /**
     * @param string|array|\ArrayAccess|\\App\Models\Task $tasks
     */
    public function setTaskAttribute($tasks)
    {
        if (! $this->exists) {
class MyClass { }

$x = new MyClass();
$x->foo = true;
            $this->queuedTask = $tasks;

            return;
        }

        $this->attachTask($tasks);
    }

    /**
     * @param \Illuminate\Database\Eloquent\Builder $query
     * @param array|\ArrayAccess|\\App\Models\Task  $tasks
     *
     * @return \Illuminate\Database\Eloquent\Builder
     */
    public function scopeWithAllTask(Builder $query, $tasks, string $type = null): Builder

    {
        $tasks = static::convertToTask($tasks, $type);

        collect($tasks)->each(
            function ($task) use ($query) {
                $query->whereHas(
                    'tasks', function (Builder $query) use ($task) {
                        $query->where('tasks.id', $task ? $task->id : 0);
                    }
                );
            }
        );

        return $query;
    }

    /**
     * @param \Illuminate\Database\Eloquent\Builder $query
     * @param array|\ArrayAccess|\\App\Models\Task  $tasks
     *
     * @return \Illuminate\Database\Eloquent\Builder
     */
    public function scopeWithAnyTask(Builder $query, $tasks, string $type = null): Builder

    {
        $tasks = static::convertToTask($tasks, $type);

        return $query->whereHas(
            'tasks', function (Builder $query) use ($tasks) {
                $taskIds = collect($tasks)->pluck('id');

                $query->whereIn('tasks.id', $taskIds);
            }
        );
    }

    public function scopeWithAllTaskOfAnyType(Builder $query, $tasks): Builder

    {
        $tasks = static::convertToTaskOfAnyType($tasks);

        collect($tasks)->each(
            function ($task) use ($query) {
                $query->whereHas(
                    'tasks', function (Builder $query) use ($task) {
                        $query->where('tasks.id', $task ? $task->id : 0);
                    }
                );
            }
        );

        return $query;
    }

    public function scopeWithAnyTaskOfAnyType(Builder $query, $tasks): Builder

    {
        $tasks = static::convertToTaskOfAnyType($tasks);

        return $query->whereHas(
            'tasks', function (Builder $query) use ($tasks) {
                $taskIds = collect($tasks)->pluck('id');

                $query->whereIn('tasks.id', $taskIds);
            }
        );
    }

    public function tasksWithType(string $type = null): Collection
    {
        return $this->tasks->filter(
class MyClass { }

$x = new MyClass();
$x->foo = true;
            function (Task $task) use ($type) {
                return $task->type === $type;
            }
        );
    }

    /**
     * @param array|\ArrayAccess|\\App\Models\Task $tasks
     *
     * @return $this
     */
    public function attachTask($tasks)

    {
        $className = static::getTaskClassName();

        $tasks = collect($className::findOrCreate($tasks));

        $this->tasks()->syncWithoutDetaching($tasks->pluck('id')->toArray());

        return $this;
    }

    /**
     * @param array|\ArrayAccess $tasks
     *
     * @return $this
     */
    public function detachTask($tasks)
    {
        $tasks = static::convertToTask($tasks);

        collect($tasks)
            ->filter()
            ->each(
                function (Task $task) {
                    $this->tasks()->detach($task);
                }
            );

        return $this;
    }

    /**
     * @param array|\ArrayAccess $tasks
     *
     * @return $this
     */
    public function syncTask($tasks)

    {
        $className = static::getTaskClassName();

        $tasks = collect($className::findOrCreate($tasks));

        $this->tasks()->sync($tasks->pluck('id')->toArray());

        return $this;
    }

    /**
     * @param array|\ArrayAccess $tasks
     * @param string|null        $type
     *
     * @return $this
     */
    public function syncTaskWithType($tasks, string $type = null)

    {
        $className = static::getTaskClassName();

        $tasks = collect($className::findOrCreate($tasks, $type));

        $this->syncTaskIds($tasks->pluck('id')->toArray(), $type);

        return $this;
    }

    protected static function convertToTask($values, $type = null, $locale = null)

    {
        return collect($values)->map(
            function ($value) use ($type, $locale) {
                if ($value instanceof Task) {
if ($x instanceof DoesNotExist) {
    // Do something.
}
                    if (isset($type) && $value->type != $type) {
                        throw new InvalidArgumentException("Type was set to {$type} but task is of type {$value->type}");
                    }

                    return $value;
                }

                $className = static::getTaskClassName();

                return $className::findFromString($value, $type, $locale);
            }
        );
    }

    protected static function convertToTaskOfAnyType($values, $locale = null)

    {
        return collect($values)->map(
            function ($value) use ($locale) {
                if ($value instanceof Task) {
if ($x instanceof DoesNotExist) {
    // Do something.
}
                    return $value;
                }

                $className = static::getTaskClassName();

                return $className::findFromStringOfAnyType($value, $locale);
            }
        );
    }

    /**
     * Use in place of eloquent's sync() method so that the task type may be optionally specified.
     *
     * @param $ids
     * @param string|null $type
     * @param bool        $detaching
     */
    protected function syncTaskIds($ids, string $type = null, $detaching = true)

    {
        $isUpdated = false;

        // Get a list of task_ids for all current tasks
        $current = $this->tasks()
            ->newPivotStatement()
            ->where('taskable_id', $this->getKey())
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            ->where('taskable_type', $this->getMorphClass())
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            ->when(
                $type !== null, function ($query) use ($type) {
                    $taskModel = $this->tasks()->getRelated();

                    return $query->join(
                        $taskModel->getTable(),
                        'taskables.task_id',
                        '=',
                        $taskModel->getTable().'.'.$taskModel->getKeyName()
                    )
                        ->where('tasks.type', $type);
                }
            )
            ->pluck('task_id')
            ->all();

        // Compare to the list of ids given to find the tasks to remove
        $detach = array_diff($current, $ids);
        if ($detaching && count($detach) > 0) {
            $this->tasks()->detach($detach);
            $isUpdated = true;
        }

        // Attach any new ids
        $attach = array_diff($ids, $current);
        if (count($attach) > 0) {
            collect($attach)->each(
                function ($id) {
                    $this->tasks()->attach($id, []);
                }
            );
            $isUpdated = true;
        }

        // Once we have finished attaching or detaching the records, we will see if we
        // have done any attaching or detaching, and if we have we will touch these
        // relationships if they are configured to touch on any database updates.
        if ($isUpdated) {
            $this->tasks()->touchIfTouching();
        }
    }
}


Issues (80)

Security Analysis no request data

src/Traits/HasTask.php (20 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

1. Missing dependencies

2. Missing use statement

1. Missing dependencies

2. Missing use statement

1		<?php
2
3		namespace Telefonica\Traits;
4
5		use InvalidArgumentException;
6		use Illuminate\Database\Eloquent\Model;
7		use Illuminate\Database\Eloquent\Builder;
8		use Illuminate\Database\Eloquent\Collection;
9		use Illuminate\Database\Eloquent\Relations\MorphToMany;
10		use Casa\Models\Calendar\Task;
11
12		trait HasTask
13		{
14		protected $queuedTask = [];
15
16		public static function getTaskClassName(): string
17		{
18		return Task::class;
19		}
20
21	View Code Duplication	public static function bootHasTask()
		0 ignored issues – show Duplication introduced 2020-07-20 09:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
22		{
23		static::created(
24		function (Model $taskableModel) {
25		if (count($taskableModel->queuedTask) > 0) {
26		$taskableModel->attachTask($taskableModel->queuedTask);
27
28		$taskableModel->queuedTask = [];
29		}
30		}
31		);
32
33		static::deleted(
34		function (Model $deletedModel) {
35		$tasks = $deletedModel->tasks()->get();
36
37		$deletedModel->detachTask($tasks);
38		}
39		);

SierraTecnologia / Telefonica

Issues (80)

Security Analysis no request data

src/Traits/HasTask.php (20 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

1. Missing dependencies

2. Missing use statement

1. Missing dependencies

2. Missing use statement

Duplication Side-by-Side

Filter issues like