PersonService - Code Metrics - Inspection of "update and fix bugs" - SierraTecnologia/Telefonica - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c8cc17...80abe0 )

by Ricardo

created 2021-05-27 22:59 UTC

PersonService A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	198
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

Metric	Value
wmc	20
lcom	1
cbo	1
dl	0
loc	198
rs	10
c	0
b	0
f	0

9 Methods

Rating	Name	Size	Complexity
A	__construct()	5	1
B	import()	23	6
A	all()	4	1
A	paginated()	4	1
A	find()	4	1
A	search()	4	1
A	create()	8	1
A	update()	10	3
B	cancel()	46	5

<?php

namespace Telefonica\Services;

use Illuminate\Support\Collection;
use Illuminate\Support\Facades\Config;
use Informate\Models\Refund;
use SierraTecnologia\Crypto\Services\Crypto;
use Telefonica\Repositories\PersonRepository;
use Telefonica\Models\Actors\Person;
use Muleta\Utils\Modificators\StringModificator;

class PersonService
{
    public function __construct(
        PersonRepository $personRepository
    ) {
        $this->repo = $personRepository;
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * @todo Terminar de Fazer
     *  "Nome Artístico/ apelido" => ""                                                                                                                                                                                                             
  "Nome Completo" => "Paulo Gonçalves Júnior "                                                                                                                                                                                                
  "Nascimento " => "01/07/1988"                                                                                                                                                                                                               
  "Idade" => "32 anos "                                                                                                                                                                                                                       
  "Sexo / Identificação de Gênero" => "Masculino"                                                                                                                                                                                             
  "Endereço Completo" => "Rua Mercúrio 479 Casa 1"                                                                                                                                                                                            
  "Bairro" => "Pavuna "                                                                                                                                                                                                                       
  "Cidade" => "Rio de Janeiro "                                                                                                                                                                                                               
  "Telefone que mais usa" => "21982899701"                                                                                                                                                                                                    
  "Profissão" => "Produtor Cultural e Dançarino"                                                                                                                                                                                              
  "Grau de Escolaridade" => "Segundo Grau Completo (5ª a 3ºano)"                                                                                                                                                                              
  "Curso técnico? " => " Gestão Cultural Pela Instituição Idea e Produção Cultural Pela Produtora Burburinho Cultural  ( Em Andamento)"                                                                                                       
  "Fala Inglês?" => "Entendo um Pouco"                                                                                                                                                                                                        
  "Fala Espanhol?" => "Entendo um Pouco"                                                                                                                                                                                                      
  "Fala Francês?" => "Nada"                                                                                                                                                                                                                   
  "Fala Alemão?" => "Nada"                                                                                                                                                                                                                    
  "Você tem DRT? " => "Não "                                                                                                                                                                                                                  
  " RG" => "21.551.582-6"                                                                                                                                                                                                                     
  "CPF" => "133.546.337-27"                                                                                                                                                                                                                   
  "Você tem MEI? " => "Não "                                                                                                                                                                                                                  
  "Agência e conta" => "Agência:0001 Conta Corrente: 20939021-8  Banco: Nubank "                                                                                                                                                              
  " PIX" => "Pix: 133.546.337-27"
  "Cargos na RUA?" => "Produção Executiva, Dançarina(o)"
  "Peso?" => "80 kg"
  "Calça?" => "Tamanho G"
  " Blusa?" => "Tamanho G"
  "Altura?" => "1.68"
  "Nº sapato?" => "Numeração  40"
  "Redes Sociais." => "Estou no Instagram como @lilp_king. Instale o aplicativo para seguir minhas fotos e vídeos. https://www.instagram.com/invites/contact/?i=g0zjwr5kwk4h&utm_content=wedbxz"

     */
    public static function import($data)
    {   
        $registerData = [];
        if (isset($data['Nome'])) {
            $registerData['name'] = $data["Nome"];
        }
        if (isset($data['Nome Completo'])) {
            $registerData['name'] = $data["Nome Completo"];
        }
        if (isset($data['CPF'])) {
            $registerData['cpf'] = $data["CPF"];
        }
        if (isset($data['Nascimento'])) {
            $registerData['birthday'] = $data["Nascimento"];
        }
        $code = $registerData['code'] = StringModificator::cleanCodeSlug($registerData['name']);

        if (\Telefonica\Models\Actors\Person::find($code)) {
            return true;
        }
        $person = Person::createIfNotExistAndReturn($registerData);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        return true;
    }

    /**
     * Get all Persons.
     *
     * @return Collection
     */
    public function all()
    {
        return $this->repo->all();
    }

    /**
     * Get all Persons.
     *
     * @return Illuminate\Pagination\LengthAwarePaginator
     */
    public function paginated()
    {
        return $this->repo->paginated(\Illuminate\Support\Facades\Config::get('siravel.pagination', 25));
    }

    /**
     * Find the Person by ID.
     *
     * @param int $id
     *
     * @return Persons
     */
    public function find($id)
    {
        return $this->repo->find($id);
    }

    /**
     * Search the orders.
     *
     * @param array $payload
     *
     * @return Collection
     */
    public function search($payload)
    {
        return $this->repo->search($payload, \Illuminate\Support\Facades\Config::get('siravel.pagination', 25));
    }

    /**
     * Create an order.
     *
     * @param array $payload
     *
     * @return Persons
     */
    public function create($payload)
    {
        $order = $this->repo->store($payload);

        $this->logistics->orderCreated($order);
class MyClass { }

$x = new MyClass();
$x->foo = true;

        return $order;
    }

    /**
     * Update an order.
     *
     * @param int   $id
     * @param array $payload
     *
     * @return Persons
     */
    public function update($id, $payload)
    {
        $order = $this->find($id);

        if (isset($payload['is_shipped']) && $payload['is_shipped'] !== false) {
            $this->logistics->shipPerson($order);
        }

        return $this->repo->update($order, $payload);
    }

    /**
     * Cancel an order.
     *
     * @param int $id
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     *
     * @return Persons
     */
    public function cancel($orderId)
    {
        $order = $this->repo->find($orderId);

        if ($order->status != 'complete') {
            $this->logistics->cancelPerson($order);

            if ($order->hasActivePersonItems()) {
                $refund = $this->transactions->refund($order->transaction('uuid'), $order->remainingValue());
class MyClass { }

$x = new MyClass();
$x->foo = true;

                if ($refund) {
                    $refundRecord = app(Refund::class)->create(
                        [
                        'transaction_id' => $order->transaction('id'),
                        'provider_id' => $refund->id,
                        'uuid' => Crypto::uuid(),
                        'amount' => $refund->amount,
                        'provider' => 'SierraTecnologia',
                        'charge' => $refund->charge,
                        'currency' => $refund->currency,
                        ]
                    );

                    foreach ($order->items as $item) {
                        $item->update(
                            [
                            'was_refunded' => true,
                            'status' => 'cancelled',
                            'refund_id' => $refundRecord->id,
                            ]
                        );
                    }

                    return $this->update(
                        $order->id,
                        [
                        'status' => 'cancelled',
                        'is_shipped' => false,
                        ]
                    );
                }
            }
        }

        return false;
    }
}


1			<?php
2
3			namespace Telefonica\Services;
4
5			use Illuminate\Support\Collection;
6			use Illuminate\Support\Facades\Config;
7			use Informate\Models\Refund;
8			use SierraTecnologia\Crypto\Services\Crypto;
9			use Telefonica\Repositories\PersonRepository;
10			use Telefonica\Models\Actors\Person;
11			use Muleta\Utils\Modificators\StringModificator;
12
13			class PersonService
14			{
15			public function __construct(
16			PersonRepository $personRepository
17			) {
18			$this->repo = $personRepository;
			0 ignored issues – show Bug introduced 2020-07-20 09:15 UTC by Report Bug Copy Issue Report The property `repo` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
19			}
20
21			/**
22			* @todo Terminar de Fazer
23			* "Nome Artístico/ apelido" => ""
24			"Nome Completo" => "Paulo Gonçalves Júnior "
25			"Nascimento " => "01/07/1988"
26			"Idade" => "32 anos "
27			"Sexo / Identificação de Gênero" => "Masculino"
28			"Endereço Completo" => "Rua Mercúrio 479 Casa 1"
29			"Bairro" => "Pavuna "
30			"Cidade" => "Rio de Janeiro "
31			"Telefone que mais usa" => "21982899701"
32			"Profissão" => "Produtor Cultural e Dançarino"
33			"Grau de Escolaridade" => "Segundo Grau Completo (5ª a 3ºano)"
34			"Curso técnico? " => " Gestão Cultural Pela Instituição Idea e Produção Cultural Pela Produtora Burburinho Cultural ( Em Andamento)"
35			"Fala Inglês?" => "Entendo um Pouco"
36			"Fala Espanhol?" => "Entendo um Pouco"
37			"Fala Francês?" => "Nada"
38			"Fala Alemão?" => "Nada"
39			"Você tem DRT? " => "Não "
40			" RG" => "21.551.582-6"
41			"CPF" => "133.546.337-27"
42			"Você tem MEI? " => "Não "
43			"Agência e conta" => "Agência:0001 Conta Corrente: 20939021-8 Banco: Nubank "
44			" PIX" => "Pix: 133.546.337-27"
45			"Cargos na RUA?" => "Produção Executiva, Dançarina(o)"
46			"Peso?" => "80 kg"
47			"Calça?" => "Tamanho G"
48			" Blusa?" => "Tamanho G"
49			"Altura?" => "1.68"
50			"Nº sapato?" => "Numeração 40"
51			"Redes Sociais." => "Estou no Instagram como @lilp_king. Instale o aplicativo para seguir minhas fotos e vídeos. https://www.instagram.com/invites/contact/?i=g0zjwr5kwk4h&utm_content=wedbxz"
52
53			*/
54			public static function import($data)
55			{
56			$registerData = [];
57			if (isset($data['Nome'])) {
58			$registerData['name'] = $data["Nome"];
59			}
60			if (isset($data['Nome Completo'])) {
61			$registerData['name'] = $data["Nome Completo"];
62			}
63			if (isset($data['CPF'])) {
64			$registerData['cpf'] = $data["CPF"];
65			}
66			if (isset($data['Nascimento'])) {
67			$registerData['birthday'] = $data["Nascimento"];
68			}
69			$code = $registerData['code'] = StringModificator::cleanCodeSlug($registerData['name']);
70
71			if (\Telefonica\Models\Actors\Person::find($code)) {
72			return true;
73			}
74			$person = Person::createIfNotExistAndReturn($registerData);
			0 ignored issues – show Unused Code introduced 2021-05-27 23:00 UTC by Report Bug Copy Issue Report `$person` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
75			return true;
76			}
77
78			/**
79			* Get all Persons.
80			*
81			* @return Collection
82			*/
83			public function all()
84			{
85			return $this->repo->all();
86			}
87
88			/**
89			* Get all Persons.
90			*
91			* @return Illuminate\Pagination\LengthAwarePaginator
92			*/
93			public function paginated()
94			{
95			return $this->repo->paginated(\Illuminate\Support\Facades\Config::get('siravel.pagination', 25));
96			}
97
98			/**
99			* Find the Person by ID.
100			*
101			* @param int $id
102			*
103			* @return Persons
104			*/
105			public function find($id)
106			{
107			return $this->repo->find($id);
108			}
109
110			/**
111			* Search the orders.
112			*
113			* @param array $payload
114			*
115			* @return Collection
116			*/
117			public function search($payload)
118			{
119			return $this->repo->search($payload, \Illuminate\Support\Facades\Config::get('siravel.pagination', 25));
120			}
121
122			/**
123			* Create an order.
124			*
125			* @param array $payload
126			*
127			* @return Persons
128			*/
129			public function create($payload)
130			{
131			$order = $this->repo->store($payload);
132
133			$this->logistics->orderCreated($order);
			0 ignored issues – show Bug introduced 2020-07-20 09:15 UTC by Report Bug Copy Issue Report The property `logistics` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
134
135			return $order;
136			}
137
138			/**
139			* Update an order.
140			*
141			* @param int $id
142			* @param array $payload
143			*
144			* @return Persons
145			*/
146			public function update($id, $payload)
147			{
148			$order = $this->find($id);
149
150			if (isset($payload['is_shipped']) && $payload['is_shipped'] !== false) {
151			$this->logistics->shipPerson($order);
152			}
153
154			return $this->repo->update($order, $payload);
155			}
156
157			/**
158			* Cancel an order.
159			*
160			* @param int $id
			0 ignored issues – show Bug introduced 2020-07-20 09:15 UTC by Report Bug Copy Issue Report There is no parameter named `$id`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
161			*
162			* @return Persons
163			*/
164			public function cancel($orderId)
165			{
166			$order = $this->repo->find($orderId);
167
168			if ($order->status != 'complete') {
169			$this->logistics->cancelPerson($order);
170
171			if ($order->hasActivePersonItems()) {
172			$refund = $this->transactions->refund($order->transaction('uuid'), $order->remainingValue());
			0 ignored issues – show Bug introduced 2020-07-20 09:15 UTC by Report Bug Copy Issue Report The property `transactions` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
173
174			if ($refund) {
175			$refundRecord = app(Refund::class)->create(
176			[
177			'transaction_id' => $order->transaction('id'),
178			'provider_id' => $refund->id,
179			'uuid' => Crypto::uuid(),
180			'amount' => $refund->amount,
181			'provider' => 'SierraTecnologia',
182			'charge' => $refund->charge,
183			'currency' => $refund->currency,
184			]
185			);
186
187			foreach ($order->items as $item) {
188			$item->update(
189			[
190			'was_refunded' => true,
191			'status' => 'cancelled',
192			'refund_id' => $refundRecord->id,
193			]
194			);
195			}
196
197			return $this->update(
198			$order->id,
199			[
200			'status' => 'cancelled',
201			'is_shipped' => false,
202			]
203			);
204			}
205			}
206			}
207
208			return false;
209			}
210			}
211

SierraTecnologia / Telefonica

Push — master ( c8cc17...80abe0 )

PersonService A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

9 Methods

Duplication Side-by-Side

Filter issues like