HomeController::persons() - Code Metrics - SierraTecnologia/Finder - Measure and Improve Code Quality continuously with Scrutinizer

HomeController::persons() A
last analyzed 2021-05-27 22:55 UTC

↳ Parent: HomeController

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
nc	1
nop	1
dl	0
loc	7
rs	10
c	0
b	0
f	0

<?php

namespace Finder\Http\Controllers;

use Finder\Services\FinderService;
use Illuminate\Support\Facades\Schema;
use Telefonica\Repositories\PersonRepository;
use Stalker\Models\Media;

class HomeController extends Controller
{
    protected $service;

    public function __construct(FinderService $service)
    {
        parent::__construct();

        $this->service = $service;
    }

    public function index(Request $request)

    {

        // dd($results);
        return view(
            'finder::finder.home'
            // compact('results')
        );
    }

    public function medias()
    {

        $results = Media::all();

        // dd($results);
        return view(
            'finder::components.gallery',
            compact('results')
        );
    }
    public function persons(PersonRepository $personRepo)
    {
        // $orders = $personRepo->getByCustomer(auth()->id())->orderBy('created_at', 'DESC')->paginate(\Illuminate\Support\Facades\Config::get('siravel.pagination'));
        $persons = $personRepo->all(); //->paginate(\Illuminate\Support\Facades\Config::get('siravel.pagination'));

        return view('finder::finder.persons')->with('persons', $persons);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }
}


1			<?php
2
3			namespace Finder\Http\Controllers;
4
5			use Finder\Services\FinderService;
6			use Illuminate\Support\Facades\Schema;
7			use Telefonica\Repositories\PersonRepository;
8			use Stalker\Models\Media;
9
10			class HomeController extends Controller
11			{
12			protected $service;
13
14			public function __construct(FinderService $service)
15			{
16			parent::__construct();
17
18			$this->service = $service;
19			}
20
21			public function index(Request $request)
			0 ignored issues – show Unused Code introduced 2020-10-20 08:35 UTC by Report Bug Copy Issue Report The parameter `$request` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
22			{
23
24			// dd($results);
25			return view(
26			'finder::finder.home'
27			// compact('results')
28			);
29			}
30
31			public function medias()
32			{
33
34			$results = Media::all();
35
36			// dd($results);
37			return view(
38			'finder::components.gallery',
39			compact('results')
40			);
41			}
42			public function persons(PersonRepository $personRepo)
43			{
44			// $orders = $personRepo->getByCustomer(auth()->id())->orderBy('created_at', 'DESC')->paginate(\Illuminate\Support\Facades\Config::get('siravel.pagination'));
45			$persons = $personRepo->all(); //->paginate(\Illuminate\Support\Facades\Config::get('siravel.pagination'));
46
47			return view('finder::finder.persons')->with('persons', $persons);
			0 ignored issues – show Bug introduced 2020-12-06 03:06 UTC by Report Bug Copy Issue Report The method `with` does only exist in `Illuminate\Contracts\View\View`, but not in `Illuminate\Contracts\View\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
48			}
49			}
50

SierraTecnologia / Finder

HomeController::persons() A last analyzed 2021-05-27 22:55 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like

HomeController::persons() A
last analyzed 2021-05-27 22:55 UTC