Sid\Phalcon\Cron\Job\System

Complexity

Total Complexity

6

Size/Duplication

Total Lines	63
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	7	1
A	getCommand()	0	4	1
A	getOutput()	0	4	1
A	buildCommand()	0	11	2
A	runInForeground()	0	6	1

<?php

namespace Sid\Phalcon\Cron\Job;

use Sid\Phalcon\Cron\Job;

class System extends Job
{
    /**
     * @var string
     */
    protected $command;

    /**
     * @var string
     */
    protected $output;



    public function __construct(string $expression, string $command, string $output = null)
    {
        parent::__construct($expression);

        $this->command = $command;
        $this->output  = $output;
    }



    public function getCommand() : string
    {
        return $this->command;
    }

    /**
     * @return string|null
     */
    public function getOutput()
    {
        return $this->output;
    }



    private function buildCommand() : string
    {
        $command = $this->getCommand();
        $output  = $this->getOutput();

        if ($output) {

The expression $output of type string|null is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== null instead.

            $command .= " > " . $output . " 2>&1";
        }

        return $command;
    }



    /**
     * @return string|null
     */
    public function runInForeground()
    {
        return shell_exec(
            $this->buildCommand()
        );
    }
}