Sid\Phalcon\Cron\Job

Complexity

Total Complexity

6

Size/Duplication

Total Lines	66
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	getExpression()	0	4	1
A	isDue()	0	8	1
	runInForeground()	0	1	?
A	runInBackground()	0	23	3

<?php

namespace Sid\Phalcon\Cron;

use Cron\CronExpression;
use DateTime;
use Phalcon\Di\Injectable;

abstract class Job extends Injectable implements \Sid\Cron\JobInterface
{
    /**
     * @var string
     */
    protected $expression;



    public function __construct(string $expression)
    {
        $this->expression = $expression;
    }



    public function getExpression() : string
    {
        return $this->expression;
    }



    public function isDue(DateTime $datetime = null) : bool
    {
        $cronExpression = CronExpression::factory(
            $this->getExpression()
        );

        return $cronExpression->isDue($datetime);

It seems like $datetime defined by parameter $datetime on line 32 can be null; however, Cron\CronExpression::isDue() does not accept null, maybe add an additional type check?

    }



    /**
     * @return mixed
     */
    abstract public function runInForeground();

    /**
     * @throws Exception
     */
    public function runInBackground() : Process
    {
        $processID = pcntl_fork();

        if ($processID === -1) {
            throw new Exception(
                "Failed to fork process."
            );
        }

        // This is the child process.
        if ($processID === 0) {
            // @codeCoverageIgnoreStart
            $this->runInForeground();

            exit(0);
            // @codeCoverageIgnoreEnd
        }

        $process = new Process($processID);

        return $process;
    }
}