Inspection of "Enhancments" - SherifElfadaly/Laravel-Api-Skeleton - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 8a761d...35b920 )

by Sherif

created 2020-09-10 10:12 UTC

Status

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

@@ -6,14 +6,14 @@
 block discarded – undo
 
 class View extends JsonResource
 {
-    /**
-     * Transform the resource into an array.
-     *
-     * @param Request $request
-     * @return array
-     */
-    public function toArray($request)
-    {
-        return [$this->resource];
-    }
+	/**
+	 * Transform the resource into an array.
+	 *
+	 * @param Request $request
+	 * @return array
+	 */
+	public function toArray($request)
+	{
+		return [$this->resource];
+	}
 }

Please login to merge, or discard this patch.

src/Modules/Reporting/Http/Controllers/ReportController.php 1 patch

Indentation +33 added lines, -33 removed lines patch added patch discarded remove patch

@@ -9,40 +9,40 @@
 block discarded – undo
 
 class ReportController extends BaseApiController
 {
-    /**
-     * Path of the model resource
-     *
-     * @var string
-     */
-    protected $modelResource = 'App\Modules\Reporting\Http\Resources\Report';
+	/**
+	 * Path of the model resource
+	 *
+	 * @var string
+	 */
+	protected $modelResource = 'App\Modules\Reporting\Http\Resources\Report';
 
-    /**
-     * List of all route actions that the base api controller
-     * will skip permissions check for them.
-     * @var array
-     */
-    protected $skipPermissionCheck = ['getReport'];
+	/**
+	 * List of all route actions that the base api controller
+	 * will skip permissions check for them.
+	 * @var array
+	 */
+	protected $skipPermissionCheck = ['getReport'];
 
-    /**
-     * Init new object.
-     *
-     * @param   ReportService $service
-     * @return  void
-     */
-    public function __construct(ReportService $service)
-    {
-        parent::__construct($service);
-    }
+	/**
+	 * Init new object.
+	 *
+	 * @param   ReportService $service
+	 * @return  void
+	 */
+	public function __construct(ReportService $service)
+	{
+		parent::__construct($service);
+	}
 
-    /**
-     * Render the given servicert name with the given conditions.
-     *
-     * @param Request $request
-     * @param  string $reportName Name of the requested servicert
-     * @return \Illuminate\Http\Response
-     */
-    public function getReport(Request $request, $reportName)
-    {
-        return new ViewResource($this->service->getReport($reportName, $request->all(), $request->query('perPage')));
-    }
+	/**
+	 * Render the given servicert name with the given conditions.
+	 *
+	 * @param Request $request
+	 * @param  string $reportName Name of the requested servicert
+	 * @return \Illuminate\Http\Response
+	 */
+	public function getReport(Request $request, $reportName)
+	{
+		return new ViewResource($this->service->getReport($reportName, $request->all(), $request->query('perPage')));
+	}
 }

Please login to merge, or discard this patch.

files/BroadcastServiceProvider.php 2 patches

Unused Use Statements +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -2,7 +2,7 @@
 block discarded – undo
 
 namespace App\Providers;
 
-use Illuminate\Support\ServiceProvider;
+use Illuminate\Support\ServiceProvider;
 use Illuminate\Support\Facades\Broadcast;
 
 class BroadcastServiceProvider extends ServiceProvider

Please login to merge, or discard this patch.

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

@@ -7,15 +7,15 @@
 block discarded – undo
 
 class BroadcastServiceProvider extends ServiceProvider
 {
-    /**
-     * Bootstrap any application services.
-     *
-     * @return void
-     */
-    public function boot()
-    {
-        Broadcast::routes(['middleware' => ['auth:api']]);
+	/**
+	 * Bootstrap any application services.
+	 *
+	 * @return void
+	 */
+	public function boot()
+	{
+		Broadcast::routes(['middleware' => ['auth:api']]);
 
-        require base_path('routes/channels.php');
-    }
+		require base_path('routes/channels.php');
+	}
 }

Please login to merge, or discard this patch.

src/Modules/Core/Http/Middleware/UpdateLocaleAndTimezone.php 2 patches

Doc Comments -1 removed lines patch added patch discarded remove patch

@@ -16,7 +16,6 @@
 block discarded – undo
      *
      * @param   Session      $session
      * @param   Auth         $auth
-     * @param   Errors       $errors
      *
      * @return  void
      */

Please login to merge, or discard this patch.

Indentation +44 added lines, -44 removed lines patch added patch discarded remove patch

@@ -8,53 +8,53 @@
 block discarded – undo
 
 class UpdateLocaleAndTimezone
 {
-    protected $session;
-    protected $auth;
+	protected $session;
+	protected $auth;
     
-    /**
-     * Init new object.
-     *
-     * @param   Session      $session
-     * @param   Auth         $auth
-     * @param   Errors       $errors
-     *
-     * @return  void
-     */
-    public function __construct(Session $session, Auth $auth)
-    {
-        $this->session = $session;
-        $this->auth = $auth;
-    }
+	/**
+	 * Init new object.
+	 *
+	 * @param   Session      $session
+	 * @param   Auth         $auth
+	 * @param   Errors       $errors
+	 *
+	 * @return  void
+	 */
+	public function __construct(Session $session, Auth $auth)
+	{
+		$this->session = $session;
+		$this->auth = $auth;
+	}
 
-    /**
-     * Handle an incoming request.
-     *
-     * @param  \Illuminate\Http\Request  $request
-     * @param  \Closure  $next
-     * @return mixed
-     */
-    public function handle($request, Closure $next)
-    {
-        $update = false;
-        $user   = $this->auth->user();
-        if ($user) {
-            $locale   = $this->session->get('locale');
-            $timezone = $this->session->get('time-zone');
-            if ($locale && $locale !== 'all' && $locale !== $user->locale) {
-                $user->locale = $locale;
-                $update       = true;
-            }
+	/**
+	 * Handle an incoming request.
+	 *
+	 * @param  \Illuminate\Http\Request  $request
+	 * @param  \Closure  $next
+	 * @return mixed
+	 */
+	public function handle($request, Closure $next)
+	{
+		$update = false;
+		$user   = $this->auth->user();
+		if ($user) {
+			$locale   = $this->session->get('locale');
+			$timezone = $this->session->get('time-zone');
+			if ($locale && $locale !== 'all' && $locale !== $user->locale) {
+				$user->locale = $locale;
+				$update       = true;
+			}
     
-            if ($timezone && $timezone !== $user->timezone) {
-                $user->timezone = $timezone;
-                $update         = true;
-            }
+			if ($timezone && $timezone !== $user->timezone) {
+				$user->timezone = $timezone;
+				$update         = true;
+			}
     
-            if ($update) {
-                $user->save();
-            }
-        }
+			if ($update) {
+				$user->save();
+			}
+		}
 
-        return $next($request);
-    }
+		return $next($request);
+	}
 }

Please login to merge, or discard this patch.

files/HttpKernel.php 1 patch

Indentation +73 added lines, -73 removed lines patch added patch discarded remove patch

@@ -6,81 +6,81 @@
 block discarded – undo
 
 class Kernel extends HttpKernel
 {
-    /**
-     * The application's global HTTP middleware stack.
-     *
-     * These middleware are run during every request to your application.
-     *
-     * @var array
-     */
-    protected $middleware = [
-        \App\Http\Middleware\TrustProxies::class,
-        \App\Http\Middleware\CheckForMaintenanceMode::class,
-        \Illuminate\Foundation\Http\Middleware\ValidatePostSize::class,
-        \App\Http\Middleware\TrimStrings::class,
-        \Illuminate\Foundation\Http\Middleware\ConvertEmptyStringsToNull::class,
-    ];
+	/**
+	 * The application's global HTTP middleware stack.
+	 *
+	 * These middleware are run during every request to your application.
+	 *
+	 * @var array
+	 */
+	protected $middleware = [
+		\App\Http\Middleware\TrustProxies::class,
+		\App\Http\Middleware\CheckForMaintenanceMode::class,
+		\Illuminate\Foundation\Http\Middleware\ValidatePostSize::class,
+		\App\Http\Middleware\TrimStrings::class,
+		\Illuminate\Foundation\Http\Middleware\ConvertEmptyStringsToNull::class,
+	];
 
-    /**
-     * The application's route middleware groups.
-     *
-     * @var array
-     */
-    protected $middlewareGroups = [
-        'web' => [
-            \App\Http\Middleware\EncryptCookies::class,
-            \Illuminate\Cookie\Middleware\AddQueuedCookiesToResponse::class,
-            \Illuminate\Session\Middleware\StartSession::class,
-            // \Illuminate\Session\Middleware\AuthenticateSession::class,
-            \Illuminate\View\Middleware\ShareErrorsFromSession::class,
-            \App\Http\Middleware\VerifyCsrfToken::class,
-            \Illuminate\Routing\Middleware\SubstituteBindings::class,
-        ],
+	/**
+	 * The application's route middleware groups.
+	 *
+	 * @var array
+	 */
+	protected $middlewareGroups = [
+		'web' => [
+			\App\Http\Middleware\EncryptCookies::class,
+			\Illuminate\Cookie\Middleware\AddQueuedCookiesToResponse::class,
+			\Illuminate\Session\Middleware\StartSession::class,
+			// \Illuminate\Session\Middleware\AuthenticateSession::class,
+			\Illuminate\View\Middleware\ShareErrorsFromSession::class,
+			\App\Http\Middleware\VerifyCsrfToken::class,
+			\Illuminate\Routing\Middleware\SubstituteBindings::class,
+		],
 
-        'api' => [
-            'throttle:60,1',
-            \Illuminate\Routing\Middleware\SubstituteBindings::class,
-            \App\Modules\Core\Http\Middleware\SetSessions::class,
-            \App\Modules\Core\Http\Middleware\CheckPermissions::class,
-            \App\Modules\Core\Http\Middleware\UpdateLocaleAndTimezone::class,
-            \App\Modules\Core\Http\Middleware\SetRelations::class,
-        ],
-    ];
+		'api' => [
+			'throttle:60,1',
+			\Illuminate\Routing\Middleware\SubstituteBindings::class,
+			\App\Modules\Core\Http\Middleware\SetSessions::class,
+			\App\Modules\Core\Http\Middleware\CheckPermissions::class,
+			\App\Modules\Core\Http\Middleware\UpdateLocaleAndTimezone::class,
+			\App\Modules\Core\Http\Middleware\SetRelations::class,
+		],
+	];
 
-    /**
-     * The application's route middleware.
-     *
-     * These middleware may be assigned to groups or used individually.
-     *
-     * @var array
-     */
-    protected $routeMiddleware = [
-        'auth' => \App\Http\Middleware\Authenticate::class,
-        'auth.basic' => \Illuminate\Auth\Middleware\AuthenticateWithBasicAuth::class,
-        'bindings' => \Illuminate\Routing\Middleware\SubstituteBindings::class,
-        'cache.headers' => \Illuminate\Http\Middleware\SetCacheHeaders::class,
-        'can' => \Illuminate\Auth\Middleware\Authorize::class,
-        'guest' => \App\Http\Middleware\RedirectIfAuthenticated::class,
-        'password.confirm' => \Illuminate\Auth\Middleware\RequirePassword::class,
-        'signed' => \Illuminate\Routing\Middleware\ValidateSignature::class,
-        'throttle' => \Illuminate\Routing\Middleware\ThrottleRequests::class,
-        'verified' => \Illuminate\Auth\Middleware\EnsureEmailIsVerified::class,
-    ];
+	/**
+	 * The application's route middleware.
+	 *
+	 * These middleware may be assigned to groups or used individually.
+	 *
+	 * @var array
+	 */
+	protected $routeMiddleware = [
+		'auth' => \App\Http\Middleware\Authenticate::class,
+		'auth.basic' => \Illuminate\Auth\Middleware\AuthenticateWithBasicAuth::class,
+		'bindings' => \Illuminate\Routing\Middleware\SubstituteBindings::class,
+		'cache.headers' => \Illuminate\Http\Middleware\SetCacheHeaders::class,
+		'can' => \Illuminate\Auth\Middleware\Authorize::class,
+		'guest' => \App\Http\Middleware\RedirectIfAuthenticated::class,
+		'password.confirm' => \Illuminate\Auth\Middleware\RequirePassword::class,
+		'signed' => \Illuminate\Routing\Middleware\ValidateSignature::class,
+		'throttle' => \Illuminate\Routing\Middleware\ThrottleRequests::class,
+		'verified' => \Illuminate\Auth\Middleware\EnsureEmailIsVerified::class,
+	];
 
-    /**
-     * The priority-sorted list of middleware.
-     *
-     * This forces non-global middleware to always be in the given order.
-     *
-     * @var array
-     */
-    protected $middlewarePriority = [
-        \Illuminate\Session\Middleware\StartSession::class,
-        \Illuminate\View\Middleware\ShareErrorsFromSession::class,
-        \App\Http\Middleware\Authenticate::class,
-        \Illuminate\Routing\Middleware\ThrottleRequests::class,
-        \Illuminate\Session\Middleware\AuthenticateSession::class,
-        \Illuminate\Routing\Middleware\SubstituteBindings::class,
-        \Illuminate\Auth\Middleware\Authorize::class,
-    ];
+	/**
+	 * The priority-sorted list of middleware.
+	 *
+	 * This forces non-global middleware to always be in the given order.
+	 *
+	 * @var array
+	 */
+	protected $middlewarePriority = [
+		\Illuminate\Session\Middleware\StartSession::class,
+		\Illuminate\View\Middleware\ShareErrorsFromSession::class,
+		\App\Http\Middleware\Authenticate::class,
+		\Illuminate\Routing\Middleware\ThrottleRequests::class,
+		\Illuminate\Session\Middleware\AuthenticateSession::class,
+		\Illuminate\Routing\Middleware\SubstituteBindings::class,
+		\Illuminate\Auth\Middleware\Authorize::class,
+	];
 }

Please login to merge, or discard this patch.

files/channels.php 2 patches

Indentation +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -12,5 +12,5 @@
 block discarded – undo
 */
 
 Broadcast::channel('users.{id}', function ($user, $id) {
-    return (int) $user->id === (int) $id;
+	return (int) $user->id === (int) $id;
 });

Please login to merge, or discard this patch.

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -11,6 +11,6 @@
 block discarded – undo
 |
 */
 
-Broadcast::channel('users.{id}', function ($user, $id) {
+Broadcast::channel('users.{id}', function($user, $id) {
     return (int) $user->id === (int) $id;
 });

Please login to merge, or discard this patch.

files/auth.php 1 patch

Indentation +35 added lines, -35 removed lines patch added patch discarded remove patch

		@@ -2,7 +2,7 @@ discard block
		block discarded – undo
2	2
3	3	return [
4	4
5		- /*
	5	+ /*
6	6	\|--------------------------------------------------------------------------
7	7	\| Authentication Defaults
8	8	\|--------------------------------------------------------------------------
		@@ -13,12 +13,12 @@ discard block
		block discarded – undo
13	13	\|
14	14	*/
15	15
16		- 'defaults' => [
17		- 'guard' => 'web',
18		- 'passwords' => 'users',
19		- ],
	16	+ 'defaults' => [
	17	+ 'guard' => 'web',
	18	+ 'passwords' => 'users',
	19	+ ],
20	20
21		- /*
	21	+ /*
22	22	\|--------------------------------------------------------------------------
23	23	\| Authentication Guards
24	24	\|--------------------------------------------------------------------------
		@@ -35,19 +35,19 @@ discard block
		block discarded – undo
35	35	\|
36	36	*/
37	37
38		- 'guards' => [
39		- 'web' => [
40		- 'driver' => 'session',
41		- 'provider' => 'users',
42		- ],
	38	+ 'guards' => [
	39	+ 'web' => [
	40	+ 'driver' => 'session',
	41	+ 'provider' => 'users',
	42	+ ],
43	43
44		- 'api' => [
45		- 'driver' => 'passport',
46		- 'provider' => 'users',
47		- ],
48		- ],
	44	+ 'api' => [
	45	+ 'driver' => 'passport',
	46	+ 'provider' => 'users',
	47	+ ],
	48	+ ],
49	49
50		- /*
	50	+ /*
51	51	\|--------------------------------------------------------------------------
52	52	\| User Providers
53	53	\|--------------------------------------------------------------------------
		@@ -64,19 +64,19 @@ discard block
		block discarded – undo
64	64	\|
65	65	*/
66	66
67		- 'providers' => [
68		- 'users' => [
69		- 'driver' => 'eloquent',
70		- 'model' => App\Modules\Users\AclUser::class,
71		- ],
	67	+ 'providers' => [
	68	+ 'users' => [
	69	+ 'driver' => 'eloquent',
	70	+ 'model' => App\Modules\Users\AclUser::class,
	71	+ ],
72	72
73		- // 'users' => [
74		- // 'driver' => 'database',
75		- // 'table' => 'users',
76		- // ],
77		- ],
	73	+ // 'users' => [
	74	+ // 'driver' => 'database',
	75	+ // 'table' => 'users',
	76	+ // ],
	77	+ ],
78	78
79		- /*
	79	+ /*
80	80	\|--------------------------------------------------------------------------
81	81	\| Resetting Passwords
82	82	\|--------------------------------------------------------------------------
		@@ -91,12 +91,12 @@ discard block
		block discarded – undo
91	91	\|
92	92	*/
93	93
94		- 'passwords' => [
95		- 'users' => [
96		- 'provider' => 'users',
97		- 'table' => 'password_resets',
98		- 'expire' => 60,
99		- ],
100		- ],
	94	+ 'passwords' => [
	95	+ 'users' => [
	96	+ 'provider' => 'users',
	97	+ 'table' => 'password_resets',
	98	+ 'expire' => 60,
	99	+ ],
	100	+ ],
101	101
102	102	];

Please login to merge, or discard this patch.

files/AuthServiceProvider.php 2 patches

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -25,7 +25,7 @@
 block discarded – undo
     {
         $this->registerPolicies();
 
-        Passport::routes(function ($router) {
+        Passport::routes(function($router) {
             $router->forAuthorization();
             $router->forAccessTokens();
             $router->forPersonalAccessTokens();

Please login to merge, or discard this patch.

Indentation +25 added lines, -25 removed lines patch added patch discarded remove patch

@@ -7,31 +7,31 @@
 block discarded – undo
 
 class AuthServiceProvider extends ServiceProvider
 {
-    /**
-     * The policy mappings for the application.
-     *
-     * @var array
-     */
-    protected $policies = [
-        'App\Model' => 'App\Policies\ModelPolicy',
-    ];
+	/**
+	 * The policy mappings for the application.
+	 *
+	 * @var array
+	 */
+	protected $policies = [
+		'App\Model' => 'App\Policies\ModelPolicy',
+	];
 
-    /**
-     * Register any authentication / authorization services.
-     *
-     * @return void
-     */
-    public function boot()
-    {
-        $this->registerPolicies();
+	/**
+	 * Register any authentication / authorization services.
+	 *
+	 * @return void
+	 */
+	public function boot()
+	{
+		$this->registerPolicies();
 
-        Passport::routes(function ($router) {
-            $router->forAuthorization();
-            $router->forAccessTokens();
-            $router->forPersonalAccessTokens();
-            $router->forTransientTokens();
-        });
-        Passport::tokensExpireIn(\Carbon\Carbon::now()->addMinutes(60));
-        Passport::refreshTokensExpireIn(\Carbon\Carbon::now()->addMinutes(14400));
-    }
+		Passport::routes(function ($router) {
+			$router->forAuthorization();
+			$router->forAccessTokens();
+			$router->forPersonalAccessTokens();
+			$router->forTransientTokens();
+		});
+		Passport::tokensExpireIn(\Carbon\Carbon::now()->addMinutes(60));
+		Passport::refreshTokensExpireIn(\Carbon\Carbon::now()->addMinutes(14400));
+	}
 }

Please login to merge, or discard this patch.

src/Modules/Core/Console/Commands/Stubs/Module/Services/DummyService.php 1 patch

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

@@ -5,14 +5,14 @@
 block discarded – undo
 
 class DummyService extends BaseService
 {
-    /**
-     * Init new object.
-     *
-     * @param   DummyRepository $repo
-     * @return  void
-     */
-    public function __construct(DummyRepository $repo)
-    {
-        parent::__construct($repo);
-    }
+	/**
+	 * Init new object.
+	 *
+	 * @param   DummyRepository $repo
+	 * @return  void
+	 */
+	public function __construct(DummyRepository $repo)
+	{
+		parent::__construct($repo);
+	}
 }

Please login to merge, or discard this patch.

		@@ -6,14 +6,14 @@
		block discarded – undo
6	6
7	7	class View extends JsonResource
8	8	{
9		- /**
10		- * Transform the resource into an array.
11		- *
12		- * @param Request $request
13		- * @return array
14		- */
15		- public function toArray($request)
16		- {
17		- return [$this->resource];
18		- }
	9	+ /**
	10	+ * Transform the resource into an array.
	11	+ *
	12	+ * @param Request $request
	13	+ * @return array
	14	+ */
	15	+ public function toArray($request)
	16	+ {
	17	+ return [$this->resource];
	18	+ }
19	19	}

		@@ -9,40 +9,40 @@
		block discarded – undo
9	9
10	10	class ReportController extends BaseApiController
11	11	{
12		- /**
13		- * Path of the model resource
14		- *
15		- * @var string
16		- */
17		- protected $modelResource = 'App\Modules\Reporting\Http\Resources\Report';
	12	+ /**
	13	+ * Path of the model resource
	14	+ *
	15	+ * @var string
	16	+ */
	17	+ protected $modelResource = 'App\Modules\Reporting\Http\Resources\Report';
18	18
19		- /**
20		- * List of all route actions that the base api controller
21		- * will skip permissions check for them.
22		- * @var array
23		- */
24		- protected $skipPermissionCheck = ['getReport'];
	19	+ /**
	20	+ * List of all route actions that the base api controller
	21	+ * will skip permissions check for them.
	22	+ * @var array
	23	+ */
	24	+ protected $skipPermissionCheck = ['getReport'];
25	25
26		- /**
27		- * Init new object.
28		- *
29		- * @param ReportService $service
30		- * @return void
31		- */
32		- public function __construct(ReportService $service)
33		- {
34		- parent::__construct($service);
35		- }
	26	+ /**
	27	+ * Init new object.
	28	+ *
	29	+ * @param ReportService $service
	30	+ * @return void
	31	+ */
	32	+ public function __construct(ReportService $service)
	33	+ {
	34	+ parent::__construct($service);
	35	+ }
36	36
37		- /**
38		- * Render the given servicert name with the given conditions.
39		- *
40		- * @param Request $request
41		- * @param string $reportName Name of the requested servicert
42		- * @return \Illuminate\Http\Response
43		- */
44		- public function getReport(Request $request, $reportName)
45		- {
46		- return new ViewResource($this->service->getReport($reportName, $request->all(), $request->query('perPage')));
47		- }
	37	+ /**
	38	+ * Render the given servicert name with the given conditions.
	39	+ *
	40	+ * @param Request $request
	41	+ * @param string $reportName Name of the requested servicert
	42	+ * @return \Illuminate\Http\Response
	43	+ */
	44	+ public function getReport(Request $request, $reportName)
	45	+ {
	46	+ return new ViewResource($this->service->getReport($reportName, $request->all(), $request->query('perPage')));
	47	+ }
48	48	}

		@@ -2,7 +2,7 @@
		block discarded – undo
2	2
3	3	namespace App\Providers;
4	4
5		-use Illuminate\Support\ServiceProvider;
	5	+use Illuminate\Support\ServiceProvider;
6	6	use Illuminate\Support\Facades\Broadcast;
7	7
8	8	class BroadcastServiceProvider extends ServiceProvider

		@@ -7,15 +7,15 @@
		block discarded – undo
7	7
8	8	class BroadcastServiceProvider extends ServiceProvider
9	9	{
10		- /**
11		- * Bootstrap any application services.
12		- *
13		- * @return void
14		- */
15		- public function boot()
16		- {
17		- Broadcast::routes(['middleware' => ['auth:api']]);
	10	+ /**
	11	+ * Bootstrap any application services.
	12	+ *
	13	+ * @return void
	14	+ */
	15	+ public function boot()
	16	+ {
	17	+ Broadcast::routes(['middleware' => ['auth:api']]);
18	18
19		- require base_path('routes/channels.php');
20		- }
	19	+ require base_path('routes/channels.php');
	20	+ }
21	21	}

		@@ -16,7 +16,6 @@
		block discarded – undo
16	16	*
17	17	* @param Session $session
18	18	* @param Auth $auth
19		- * @param Errors $errors
20	19	*
21	20	* @return void
22	21	*/

		@@ -8,53 +8,53 @@
		block discarded – undo
8	8
9	9	class UpdateLocaleAndTimezone
10	10	{
11		- protected $session;
12		- protected $auth;
	11	+ protected $session;
	12	+ protected $auth;
13	13
14		- /**
15		- * Init new object.
16		- *
17		- * @param Session $session
18		- * @param Auth $auth
19		- * @param Errors $errors
20		- *
21		- * @return void
22		- */
23		- public function __construct(Session $session, Auth $auth)
24		- {
25		- $this->session = $session;
26		- $this->auth = $auth;
27		- }
	14	+ /**
	15	+ * Init new object.
	16	+ *
	17	+ * @param Session $session
	18	+ * @param Auth $auth
	19	+ * @param Errors $errors
	20	+ *
	21	+ * @return void
	22	+ */
	23	+ public function __construct(Session $session, Auth $auth)
	24	+ {
	25	+ $this->session = $session;
	26	+ $this->auth = $auth;
	27	+ }
28	28
29		- /**
30		- * Handle an incoming request.
31		- *
32		- * @param \Illuminate\Http\Request $request
33		- * @param \Closure $next
34		- * @return mixed
35		- */
36		- public function handle($request, Closure $next)
37		- {
38		- $update = false;
39		- $user = $this->auth->user();
40		- if ($user) {
41		- $locale = $this->session->get('locale');
42		- $timezone = $this->session->get('time-zone');
43		- if ($locale && $locale !== 'all' && $locale !== $user->locale) {
44		- $user->locale = $locale;
45		- $update = true;
46		- }
	29	+ /**
	30	+ * Handle an incoming request.
	31	+ *
	32	+ * @param \Illuminate\Http\Request $request
	33	+ * @param \Closure $next
	34	+ * @return mixed
	35	+ */
	36	+ public function handle($request, Closure $next)
	37	+ {
	38	+ $update = false;
	39	+ $user = $this->auth->user();
	40	+ if ($user) {
	41	+ $locale = $this->session->get('locale');
	42	+ $timezone = $this->session->get('time-zone');
	43	+ if ($locale && $locale !== 'all' && $locale !== $user->locale) {
	44	+ $user->locale = $locale;
	45	+ $update = true;
	46	+ }
47	47
48		- if ($timezone && $timezone !== $user->timezone) {
49		- $user->timezone = $timezone;
50		- $update = true;
51		- }
	48	+ if ($timezone && $timezone !== $user->timezone) {
	49	+ $user->timezone = $timezone;
	50	+ $update = true;
	51	+ }
52	52
53		- if ($update) {
54		- $user->save();
55		- }
56		- }
	53	+ if ($update) {
	54	+ $user->save();
	55	+ }
	56	+ }
57	57
58		- return $next($request);
59		- }
	58	+ return $next($request);
	59	+ }
60	60	}

		@@ -6,81 +6,81 @@
		block discarded – undo
6	6
7	7	class Kernel extends HttpKernel
8	8	{
9		- /**
10		- * The application's global HTTP middleware stack.
11		- *
12		- * These middleware are run during every request to your application.
13		- *
14		- * @var array
15		- */
16		- protected $middleware = [
17		- \App\Http\Middleware\TrustProxies::class,
18		- \App\Http\Middleware\CheckForMaintenanceMode::class,
19		- \Illuminate\Foundation\Http\Middleware\ValidatePostSize::class,
20		- \App\Http\Middleware\TrimStrings::class,
21		- \Illuminate\Foundation\Http\Middleware\ConvertEmptyStringsToNull::class,
22		- ];
	9	+ /**
	10	+ * The application's global HTTP middleware stack.
	11	+ *
	12	+ * These middleware are run during every request to your application.
	13	+ *
	14	+ * @var array
	15	+ */
	16	+ protected $middleware = [
	17	+ \App\Http\Middleware\TrustProxies::class,
	18	+ \App\Http\Middleware\CheckForMaintenanceMode::class,
	19	+ \Illuminate\Foundation\Http\Middleware\ValidatePostSize::class,
	20	+ \App\Http\Middleware\TrimStrings::class,
	21	+ \Illuminate\Foundation\Http\Middleware\ConvertEmptyStringsToNull::class,
	22	+ ];
23	23
24		- /**
25		- * The application's route middleware groups.
26		- *
27		- * @var array
28		- */
29		- protected $middlewareGroups = [
30		- 'web' => [
31		- \App\Http\Middleware\EncryptCookies::class,
32		- \Illuminate\Cookie\Middleware\AddQueuedCookiesToResponse::class,
33		- \Illuminate\Session\Middleware\StartSession::class,
34		- // \Illuminate\Session\Middleware\AuthenticateSession::class,
35		- \Illuminate\View\Middleware\ShareErrorsFromSession::class,
36		- \App\Http\Middleware\VerifyCsrfToken::class,
37		- \Illuminate\Routing\Middleware\SubstituteBindings::class,
38		- ],
	24	+ /**
	25	+ * The application's route middleware groups.
	26	+ *
	27	+ * @var array
	28	+ */
	29	+ protected $middlewareGroups = [
	30	+ 'web' => [
	31	+ \App\Http\Middleware\EncryptCookies::class,
	32	+ \Illuminate\Cookie\Middleware\AddQueuedCookiesToResponse::class,
	33	+ \Illuminate\Session\Middleware\StartSession::class,
	34	+ // \Illuminate\Session\Middleware\AuthenticateSession::class,
	35	+ \Illuminate\View\Middleware\ShareErrorsFromSession::class,
	36	+ \App\Http\Middleware\VerifyCsrfToken::class,
	37	+ \Illuminate\Routing\Middleware\SubstituteBindings::class,
	38	+ ],
39	39
40		- 'api' => [
41		- 'throttle:60,1',
42		- \Illuminate\Routing\Middleware\SubstituteBindings::class,
43		- \App\Modules\Core\Http\Middleware\SetSessions::class,
44		- \App\Modules\Core\Http\Middleware\CheckPermissions::class,
45		- \App\Modules\Core\Http\Middleware\UpdateLocaleAndTimezone::class,
46		- \App\Modules\Core\Http\Middleware\SetRelations::class,
47		- ],
48		- ];
	40	+ 'api' => [
	41	+ 'throttle:60,1',
	42	+ \Illuminate\Routing\Middleware\SubstituteBindings::class,
	43	+ \App\Modules\Core\Http\Middleware\SetSessions::class,
	44	+ \App\Modules\Core\Http\Middleware\CheckPermissions::class,
	45	+ \App\Modules\Core\Http\Middleware\UpdateLocaleAndTimezone::class,
	46	+ \App\Modules\Core\Http\Middleware\SetRelations::class,
	47	+ ],
	48	+ ];
49	49
50		- /**
51		- * The application's route middleware.
52		- *
53		- * These middleware may be assigned to groups or used individually.
54		- *
55		- * @var array
56		- */
57		- protected $routeMiddleware = [
58		- 'auth' => \App\Http\Middleware\Authenticate::class,
59		- 'auth.basic' => \Illuminate\Auth\Middleware\AuthenticateWithBasicAuth::class,
60		- 'bindings' => \Illuminate\Routing\Middleware\SubstituteBindings::class,
61		- 'cache.headers' => \Illuminate\Http\Middleware\SetCacheHeaders::class,
62		- 'can' => \Illuminate\Auth\Middleware\Authorize::class,
63		- 'guest' => \App\Http\Middleware\RedirectIfAuthenticated::class,
64		- 'password.confirm' => \Illuminate\Auth\Middleware\RequirePassword::class,
65		- 'signed' => \Illuminate\Routing\Middleware\ValidateSignature::class,
66		- 'throttle' => \Illuminate\Routing\Middleware\ThrottleRequests::class,
67		- 'verified' => \Illuminate\Auth\Middleware\EnsureEmailIsVerified::class,
68		- ];
	50	+ /**
	51	+ * The application's route middleware.
	52	+ *
	53	+ * These middleware may be assigned to groups or used individually.
	54	+ *
	55	+ * @var array
	56	+ */
	57	+ protected $routeMiddleware = [
	58	+ 'auth' => \App\Http\Middleware\Authenticate::class,
	59	+ 'auth.basic' => \Illuminate\Auth\Middleware\AuthenticateWithBasicAuth::class,
	60	+ 'bindings' => \Illuminate\Routing\Middleware\SubstituteBindings::class,
	61	+ 'cache.headers' => \Illuminate\Http\Middleware\SetCacheHeaders::class,
	62	+ 'can' => \Illuminate\Auth\Middleware\Authorize::class,
	63	+ 'guest' => \App\Http\Middleware\RedirectIfAuthenticated::class,
	64	+ 'password.confirm' => \Illuminate\Auth\Middleware\RequirePassword::class,
	65	+ 'signed' => \Illuminate\Routing\Middleware\ValidateSignature::class,
	66	+ 'throttle' => \Illuminate\Routing\Middleware\ThrottleRequests::class,
	67	+ 'verified' => \Illuminate\Auth\Middleware\EnsureEmailIsVerified::class,
	68	+ ];
69	69
70		- /**
71		- * The priority-sorted list of middleware.
72		- *
73		- * This forces non-global middleware to always be in the given order.
74		- *
75		- * @var array
76		- */
77		- protected $middlewarePriority = [
78		- \Illuminate\Session\Middleware\StartSession::class,
79		- \Illuminate\View\Middleware\ShareErrorsFromSession::class,
80		- \App\Http\Middleware\Authenticate::class,
81		- \Illuminate\Routing\Middleware\ThrottleRequests::class,
82		- \Illuminate\Session\Middleware\AuthenticateSession::class,
83		- \Illuminate\Routing\Middleware\SubstituteBindings::class,
84		- \Illuminate\Auth\Middleware\Authorize::class,
85		- ];
	70	+ /**
	71	+ * The priority-sorted list of middleware.
	72	+ *
	73	+ * This forces non-global middleware to always be in the given order.
	74	+ *
	75	+ * @var array
	76	+ */
	77	+ protected $middlewarePriority = [
	78	+ \Illuminate\Session\Middleware\StartSession::class,
	79	+ \Illuminate\View\Middleware\ShareErrorsFromSession::class,
	80	+ \App\Http\Middleware\Authenticate::class,
	81	+ \Illuminate\Routing\Middleware\ThrottleRequests::class,
	82	+ \Illuminate\Session\Middleware\AuthenticateSession::class,
	83	+ \Illuminate\Routing\Middleware\SubstituteBindings::class,
	84	+ \Illuminate\Auth\Middleware\Authorize::class,
	85	+ ];
86	86	}

		@@ -12,5 +12,5 @@
		block discarded – undo
12	12	*/
13	13
14	14	Broadcast::channel('users.{id}', function ($user, $id) {
15		- return (int) $user->id === (int) $id;
	15	+ return (int) $user->id === (int) $id;
16	16	});

		@@ -11,6 +11,6 @@
		block discarded – undo
11	11	\|
12	12	*/
13	13
14		-Broadcast::channel('users.{id}', function ($user, $id) {
	14	+Broadcast::channel('users.{id}', function($user, $id) {
15	15	return (int) $user->id === (int) $id;
16	16	});

		@@ -25,7 +25,7 @@
		block discarded – undo
25	25	{
26	26	$this->registerPolicies();
27	27
28		- Passport::routes(function ($router) {
	28	+ Passport::routes(function($router) {
29	29	$router->forAuthorization();
30	30	$router->forAccessTokens();
31	31	$router->forPersonalAccessTokens();

		@@ -7,31 +7,31 @@
		block discarded – undo
7	7
8	8	class AuthServiceProvider extends ServiceProvider
9	9	{
10		- /**
11		- * The policy mappings for the application.
12		- *
13		- * @var array
14		- */
15		- protected $policies = [
16		- 'App\Model' => 'App\Policies\ModelPolicy',
17		- ];
	10	+ /**
	11	+ * The policy mappings for the application.
	12	+ *
	13	+ * @var array
	14	+ */
	15	+ protected $policies = [
	16	+ 'App\Model' => 'App\Policies\ModelPolicy',
	17	+ ];
18	18
19		- /**
20		- * Register any authentication / authorization services.
21		- *
22		- * @return void
23		- */
24		- public function boot()
25		- {
26		- $this->registerPolicies();
	19	+ /**
	20	+ * Register any authentication / authorization services.
	21	+ *
	22	+ * @return void
	23	+ */
	24	+ public function boot()
	25	+ {
	26	+ $this->registerPolicies();
27	27
28		- Passport::routes(function ($router) {
29		- $router->forAuthorization();
30		- $router->forAccessTokens();
31		- $router->forPersonalAccessTokens();
32		- $router->forTransientTokens();
33		- });
34		- Passport::tokensExpireIn(\Carbon\Carbon::now()->addMinutes(60));
35		- Passport::refreshTokensExpireIn(\Carbon\Carbon::now()->addMinutes(14400));
36		- }
	28	+ Passport::routes(function ($router) {
	29	+ $router->forAuthorization();
	30	+ $router->forAccessTokens();
	31	+ $router->forPersonalAccessTokens();
	32	+ $router->forTransientTokens();
	33	+ });
	34	+ Passport::tokensExpireIn(\Carbon\Carbon::now()->addMinutes(60));
	35	+ Passport::refreshTokensExpireIn(\Carbon\Carbon::now()->addMinutes(14400));
	36	+ }
37	37	}

		@@ -5,14 +5,14 @@
		block discarded – undo
5	5
6	6	class DummyService extends BaseService
7	7	{
8		- /**
9		- * Init new object.
10		- *
11		- * @param DummyRepository $repo
12		- * @return void
13		- */
14		- public function __construct(DummyRepository $repo)
15		- {
16		- parent::__construct($repo);
17		- }
	8	+ /**
	9	+ * Init new object.
	10	+ *
	11	+ * @param DummyRepository $repo
	12	+ * @return void
	13	+ */
	14	+ public function __construct(DummyRepository $repo)
	15	+ {
	16	+ parent::__construct($repo);
	17	+ }
18	18	}

SherifElfadaly / Laravel-Api-Skeleton

Push — master ( 8a761d...35b920 )

Status

Category

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

Indentation +33 added lines, -33 removed lines patch added patch discarded remove patch

Unused Use Statements +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

Doc Comments -1 removed lines patch added patch discarded remove patch

Indentation +44 added lines, -44 removed lines patch added patch discarded remove patch

Indentation +73 added lines, -73 removed lines patch added patch discarded remove patch

Indentation +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +35 added lines, -35 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +25 added lines, -25 removed lines patch added patch discarded remove patch

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch