Inspection of "add push notifications" - SherifElfadaly/Laravel-Api-Skeleton - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 503ff2...5d1103 )

by Sherif

created 2016-04-07 13:53 UTC

Status

Indentation +39 added lines, -39 removed lines patch added patch discarded remove patch

@@ -5,44 +5,44 @@
 block discarded – undo
  */
 class LogObserver {
 
-    public function saving($model)
-    {
-        //
-    }
-
-    public function saved($model)
-    {
-        //
-    }
-
-    public function creating($model)
-    {
-        //
-    }
-
-    public function created($model)
-    {
-        //
-    }
-
-    public function updating($model)
-    {
-        //
-    }
-
-    public function updated($model)
-    {
-        //
-    }
-
-    public function deleting($model)
-    {
-        //
-    }
-
-    public function deleted($model)
-    {
-        //
-    }
+	public function saving($model)
+	{
+		//
+	}
+
+	public function saved($model)
+	{
+		//
+	}
+
+	public function creating($model)
+	{
+		//
+	}
+
+	public function created($model)
+	{
+		//
+	}
+
+	public function updating($model)
+	{
+		//
+	}
+
+	public function updated($model)
+	{
+		//
+	}
+
+	public function deleting($model)
+	{
+		//
+	}
+
+	public function deleted($model)
+	{
+		//
+	}
 
 }
\ No newline at end of file

Please login to merge, or discard this patch.

Database/Migrations/2016_01_24_111942_push_notifications_devices.php 2 patches

Indentation +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -18,7 +18,7 @@
 block discarded – undo
 			$table->string('view_name',100);
 			$table->softDeletes();
 			$table->timestamps();
-        });
+		});
 	}
 
 	/**

Please login to merge, or discard this patch.

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -12,9 +12,9 @@
 block discarded – undo
 	 */
 	public function up()
 	{
-		Schema::create('push_notifications_devices', function (Blueprint $table) {
+		Schema::create('push_notifications_devices', function(Blueprint $table) {
 			$table->increments('id');
-			$table->string('device_token',100);
+			$table->string('device_token', 100);
 			$table->enum('device_type', ['android', 'ios']);
 			$table->integer('user_id');
 			$table->boolean('active')->default(1);

Please login to merge, or discard this patch.

Database/Migrations/2016_01_24_123631_initialize_notifications.php 1 patch

Indentation +124 added lines, -124 removed lines patch added patch discarded remove patch

@@ -12,134 +12,134 @@
 block discarded – undo
 	 */
 	public function up()
 	{
-        /**
-         * Delete previous permissions.
-         */
+		/**
+		 * Delete previous permissions.
+		 */
 		DB::table('permissions')->whereIn('model', ['notifications'])->delete();
 
 		/**
-         * Insert the permissions related to this module.
-         */
-        DB::table('permissions')->insert(
-        	[
-        		/**
-        		 * notifications model permissions.
-        		 */
-	        	[
-	        	'name'       => 'find',
-	        	'model'      => 'notifications',
-	        	'created_at' => \DB::raw('NOW()'),
-	        	'updated_at' => \DB::raw('NOW()')
-	        	],
-	        	[
-	        	'name'       => 'search',
-	        	'model'      => 'notifications',
-	        	'created_at' => \DB::raw('NOW()'),
-	        	'updated_at' => \DB::raw('NOW()')
-	        	],
-	        	[
-	        	'name'       => 'list',
-	        	'model'      => 'notifications',
-	        	'created_at' => \DB::raw('NOW()'),
-	        	'updated_at' => \DB::raw('NOW()')
-	        	],
-	        	[
-	        	'name'       => 'findby',
-	        	'model'      => 'notifications',
-	        	'created_at' => \DB::raw('NOW()'),
-	        	'updated_at' => \DB::raw('NOW()')
-	        	],
-	        	[
-	        	'name'       => 'first',
-	        	'model'      => 'notifications',
-	        	'created_at' => \DB::raw('NOW()'),
-	        	'updated_at' => \DB::raw('NOW()')
-	        	],
-	        	[
-	        	'name'       => 'paginate',
-	        	'model'      => 'notifications',
-	        	'created_at' => \DB::raw('NOW()'),
-	        	'updated_at' => \DB::raw('NOW()')
-	        	],
-	        	[
-	        	'name'       => 'paginateby',
-	        	'model'      => 'notifications',
-	        	'created_at' => \DB::raw('NOW()'),
-	        	'updated_at' => \DB::raw('NOW()')
-	        	],
-	        	[
-	        	'name'       => 'notified',
-	        	'model'      => 'notifications',
-	        	'created_at' => \DB::raw('NOW()'),
-	        	'updated_at' => \DB::raw('NOW()')
-	        	],
-	        	[
-	        	'name'       => 'notifyall',
-	        	'model'      => 'notifications',
-	        	'created_at' => \DB::raw('NOW()'),
-	        	'updated_at' => \DB::raw('NOW()')
-	        	],
-	        	/**
-        		 * pushNotificationsDevices model permissions.
-        		 */
-	        	[
-	        	'name'       => 'find',
-	        	'model'      => 'pushNotificationsDevices',
-	        	'created_at' => \DB::raw('NOW()'),
-	        	'updated_at' => \DB::raw('NOW()')
-	        	],
-	        	[
-	        	'name'       => 'search',
-	        	'model'      => 'pushNotificationsDevices',
-	        	'created_at' => \DB::raw('NOW()'),
-	        	'updated_at' => \DB::raw('NOW()')
-	        	],
-	        	[
-	        	'name'       => 'list',
-	        	'model'      => 'pushNotificationsDevices',
-	        	'created_at' => \DB::raw('NOW()'),
-	        	'updated_at' => \DB::raw('NOW()')
-	        	],
-	        	[
-	        	'name'       => 'findby',
-	        	'model'      => 'pushNotificationsDevices',
-	        	'created_at' => \DB::raw('NOW()'),
-	        	'updated_at' => \DB::raw('NOW()')
-	        	],
-	        	[
-	        	'name'       => 'first',
-	        	'model'      => 'pushNotificationsDevices',
-	        	'created_at' => \DB::raw('NOW()'),
-	        	'updated_at' => \DB::raw('NOW()')
-	        	],
-	        	[
-	        	'name'       => 'paginate',
-	        	'model'      => 'pushNotificationsDevices',
-	        	'created_at' => \DB::raw('NOW()'),
-	        	'updated_at' => \DB::raw('NOW()')
-	        	],
-	        	[
-	        	'name'       => 'paginateby',
-	        	'model'      => 'pushNotificationsDevices',
-	        	'created_at' => \DB::raw('NOW()'),
-	        	'updated_at' => \DB::raw('NOW()')
-	        	],
-	        	[
-	        	'name'       => 'save',
-	        	'model'      => 'pushNotificationsDevices',
-	        	'created_at' => \DB::raw('NOW()'),
-	        	'updated_at' => \DB::raw('NOW()')
-	        	],
-	        	[
-	        	'name'       => 'delete',
-	        	'model'      => 'pushNotificationsDevices',
-	        	'created_at' => \DB::raw('NOW()'),
-	        	'updated_at' => \DB::raw('NOW()')
-	        	],
-        	]
-        );
+		 * Insert the permissions related to this module.
+		 */
+		DB::table('permissions')->insert(
+			[
+				/**
+				 * notifications model permissions.
+				 */
+				[
+				'name'       => 'find',
+				'model'      => 'notifications',
+				'created_at' => \DB::raw('NOW()'),
+				'updated_at' => \DB::raw('NOW()')
+				],
+				[
+				'name'       => 'search',
+				'model'      => 'notifications',
+				'created_at' => \DB::raw('NOW()'),
+				'updated_at' => \DB::raw('NOW()')
+				],
+				[
+				'name'       => 'list',
+				'model'      => 'notifications',
+				'created_at' => \DB::raw('NOW()'),
+				'updated_at' => \DB::raw('NOW()')
+				],
+				[
+				'name'       => 'findby',
+				'model'      => 'notifications',
+				'created_at' => \DB::raw('NOW()'),
+				'updated_at' => \DB::raw('NOW()')
+				],
+				[
+				'name'       => 'first',
+				'model'      => 'notifications',
+				'created_at' => \DB::raw('NOW()'),
+				'updated_at' => \DB::raw('NOW()')
+				],
+				[
+				'name'       => 'paginate',
+				'model'      => 'notifications',
+				'created_at' => \DB::raw('NOW()'),
+				'updated_at' => \DB::raw('NOW()')
+				],
+				[
+				'name'       => 'paginateby',
+				'model'      => 'notifications',
+				'created_at' => \DB::raw('NOW()'),
+				'updated_at' => \DB::raw('NOW()')
+				],
+				[
+				'name'       => 'notified',
+				'model'      => 'notifications',
+				'created_at' => \DB::raw('NOW()'),
+				'updated_at' => \DB::raw('NOW()')
+				],
+				[
+				'name'       => 'notifyall',
+				'model'      => 'notifications',
+				'created_at' => \DB::raw('NOW()'),
+				'updated_at' => \DB::raw('NOW()')
+				],
+				/**
+				 * pushNotificationsDevices model permissions.
+				 */
+				[
+				'name'       => 'find',
+				'model'      => 'pushNotificationsDevices',
+				'created_at' => \DB::raw('NOW()'),
+				'updated_at' => \DB::raw('NOW()')
+				],
+				[
+				'name'       => 'search',
+				'model'      => 'pushNotificationsDevices',
+				'created_at' => \DB::raw('NOW()'),
+				'updated_at' => \DB::raw('NOW()')
+				],
+				[
+				'name'       => 'list',
+				'model'      => 'pushNotificationsDevices',
+				'created_at' => \DB::raw('NOW()'),
+				'updated_at' => \DB::raw('NOW()')
+				],
+				[
+				'name'       => 'findby',
+				'model'      => 'pushNotificationsDevices',
+				'created_at' => \DB::raw('NOW()'),
+				'updated_at' => \DB::raw('NOW()')
+				],
+				[
+				'name'       => 'first',
+				'model'      => 'pushNotificationsDevices',
+				'created_at' => \DB::raw('NOW()'),
+				'updated_at' => \DB::raw('NOW()')
+				],
+				[
+				'name'       => 'paginate',
+				'model'      => 'pushNotificationsDevices',
+				'created_at' => \DB::raw('NOW()'),
+				'updated_at' => \DB::raw('NOW()')
+				],
+				[
+				'name'       => 'paginateby',
+				'model'      => 'pushNotificationsDevices',
+				'created_at' => \DB::raw('NOW()'),
+				'updated_at' => \DB::raw('NOW()')
+				],
+				[
+				'name'       => 'save',
+				'model'      => 'pushNotificationsDevices',
+				'created_at' => \DB::raw('NOW()'),
+				'updated_at' => \DB::raw('NOW()')
+				],
+				[
+				'name'       => 'delete',
+				'model'      => 'pushNotificationsDevices',
+				'created_at' => \DB::raw('NOW()'),
+				'updated_at' => \DB::raw('NOW()')
+				],
+			]
+		);
 
-        /**
+		/**
 		 * Assign the permissions to the admin group.
 		 */
 		$permissionIds = DB::table('permissions')->whereIn('model', ['notifications'])->select('id')->lists('id');

Please login to merge, or discard this patch.

		@@ -5,44 +5,44 @@
		block discarded – undo
5	5	*/
6	6	class LogObserver {
7	7
8		- public function saving($model)
9		- {
10		- //
11		- }
12		-
13		- public function saved($model)
14		- {
15		- //
16		- }
17		-
18		- public function creating($model)
19		- {
20		- //
21		- }
22		-
23		- public function created($model)
24		- {
25		- //
26		- }
27		-
28		- public function updating($model)
29		- {
30		- //
31		- }
32		-
33		- public function updated($model)
34		- {
35		- //
36		- }
37		-
38		- public function deleting($model)
39		- {
40		- //
41		- }
42		-
43		- public function deleted($model)
44		- {
45		- //
46		- }
	8	+ public function saving($model)
	9	+ {
	10	+ //
	11	+ }
	12	+
	13	+ public function saved($model)
	14	+ {
	15	+ //
	16	+ }
	17	+
	18	+ public function creating($model)
	19	+ {
	20	+ //
	21	+ }
	22	+
	23	+ public function created($model)
	24	+ {
	25	+ //
	26	+ }
	27	+
	28	+ public function updating($model)
	29	+ {
	30	+ //
	31	+ }
	32	+
	33	+ public function updated($model)
	34	+ {
	35	+ //
	36	+ }
	37	+
	38	+ public function deleting($model)
	39	+ {
	40	+ //
	41	+ }
	42	+
	43	+ public function deleted($model)
	44	+ {
	45	+ //
	46	+ }
47	47
48	48	}
49	49	\ No newline at end of file

		@@ -18,7 +18,7 @@
		block discarded – undo
18	18	$table->string('view_name',100);
19	19	$table->softDeletes();
20	20	$table->timestamps();
21		- });
	21	+ });
22	22	}
23	23
24	24	/**

		@@ -12,9 +12,9 @@
		block discarded – undo
12	12	*/
13	13	public function up()
14	14	{
15		- Schema::create('push_notifications_devices', function (Blueprint $table) {
	15	+ Schema::create('push_notifications_devices', function(Blueprint $table) {
16	16	$table->increments('id');
17		- $table->string('device_token',100);
	17	+ $table->string('device_token', 100);
18	18	$table->enum('device_type', ['android', 'ios']);
19	19	$table->integer('user_id');
20	20	$table->boolean('active')->default(1);

		@@ -12,134 +12,134 @@
		block discarded – undo
12	12	*/
13	13	public function up()
14	14	{
15		- /**
16		- * Delete previous permissions.
17		- */
	15	+ /**
	16	+ * Delete previous permissions.
	17	+ */
18	18	DB::table('permissions')->whereIn('model', ['notifications'])->delete();
19	19
20	20	/**
21		- * Insert the permissions related to this module.
22		- */
23		- DB::table('permissions')->insert(
24		- [
25		- /**
26		- * notifications model permissions.
27		- */
28		- [
29		- 'name' => 'find',
30		- 'model' => 'notifications',
31		- 'created_at' => \DB::raw('NOW()'),
32		- 'updated_at' => \DB::raw('NOW()')
33		- ],
34		- [
35		- 'name' => 'search',
36		- 'model' => 'notifications',
37		- 'created_at' => \DB::raw('NOW()'),
38		- 'updated_at' => \DB::raw('NOW()')
39		- ],
40		- [
41		- 'name' => 'list',
42		- 'model' => 'notifications',
43		- 'created_at' => \DB::raw('NOW()'),
44		- 'updated_at' => \DB::raw('NOW()')
45		- ],
46		- [
47		- 'name' => 'findby',
48		- 'model' => 'notifications',
49		- 'created_at' => \DB::raw('NOW()'),
50		- 'updated_at' => \DB::raw('NOW()')
51		- ],
52		- [
53		- 'name' => 'first',
54		- 'model' => 'notifications',
55		- 'created_at' => \DB::raw('NOW()'),
56		- 'updated_at' => \DB::raw('NOW()')
57		- ],
58		- [
59		- 'name' => 'paginate',
60		- 'model' => 'notifications',
61		- 'created_at' => \DB::raw('NOW()'),
62		- 'updated_at' => \DB::raw('NOW()')
63		- ],
64		- [
65		- 'name' => 'paginateby',
66		- 'model' => 'notifications',
67		- 'created_at' => \DB::raw('NOW()'),
68		- 'updated_at' => \DB::raw('NOW()')
69		- ],
70		- [
71		- 'name' => 'notified',
72		- 'model' => 'notifications',
73		- 'created_at' => \DB::raw('NOW()'),
74		- 'updated_at' => \DB::raw('NOW()')
75		- ],
76		- [
77		- 'name' => 'notifyall',
78		- 'model' => 'notifications',
79		- 'created_at' => \DB::raw('NOW()'),
80		- 'updated_at' => \DB::raw('NOW()')
81		- ],
82		- /**
83		- * pushNotificationsDevices model permissions.
84		- */
85		- [
86		- 'name' => 'find',
87		- 'model' => 'pushNotificationsDevices',
88		- 'created_at' => \DB::raw('NOW()'),
89		- 'updated_at' => \DB::raw('NOW()')
90		- ],
91		- [
92		- 'name' => 'search',
93		- 'model' => 'pushNotificationsDevices',
94		- 'created_at' => \DB::raw('NOW()'),
95		- 'updated_at' => \DB::raw('NOW()')
96		- ],
97		- [
98		- 'name' => 'list',
99		- 'model' => 'pushNotificationsDevices',
100		- 'created_at' => \DB::raw('NOW()'),
101		- 'updated_at' => \DB::raw('NOW()')
102		- ],
103		- [
104		- 'name' => 'findby',
105		- 'model' => 'pushNotificationsDevices',
106		- 'created_at' => \DB::raw('NOW()'),
107		- 'updated_at' => \DB::raw('NOW()')
108		- ],
109		- [
110		- 'name' => 'first',
111		- 'model' => 'pushNotificationsDevices',
112		- 'created_at' => \DB::raw('NOW()'),
113		- 'updated_at' => \DB::raw('NOW()')
114		- ],
115		- [
116		- 'name' => 'paginate',
117		- 'model' => 'pushNotificationsDevices',
118		- 'created_at' => \DB::raw('NOW()'),
119		- 'updated_at' => \DB::raw('NOW()')
120		- ],
121		- [
122		- 'name' => 'paginateby',
123		- 'model' => 'pushNotificationsDevices',
124		- 'created_at' => \DB::raw('NOW()'),
125		- 'updated_at' => \DB::raw('NOW()')
126		- ],
127		- [
128		- 'name' => 'save',
129		- 'model' => 'pushNotificationsDevices',
130		- 'created_at' => \DB::raw('NOW()'),
131		- 'updated_at' => \DB::raw('NOW()')
132		- ],
133		- [
134		- 'name' => 'delete',
135		- 'model' => 'pushNotificationsDevices',
136		- 'created_at' => \DB::raw('NOW()'),
137		- 'updated_at' => \DB::raw('NOW()')
138		- ],
139		- ]
140		- );
	21	+ * Insert the permissions related to this module.
	22	+ */
	23	+ DB::table('permissions')->insert(
	24	+ [
	25	+ /**
	26	+ * notifications model permissions.
	27	+ */
	28	+ [
	29	+ 'name' => 'find',
	30	+ 'model' => 'notifications',
	31	+ 'created_at' => \DB::raw('NOW()'),
	32	+ 'updated_at' => \DB::raw('NOW()')
	33	+ ],
	34	+ [
	35	+ 'name' => 'search',
	36	+ 'model' => 'notifications',
	37	+ 'created_at' => \DB::raw('NOW()'),
	38	+ 'updated_at' => \DB::raw('NOW()')
	39	+ ],
	40	+ [
	41	+ 'name' => 'list',
	42	+ 'model' => 'notifications',
	43	+ 'created_at' => \DB::raw('NOW()'),
	44	+ 'updated_at' => \DB::raw('NOW()')
	45	+ ],
	46	+ [
	47	+ 'name' => 'findby',
	48	+ 'model' => 'notifications',
	49	+ 'created_at' => \DB::raw('NOW()'),
	50	+ 'updated_at' => \DB::raw('NOW()')
	51	+ ],
	52	+ [
	53	+ 'name' => 'first',
	54	+ 'model' => 'notifications',
	55	+ 'created_at' => \DB::raw('NOW()'),
	56	+ 'updated_at' => \DB::raw('NOW()')
	57	+ ],
	58	+ [
	59	+ 'name' => 'paginate',
	60	+ 'model' => 'notifications',
	61	+ 'created_at' => \DB::raw('NOW()'),
	62	+ 'updated_at' => \DB::raw('NOW()')
	63	+ ],
	64	+ [
	65	+ 'name' => 'paginateby',
	66	+ 'model' => 'notifications',
	67	+ 'created_at' => \DB::raw('NOW()'),
	68	+ 'updated_at' => \DB::raw('NOW()')
	69	+ ],
	70	+ [
	71	+ 'name' => 'notified',
	72	+ 'model' => 'notifications',
	73	+ 'created_at' => \DB::raw('NOW()'),
	74	+ 'updated_at' => \DB::raw('NOW()')
	75	+ ],
	76	+ [
	77	+ 'name' => 'notifyall',
	78	+ 'model' => 'notifications',
	79	+ 'created_at' => \DB::raw('NOW()'),
	80	+ 'updated_at' => \DB::raw('NOW()')
	81	+ ],
	82	+ /**
	83	+ * pushNotificationsDevices model permissions.
	84	+ */
	85	+ [
	86	+ 'name' => 'find',
	87	+ 'model' => 'pushNotificationsDevices',
	88	+ 'created_at' => \DB::raw('NOW()'),
	89	+ 'updated_at' => \DB::raw('NOW()')
	90	+ ],
	91	+ [
	92	+ 'name' => 'search',
	93	+ 'model' => 'pushNotificationsDevices',
	94	+ 'created_at' => \DB::raw('NOW()'),
	95	+ 'updated_at' => \DB::raw('NOW()')
	96	+ ],
	97	+ [
	98	+ 'name' => 'list',
	99	+ 'model' => 'pushNotificationsDevices',
	100	+ 'created_at' => \DB::raw('NOW()'),
	101	+ 'updated_at' => \DB::raw('NOW()')
	102	+ ],
	103	+ [
	104	+ 'name' => 'findby',
	105	+ 'model' => 'pushNotificationsDevices',
	106	+ 'created_at' => \DB::raw('NOW()'),
	107	+ 'updated_at' => \DB::raw('NOW()')
	108	+ ],
	109	+ [
	110	+ 'name' => 'first',
	111	+ 'model' => 'pushNotificationsDevices',
	112	+ 'created_at' => \DB::raw('NOW()'),
	113	+ 'updated_at' => \DB::raw('NOW()')
	114	+ ],
	115	+ [
	116	+ 'name' => 'paginate',
	117	+ 'model' => 'pushNotificationsDevices',
	118	+ 'created_at' => \DB::raw('NOW()'),
	119	+ 'updated_at' => \DB::raw('NOW()')
	120	+ ],
	121	+ [
	122	+ 'name' => 'paginateby',
	123	+ 'model' => 'pushNotificationsDevices',
	124	+ 'created_at' => \DB::raw('NOW()'),
	125	+ 'updated_at' => \DB::raw('NOW()')
	126	+ ],
	127	+ [
	128	+ 'name' => 'save',
	129	+ 'model' => 'pushNotificationsDevices',
	130	+ 'created_at' => \DB::raw('NOW()'),
	131	+ 'updated_at' => \DB::raw('NOW()')
	132	+ ],
	133	+ [
	134	+ 'name' => 'delete',
	135	+ 'model' => 'pushNotificationsDevices',
	136	+ 'created_at' => \DB::raw('NOW()'),
	137	+ 'updated_at' => \DB::raw('NOW()')
	138	+ ],
	139	+ ]
	140	+ );
141	141
142		- /**
	142	+ /**
143	143	* Assign the permissions to the admin group.
144	144	*/
145	145	$permissionIds = DB::table('permissions')->whereIn('model', ['notifications'])->select('id')->lists('id');

SherifElfadaly / Laravel-Api-Skeleton

Push — master ( 503ff2...5d1103 )

Status

Category

Indentation +39 added lines, -39 removed lines patch added patch discarded remove patch

Indentation +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Indentation +124 added lines, -124 removed lines patch added patch discarded remove patch