SherifElfadaly / Laravel-Api-Skeleton

src/Modules/Acl/Repositories/UserRepository.php

Doc Comments +2 added lines, -2 removed lines

@@ -155,7 +155,7 @@ 
      * 
      * @param  array   $credentials
      * @param  boolean $skipConfirmEmail
-     * @return array
+     * @return boolean
      */
     public function register($credentials, $skipConfirmEmail = false)
     {
@@ -246,7 +246,7 @@ 
      * Reset the given user's password.
      *
      * @param  array  $credentials
-     * @return array
+     * @return string|null
      */
     public function resetPassword($credentials)
     {

Spacing +4 added lines, -4 removed lines

@@ -28,7 +28,7 @@ 
         $user        = \Core::users()->find(\Auth::id(), $relations);
         foreach ($user->groups()->get() as $group)
         {
-            $group->permissions->each(function ($permission) use (&$permissions){
+            $group->permissions->each(function($permission) use (&$permissions){
                 $permissions[$permission->model][$permission->id] = $permission->name;
             });
         }
@@ -51,7 +51,7 @@ 
         $user        = $user ?: $this->find(\Auth::id(), ['groups.permissions']);
         $permissions = [];
 
-        $user->groups->pluck('permissions')->each(function ($permission) use (&$permissions, $model){
+        $user->groups->pluck('permissions')->each(function($permission) use (&$permissions, $model){
             $permissions = array_merge($permissions, $permission->where('model', $model)->pluck('name')->toArray()); 
         });
         
@@ -80,7 +80,7 @@ 
      */
     public function assignGroups($userId, $groupIds)
     {
-        \DB::transaction(function () use ($userId, $groupIds) {
+        \DB::transaction(function() use ($userId, $groupIds) {
             $user = $this->find($userId);
             $user->groups()->detach();
             $user->groups()->attach($groupIds);
@@ -250,7 +250,7 @@ 
      */
     public function resetPassword($credentials)
     {
-        $response = \Password::reset($credentials, function ($user, $password) {
+        $response = \Password::reset($credentials, function($user, $password) {
             $user->password = $password;
             $user->save();
         });

src/Modules/Core/AbstractRepositories/AbstractRepository.php

Doc Comments +8 added lines, -8 removed lines

@@ -32,7 +32,7 @@ 
      *
      * @param  array   $relations
      * @param  string  $sortBy
-     * @param  boolean $desc
+     * @param  integer $desc
      * @param  array   $columns
      * @return collection
      */
@@ -50,7 +50,7 @@ 
      * @param  integer $perPage
      * @param  array   $relations
      * @param  string  $sortBy
-     * @param  boolean $desc
+     * @param  integer $desc
      * @param  array   $columns
      * @return collection
      */
@@ -164,7 +164,7 @@ 
      * @param  integer $perPage
      * @param  array   $relations
      * @param  string  $sortBy
-     * @param  boolean $desc
+     * @param  integer $desc
      * @param  array   $columns
      * @return collection
      */
@@ -182,7 +182,7 @@ 
      * @param  integer $perPage
      * @param  array   $relations
      * @param  string  $sortBy
-     * @param  boolean $desc
+     * @param  integer $desc
      * @param  array   $columns
      * @return collection
      */
@@ -198,7 +198,7 @@ 
      * Save the given model to the storage.
      * 
      * @param  array $data
-     * @return mixed
+     * @return boolean
      */
     public function save(array $data)
     {
@@ -517,7 +517,7 @@ 
      * id.
      * 
      * @param  integer $id
-     * @param  array   $relations
+     * @param  string[]   $relations
      * @param  array   $columns
      * @return object
      */
@@ -533,7 +533,7 @@ 
      * @param  array   $conditions array of conditions
      * @param  array   $relations
      * @param  string  $sortBy
-     * @param  boolean $desc
+     * @param  integer $desc
      * @param  array   $columns
      * @return collection
      */
@@ -565,7 +565,7 @@ 
      * @param  array   $conditions array of conditions
      * @param  integer $perPage
      * @param  string  $sortBy
-     * @param  boolean $desc
+     * @param  integer $desc
      * @param  array   $columns
      * @return collection
      */

src/Modules/Core/Console/Commands/GenerateDoc.php

Doc Comments +2 added lines, -2 removed lines

@@ -124,7 +124,7 @@ 
      * based on the docblock.
      * 
      * @param  array  &$route
-     * @param  object $reflectionMethod
+     * @param  \ReflectionMethod $reflectionMethod
      * @return void
      */
     protected function processDocBlock(&$route, $reflectionMethod)
@@ -148,7 +148,7 @@ 
      * Generate post body for the given route.
      * 
      * @param  array  &$route
-     * @param  object $reflectionMethod
+     * @param  \ReflectionMethod $reflectionMethod
      * @param  array  $validationRules
      * @return void
      */

src/Modules/Notifications/Repositories/PushNotificationDeviceRepository.php

Doc Comments +1 added lines, -1 removed lines

@@ -21,7 +21,7 @@
      * Register the given device to the logged in user.
      *
      * @param  array $data
-     * @return void
+     * @return boolean
      */
     public function registerDevice($data)
     {

src/Modules/Acl/Http/Controllers/UsersController.php

Spacing +4 added lines, -4 removed lines

@@ -13,7 +13,7 @@ 
      * to preform actions like (add, edit ... etc).
      * @var string
      */
-    protected $model               = 'users';
+    protected $model = 'users';
 
     /**
      * List of all route actions that the base api controller
@@ -27,14 +27,14 @@ 
      * will skip login check for them.
      * @var array
      */
-    protected $skipLoginCheck      = ['login', 'loginSocial', 'register', 'sendreset', 'resetpassword', 'refreshtoken', 'confirmEmail', 'resendEmailConfirmation'];
+    protected $skipLoginCheck = ['login', 'loginSocial', 'register', 'sendreset', 'resetpassword', 'refreshtoken', 'confirmEmail', 'resendEmailConfirmation'];
 
     /**
      * The validations rules used by the base api controller
      * to check before add.
      * @var array
      */
-    protected $validationRules     = [
+    protected $validationRules = [
         'name'     => 'nullable|string', 
         'email'    => 'required|email|unique:users,email,{id}', 
         'password' => 'nullable|min:6'
@@ -281,7 +281,7 @@ 
         $this->validate($request, [
             'profile_picture' => 'nullable|string',
             'name'            => 'nullable|string', 
-            'email'           => 'required|email|unique:users,email,' . \Auth::id()
+            'email'           => 'required|email|unique:users,email,'.\Auth::id()
         ]);
 
         return \Response::json($this->repo->saveProfile($request->only('name', 'email', 'profile_picture')), 200);

src/Modules/Core/Utl/Media.php

Spacing +10 added lines, -10 removed lines

@@ -11,13 +11,13 @@ 
      */
     public function uploadImage($image, $dir) 
     {
-       $imageName       =  str_slug('image' . uniqid() . time() . '_' . $image->getClientOriginalName());
-       $destinationPath = 'media' . DIRECTORY_SEPARATOR . $dir . DIRECTORY_SEPARATOR;
+       $imageName       = str_slug('image'.uniqid().time().'_'.$image->getClientOriginalName());
+       $destinationPath = 'media'.DIRECTORY_SEPARATOR.$dir.DIRECTORY_SEPARATOR;
 
        ! file_exists($destinationPath) ? \File::makeDirectory($destinationPath) : false;
        $image->move($destinationPath, $imageName);
 
-       return url($destinationPath . $imageName);
+       return url($destinationPath.$imageName);
     }
 
     /**
@@ -29,20 +29,20 @@ 
      */
     public function uploadImageBas64($image, $dir) 
     {
-        if (! strlen($image)) 
+        if ( ! strlen($image)) 
         {
             return null;
         }
         
-        $imageName       = 'image' . uniqid() . time() . '.jpg';
-        $destinationPath = 'media' . DIRECTORY_SEPARATOR . $dir . DIRECTORY_SEPARATOR;
+        $imageName       = 'image'.uniqid().time().'.jpg';
+        $destinationPath = 'media'.DIRECTORY_SEPARATOR.$dir.DIRECTORY_SEPARATOR;
 
         ! file_exists($destinationPath) ? \File::makeDirectory($destinationPath) : false;
 
-        $base  = base64_decode(preg_replace('#^data:image/\w+;base64,#i', '', $image));
-        \Image::make($base)->save($destinationPath . $imageName);
+        $base = base64_decode(preg_replace('#^data:image/\w+;base64,#i', '', $image));
+        \Image::make($base)->save($destinationPath.$imageName);
 
-        return url($destinationPath . $imageName);
+        return url($destinationPath.$imageName);
     }
 
     /**
@@ -55,7 +55,7 @@ 
     public function deleteImage($path, $dir) 
     {   
         $arr      = explode('/', $path);
-        $path     = 'media' . DIRECTORY_SEPARATOR . $dir . DIRECTORY_SEPARATOR . end($arr);
+        $path     = 'media'.DIRECTORY_SEPARATOR.$dir.DIRECTORY_SEPARATOR.end($arr);
         if (\File::exists($path)) 
         {
             \File::delete($path);