Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
8 | View Code Duplication | class RouteServiceProvider extends ServiceProvider |
|
|
|||
9 | { |
||
10 | /** |
||
11 | * This namespace is applied to your controller routes. |
||
12 | * |
||
13 | * In addition, it is set as the URL generator's root namespace. |
||
14 | * |
||
15 | * @var string |
||
16 | */ |
||
17 | protected $namespace = 'App\Modules\Users\Http\Controllers'; |
||
18 | |||
19 | /** |
||
20 | * Define your route model bindings, pattern filters, etc. |
||
21 | * |
||
22 | * @return void |
||
23 | */ |
||
24 | public function boot() |
||
30 | |||
31 | /** |
||
32 | * Define the routes for the module. |
||
33 | * |
||
34 | * @return void |
||
35 | */ |
||
36 | public function map() |
||
44 | |||
45 | /** |
||
46 | * Define the "web" routes for the module. |
||
47 | * |
||
48 | * These routes all receive session state, CSRF protection, etc. |
||
49 | * |
||
50 | * @return void |
||
51 | */ |
||
52 | protected function mapWebRoutes() |
||
61 | |||
62 | /** |
||
63 | * Define the "api" routes for the module. |
||
64 | * |
||
65 | * These routes are typically stateless. |
||
66 | * |
||
67 | * @return void |
||
68 | */ |
||
69 | protected function mapApiRoutes() |
||
79 | } |
||
80 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.