SherifElfadaly / Laravel-Api-Skeleton

src/Modules/Acl/Http/Controllers/UsersController.php

Doc Comments +1 added lines, -1 removed lines

@@ -268,7 +268,7 @@
      * @param  string $groupName The name of the requested group.
      * @param  integer $perPage  Number of rows per page default 15.
      * @param  string  $sortBy   The name of the column to sort by.
-     * @param  boolean $desc     Sort ascending or descinding (1: desc, 0: asc).
+     * @param  integer $desc     Sort ascending or descinding (1: desc, 0: asc).
      * @return \Illuminate\Http\Response
      */
     public function group(Request $request, $groupName, $perPage = false, $sortBy = 'created_at', $desc = 1)

src/Modules/Acl/Repositories/UserRepository.php

Doc Comments +2 added lines, -2 removed lines

@@ -144,7 +144,7 @@ 
      *
      * @param  array   $credentials
      * @param  boolean $skipConfirmEmail
-     * @return array
+     * @return boolean
      */
     public function register($credentials, $skipConfirmEmail = false)
     {
@@ -344,7 +344,7 @@ 
      * Save the given data to the logged in user.
      *
      * @param  array $data
-     * @return void
+     * @return boolean
      */
     public function saveProfile($data)
     {

Spacing +16 added lines, -16 removed lines

@@ -28,7 +28,7 @@ 
         $permissions = [];
         $user        = \Core::users()->find(\Auth::id(), $relations);
         foreach ($user->groups()->get() as $group) {
-            $group->permissions->each(function ($permission) use (&$permissions) {
+            $group->permissions->each(function($permission) use (&$permissions) {
                 $permissions[$permission->model][$permission->id] = $permission->name;
             });
         }
@@ -51,7 +51,7 @@ 
         $user        = $user ?: $this->find(\Auth::id(), ['groups.permissions']);
         $permissions = [];
 
-        $user->groups->pluck('permissions')->each(function ($permission) use (&$permissions, $model) {
+        $user->groups->pluck('permissions')->each(function($permission) use (&$permissions, $model) {
             $permissions = array_merge($permissions, $permission->where('model', $model)->pluck('name')->toArray());
         });
         
@@ -80,7 +80,7 @@ 
      */
     public function assignGroups($userId, $groupIds)
     {
-        \DB::transaction(function () use ($userId, $groupIds) {
+        \DB::transaction(function() use ($userId, $groupIds) {
             $user = $this->find($userId);
             $user->groups()->detach();
             $user->groups()->attach($groupIds);
@@ -99,15 +99,15 @@ 
      */
     public function login($credentials, $adminLogin = false)
     {
-        if (! $user = $this->first(['email' => $credentials['email']])) {
+        if ( ! $user = $this->first(['email' => $credentials['email']])) {
             \ErrorHandler::loginFailed();
         } elseif ($adminLogin && ! $user->groups->whereIn('name', ['Admin'])->count()) {
             \ErrorHandler::loginFailed();
-        } elseif (! $adminLogin && $user->groups->whereIn('name', ['Admin'])->count()) {
+        } elseif ( ! $adminLogin && $user->groups->whereIn('name', ['Admin'])->count()) {
             \ErrorHandler::loginFailed();
         } elseif ($user->blocked) {
             \ErrorHandler::userIsBlocked();
-        } elseif (! config('skeleton.disable_confirm_email') && ! $user->confirmed) {
+        } elseif ( ! config('skeleton.disable_confirm_email') && ! $user->confirmed) {
             \ErrorHandler::emailNotConfirmed();
         }
 
@@ -127,7 +127,7 @@ 
         $access_token = $authCode ? Arr::get(\Socialite::driver($type)->getAccessTokenResponse($authCode), 'access_token') : $accessToken;
         $user         = \Socialite::driver($type)->userFromToken($access_token);
 
-        if (! $user->email) {
+        if ( ! $user->email) {
             \ErrorHandler::noSocialEmail();
         }
 
@@ -153,7 +153,7 @@ 
         if ($skipConfirmEmail) {
             $user->confirmed = 1;
             $user->save();
-        } elseif (! config('skeleton.disable_confirm_email')) {
+        } elseif ( ! config('skeleton.disable_confirm_email')) {
             $this->sendConfirmationEmail($user->email);
         }
 
@@ -168,10 +168,10 @@ 
      */
     public function block($userId)
     {
-        if (! $user = $this->find($userId)) {
+        if ( ! $user = $this->find($userId)) {
             \ErrorHandler::notFound('user');
         }
-        if (! $this->hasGroup(['Admin'])) {
+        if ( ! $this->hasGroup(['Admin'])) {
             \ErrorHandler::noPermissions();
         } elseif (\Auth::id() == $userId) {
             \ErrorHandler::noPermissions();
@@ -193,7 +193,7 @@ 
      */
     public function unblock($userId)
     {
-        if (! $this->hasGroup(['Admin'])) {
+        if ( ! $this->hasGroup(['Admin'])) {
             \ErrorHandler::noPermissions();
         }
 
@@ -212,7 +212,7 @@ 
      */
     public function sendReset($email)
     {
-        if (! $user = $this->model->where('email', $email)->first()) {
+        if ( ! $user = $this->model->where('email', $email)->first()) {
             \ErrorHandler::notFound('email');
         }
 
@@ -228,7 +228,7 @@ 
      */
     public function resetPassword($credentials)
     {
-        $response = \Password::reset($credentials, function ($user, $password) {
+        $response = \Password::reset($credentials, function($user, $password) {
             $user->password = $password;
             $user->save();
         });
@@ -263,7 +263,7 @@ 
     public function changePassword($credentials)
     {
         $user = \Auth::user();
-        if (! \Hash::check($credentials['old_password'], $user->password)) {
+        if ( ! \Hash::check($credentials['old_password'], $user->password)) {
             \ErrorHandler::invalidOldPassword();
         }
 
@@ -279,7 +279,7 @@ 
      */
     public function confirmEmail($confirmationCode)
     {
-        if (! $user = $this->first(['confirmation_code' => $confirmationCode])) {
+        if ( ! $user = $this->first(['confirmation_code' => $confirmationCode])) {
             \ErrorHandler::invalidConfirmationCode();
         }
 
@@ -324,7 +324,7 @@ 
         $sort       = $desc ? 'desc' : 'asc';
         $model      = call_user_func_array("{$this->getModel()}::with", array($relations));
 
-        $model->whereHas('groups', function ($q) use ($groupName) {
+        $model->whereHas('groups', function($q) use ($groupName) {
             $q->where('name', $groupName);
         });
 

src/Modules/Core/Http/Controllers/BaseApiController.php

Doc Comments +7 added lines, -7 removed lines

@@ -34,7 +34,7 @@ 
      * Init new object.
      *
      * @param   mixed      $repo
-     * @param   CoreConfig $config
+     * @param   \App\Modules\Core\Utl\CoreConfig $config
      * @param   string     $modelResource
      * @return  void
      */
@@ -59,7 +59,7 @@ 
      * Fetch all records with relations from storage.
      *
      * @param  string  $sortBy The name of the column to sort by.
-     * @param  boolean $desc   Sort ascending or descinding (1: desc, 0: asc).
+     * @param  integer $desc   Sort ascending or descinding (1: desc, 0: asc).
      * @return \Illuminate\Http\Response
      */
     public function index($sortBy = 'created_at', $desc = 1)
@@ -85,7 +85,7 @@ 
      * @param  string  $query   The search text.
      * @param  integer $perPage Number of rows per page default 15.
      * @param  string  $sortBy  The name of the column to sort by.
-     * @param  boolean $desc    Sort ascending or descinding (1: desc, 0: asc).
+     * @param  integer $desc    Sort ascending or descinding (1: desc, 0: asc).
      * @return \Illuminate\Http\Response
      */
     public function search($query = '', $perPage = 15, $sortBy = 'created_at', $desc = 1)
@@ -99,7 +99,7 @@ 
      *
      * @param  \Illuminate\Http\Request  $request
      * @param  string  $sortBy The name of the column to sort by.
-     * @param  boolean $desc   Sort ascending or descinding (1: desc, 0: asc).
+     * @param  integer $desc   Sort ascending or descinding (1: desc, 0: asc).
      * @return \Illuminate\Http\Response
      */
     public function findby(Request $request, $sortBy = 'created_at', $desc = 1)
@@ -124,7 +124,7 @@ 
      *
      * @param  integer $perPage Number of rows per page default 15.
      * @param  string  $sortBy  The name of the column to sort by.
-     * @param  boolean $desc    Sort ascending or descinding (1: desc, 0: asc).
+     * @param  integer $desc    Sort ascending or descinding (1: desc, 0: asc).
      * @return \Illuminate\Http\Response
      */
     public function paginate($perPage = 15, $sortBy = 'created_at', $desc = 1)
@@ -139,7 +139,7 @@ 
      * @param  \Illuminate\Http\Request  $request
      * @param  integer $perPage Number of rows per page default 15.
      * @param  string  $sortBy  The name of the column to sort by.
-     * @param  boolean $desc    Sort ascending or descinding (1: desc, 0: asc).
+     * @param  integer $desc    Sort ascending or descinding (1: desc, 0: asc).
      * @return \Illuminate\Http\Response
      */
     public function paginateby(Request $request, $perPage = 15, $sortBy = 'created_at', $desc = 1)
@@ -189,7 +189,7 @@ 
      * @param  \Illuminate\Http\Request  $request
      * @param  integer $perPage Number of rows per page default 15.
      * @param  string  $sortBy  The name of the column to sort by.
-     * @param  boolean $desc    Sort ascending or descinding (1: desc, 0: asc).
+     * @param  integer $desc    Sort ascending or descinding (1: desc, 0: asc).
      * @return \Illuminate\Http\Response
      */
     public function deleted(Request $request, $perPage = 15, $sortBy = 'created_at', $desc = 1)

Spacing +3 added lines, -3 removed lines

@@ -219,7 +219,7 @@ 
         \Auth::shouldUse('api');
         $this->middleware('auth:api', ['except' => $this->skipLoginCheck]);
         
-        if (! in_array($permission, $this->skipLoginCheck) && $user = \Auth::user()) {
+        if ( ! in_array($permission, $this->skipLoginCheck) && $user = \Auth::user()) {
             $user             = \Auth::user();
             $permission       = $permission !== 'index' ? $permission : 'list';
             $isPasswordClient = $user->token()->client->password_client;
@@ -230,7 +230,7 @@ 
             }
 
             if ($isPasswordClient && (in_array($permission, $this->skipPermissionCheck) || \Core::users()->can($permission, $this->modelName))) {
-            } elseif (! $isPasswordClient && $user->tokenCan($this->modelName.'-'.$permission)) {
+            } elseif ( ! $isPasswordClient && $user->tokenCan($this->modelName.'-'.$permission)) {
             } else {
                 \ErrorHandler::noPermissions();
             }
@@ -301,7 +301,7 @@ 
 
         if ($timezone && $timezone !== $user->timezone) {
             $user->timezone = $timezone;
-            $update       = true;
+            $update = true;
         }
 
         if ($update) {

src/Modules/Reporting/Http/Controllers/ReportsController.php

Doc Comments +1 added lines, -1 removed lines

@@ -34,7 +34,7 @@
      * @param  \Illuminate\Http\Request  $request
      * @param  string  $reportName Name of the requested report
      * @param  integer $perPage    Number of rows per page default all data.
-     * @return \Illuminate\Http\Response
+     * @return \Illuminate\Http\JsonResponse
      */
     public function getReport(Request $request, $reportName, $perPage = 0)
     {

files/Handler.php

Spacing +1 added lines, -1 removed lines

@@ -63,7 +63,7 @@
                 return \Response::json(['errors' => [$errors]], $exception->getStatusCode());
             } elseif ($exception instanceof \Illuminate\Validation\ValidationException) {
                 return \Response::json(['errors' => $exception->errors()], 422);
-            } elseif (! $exception instanceof \Symfony\Component\ErrorHandler\Error\FatalError) {
+            } elseif ( ! $exception instanceof \Symfony\Component\ErrorHandler\Error\FatalError) {
                 return parent::render($request, $exception);
             }
         }

src/Modules/Notifications/Routes/api.php

Spacing +3 added lines, -3 removed lines

@@ -11,9 +11,9 @@ 
 |
 */
 
-Route::group(['prefix' => 'notifications'], function () {
+Route::group(['prefix' => 'notifications'], function() {
 
-    Route::group(['prefix' => 'notifications'], function () {
+    Route::group(['prefix' => 'notifications'], function() {
         
         Route::get('list/{perPage?}', 'NotificationsController@list');
         Route::get('unread/{perPage?}', 'NotificationsController@unread');
@@ -21,7 +21,7 @@ 
         Route::get('markAllAsRead', 'NotificationsController@markAllAsRead');
     });
 
-    Route::group(['prefix' => 'push_notification_devices'], function () {
+    Route::group(['prefix' => 'push_notification_devices'], function() {
         
         Route::get('list/{sortBy?}/{desc?}', 'PushNotificationDevicesController@index');
         Route::get('find/{id}', 'PushNotificationDevicesController@find');

src/Modules/Notifications/Database/Migrations/2016_01_24_111942_push_notification_devices.php

Spacing +1 added lines, -1 removed lines

@@ -12,7 +12,7 @@
      */
     public function up()
     {
-        Schema::create('push_notification_devices', function (Blueprint $table) {
+        Schema::create('push_notification_devices', function(Blueprint $table) {
             $table->increments('id');
             $table->string('device_token');
             $table->integer('user_id');