Completed
Push — master ( b79faa...aa40d3 )
by Sherif
14:14
created
src/Modules/V1/Core/Http/Controllers/BaseApiController.php 1 patch
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -170,8 +170,7 @@
 block discarded – undo
170 170
             if ($request->has('id')) 
171 171
             {
172 172
                 $rule = str_replace('{id}', $request->get('id'), $rule);
173
-            }
174
-            else
173
+            } else
175 174
             {
176 175
                 $rule = str_replace(',{id}', '', $rule);
177 176
             }
Please login to merge, or discard this patch.
src/Modules/V1/Core/AbstractRepositories/AbstractRepository.php 1 patch
Braces   +4 added lines, -8 removed lines patch added patch discarded remove patch
@@ -430,8 +430,7 @@  discard block
 block discarded – undo
430 430
             $model = $this->model->lockForUpdate()->find($value);
431 431
             $model ? $model->update($data) : 0;
432 432
             $saveLog ? $this->logs->saveLog('update', class_basename($this->model), $this->getModel(), $value, $model) : false;
433
-        }
434
-        else
433
+        } else
435 434
         {
436 435
             call_user_func_array("{$this->getModel()}::where", array($attribute, '=', $value))->lockForUpdate()->get()->each(function ($model) use ($data, $saveLog){
437 436
                 $model->update($data);
@@ -462,8 +461,7 @@  discard block
 block discarded – undo
462 461
                 $model->delete();
463 462
                 $saveLog ? \Logging::saveLog('delete', class_basename($this->model), $this->getModel(), $value, $model) : false;
464 463
             });
465
-        }
466
-        else
464
+        } else
467 465
         {
468 466
             \DB::transaction(function () use ($value, $attribute, &$result, $saveLog) {
469 467
                 call_user_func_array("{$this->getModel()}::where", array($attribute, '=', $value))->lockForUpdate()->get()->each(function ($model){
@@ -536,13 +534,11 @@  discard block
 block discarded – undo
536 534
             {
537 535
                 $conditionString  .= str_replace('{op}', 'and', $this->constructConditions($value)['conditionString']) . ' {op} ';
538 536
                 $conditionValues   = array_merge($conditionValues, $this->constructConditions($value)['conditionValues']);
539
-            }
540
-            else if ($key == 'or')
537
+            } else if ($key == 'or')
541 538
             {
542 539
                 $conditionString  .= str_replace('{op}', 'or', $this->constructConditions($value)['conditionString']) . ' {op} ';
543 540
                 $conditionValues   = array_merge($conditionValues, $this->constructConditions($value)['conditionValues']);
544
-            }
545
-            else
541
+            } else
546 542
             {
547 543
                 $conditionString  .= $key . '=? {op} ';
548 544
                 $conditionValues[] = $value;
Please login to merge, or discard this patch.
src/Modules/V1/Acl/Repositories/UserRepository.php 1 patch
Braces   +8 added lines, -16 removed lines patch added patch discarded remove patch
@@ -76,24 +76,19 @@  discard block
 block discarded – undo
76 76
         if ( ! $user = $this->first(['email' => $credentials['email']])) 
77 77
         {
78 78
             \ErrorHandler::loginFailed();
79
-        }
80
-        else if ($adminLogin && $user->groups->lists('name')->search('Admin', true) === false) 
79
+        } else if ($adminLogin && $user->groups->lists('name')->search('Admin', true) === false) 
81 80
         {
82 81
             \ErrorHandler::loginFailed();
83
-        }
84
-        else if ( ! $adminLogin && $user->groups->lists('name')->search('Admin', true) !== false) 
82
+        } else if ( ! $adminLogin && $user->groups->lists('name')->search('Admin', true) !== false) 
85 83
         {
86 84
             \ErrorHandler::loginFailed();
87
-        }
88
-        else if ($user->blocked)
85
+        } else if ($user->blocked)
89 86
         {
90 87
             \ErrorHandler::userIsBlocked();
91
-        }
92
-        else if ($token = \JWTAuth::attempt($credentials))
88
+        } else if ($token = \JWTAuth::attempt($credentials))
93 89
         {
94 90
             return ['token' => $token];
95
-        }
96
-        else
91
+        } else
97 92
         {
98 93
             \ErrorHandler::loginFailed();
99 94
         }
@@ -118,8 +113,7 @@  discard block
 block discarded – undo
118 113
         {
119 114
             $data = ['email' => $user->email, 'password' => ''];
120 115
             return $this->register($data);
121
-        }
122
-        else
116
+        } else
123 117
         {
124 118
             return $this->login(['email' => $registeredUser->email, 'password' => ''], false);
125 119
         }
@@ -161,12 +155,10 @@  discard block
 block discarded – undo
161 155
         if ( ! $this->hasGroup('Admin'))
162 156
         {
163 157
             \ErrorHandler::noPermissions();
164
-        }
165
-        else if (\JWTAuth::parseToken()->authenticate()->id == $user_id)
158
+        } else if (\JWTAuth::parseToken()->authenticate()->id == $user_id)
166 159
         {
167 160
             \ErrorHandler::noPermissions();
168
-        }
169
-        else if ($user->groups->lists('name')->search('Admin', true) !== false) 
161
+        } else if ($user->groups->lists('name')->search('Admin', true) !== false) 
170 162
         {
171 163
             \ErrorHandler::noPermissions();
172 164
         }
Please login to merge, or discard this patch.