Completed
Push — master ( 1e8b34...bf4aa0 )
by Sherif
02:38
created
src/Modules/V1/Core/Http/Controllers/BaseApiController.php 1 patch
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -170,8 +170,7 @@
 block discarded – undo
170 170
             if ($request->has('id')) 
171 171
             {
172 172
                 $rule = str_replace('{id}', $request->get('id'), $rule);
173
-            }
174
-            else
173
+            } else
175 174
             {
176 175
                 $rule = str_replace(',{id}', '', $rule);
177 176
             }
Please login to merge, or discard this patch.
src/Modules/V1/Reporting/Repositories/ReportRepository.php 1 patch
Braces   +2 added lines, -4 removed lines patch added patch discarded remove patch
@@ -38,8 +38,7 @@  discard block
 block discarded – undo
38 38
         if ( ! $report) 
39 39
         {
40 40
             \ErrorHandler::notFound('report');
41
-        }
42
-        else if ( ! \Core::users()->can($report->view_name, 'reports'))
41
+        } else if ( ! \Core::users()->can($report->view_name, 'reports'))
43 42
         {
44 43
             \ErrorHandler::noPermissions();
45 44
         }
@@ -60,8 +59,7 @@  discard block
 block discarded – undo
60 59
         if ($perPage) 
61 60
         {
62 61
             return $report->paginate($perPage);
63
-        }
64
-        else
62
+        } else
65 63
         {
66 64
             return $report->get();  
67 65
         }
Please login to merge, or discard this patch.
src/Modules/V1/Acl/Repositories/UserRepository.php 1 patch
Braces   +8 added lines, -16 removed lines patch added patch discarded remove patch
@@ -103,24 +103,19 @@  discard block
 block discarded – undo
103 103
         if ( ! $user = $this->first(['email' => $credentials['email']])) 
104 104
         {
105 105
             \ErrorHandler::loginFailed();
106
-        }
107
-        else if ($adminLogin && $user->groups->pluck('name')->search('Admin', true) === false) 
106
+        } else if ($adminLogin && $user->groups->pluck('name')->search('Admin', true) === false) 
108 107
         {
109 108
             \ErrorHandler::loginFailed();
110
-        }
111
-        else if ( ! $adminLogin && $user->groups->pluck('name')->search('Admin', true) !== false) 
109
+        } else if ( ! $adminLogin && $user->groups->pluck('name')->search('Admin', true) !== false) 
112 110
         {
113 111
             \ErrorHandler::loginFailed();
114
-        }
115
-        else if ($user->blocked)
112
+        } else if ($user->blocked)
116 113
         {
117 114
             \ErrorHandler::userIsBlocked();
118
-        }
119
-        else if ($token = \JWTAuth::attempt($credentials))
115
+        } else if ($token = \JWTAuth::attempt($credentials))
120 116
         {
121 117
             return ['token' => $token];
122
-        }
123
-        else
118
+        } else
124 119
         {
125 120
             \ErrorHandler::loginFailed();
126 121
         }
@@ -146,8 +141,7 @@  discard block
 block discarded – undo
146 141
         {
147 142
             $data = ['email' => $user->email, 'password' => ''];
148 143
             return $this->register($data);
149
-        }
150
-        else
144
+        } else
151 145
         {
152 146
             if ( ! \Auth::attempt(['email' => $registeredUser->email, 'password' => '']))
153 147
             {
@@ -193,12 +187,10 @@  discard block
 block discarded – undo
193 187
         if ( ! $this->hasGroup('Admin'))
194 188
         {
195 189
             \ErrorHandler::noPermissions();
196
-        }
197
-        else if (\JWTAuth::parseToken()->authenticate()->id == $user_id)
190
+        } else if (\JWTAuth::parseToken()->authenticate()->id == $user_id)
198 191
         {
199 192
             \ErrorHandler::noPermissions();
200
-        }
201
-        else if ($user->groups->pluck('name')->search('Admin', true) !== false) 
193
+        } else if ($user->groups->pluck('name')->search('Admin', true) !== false) 
202 194
         {
203 195
             \ErrorHandler::noPermissions();
204 196
         }
Please login to merge, or discard this patch.
src/Modules/V1/Acl/Http/Controllers/UsersController.php 1 patch
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -170,8 +170,7 @@
 block discarded – undo
170 170
             if ($request->has('id')) 
171 171
             {
172 172
                 $rule = str_replace('{id}', $request->get('id'), $rule);
173
-            }
174
-            else
173
+            } else
175 174
             {
176 175
                 $rule = str_replace(',{id}', '', $rule);
177 176
             }
Please login to merge, or discard this patch.
src/Modules/V1/Core/AbstractRepositories/AbstractRepository.php 1 patch
Braces   +11 added lines, -22 removed lines patch added patch discarded remove patch
@@ -430,8 +430,7 @@  discard block
 block discarded – undo
430 430
             $model = $this->model->lockForUpdate()->find($value);
431 431
             $model ? $model->update($data) : 0;
432 432
             $saveLog ? \Logging::saveLog('update', class_basename($this->model), $this->getModel(), $value, $model) : false;
433
-        }
434
-        else
433
+        } else
435 434
         {
436 435
             call_user_func_array("{$this->getModel()}::where", array($attribute, '=', $value))->lockForUpdate()->get()->each(function ($model) use ($data, $saveLog){
437 436
                 $model->update($data);
@@ -462,8 +461,7 @@  discard block
 block discarded – undo
462 461
                 $model->delete();
463 462
                 $saveLog ? \Logging::saveLog('delete', class_basename($this->model), $this->getModel(), $value, $model) : false;
464 463
             });
465
-        }
466
-        else
464
+        } else
467 465
         {
468 466
             \DB::transaction(function () use ($value, $attribute, &$result, $saveLog) {
469 467
                 call_user_func_array("{$this->getModel()}::where", array($attribute, '=', $value))->lockForUpdate()->get()->each(function ($model) use ($saveLog){
@@ -580,14 +578,12 @@  discard block
 block discarded – undo
580 578
                 $conditions       = $this->constructConditions($value, $model);
581 579
                 $conditionString .= str_replace('{op}', 'and', $conditions['conditionString']) . ' {op} ';
582 580
                 $conditionValues  = array_merge($conditionValues, $conditions['conditionValues']);
583
-            }
584
-            else if ($key == 'or')
581
+            } else if ($key == 'or')
585 582
             {
586 583
                 $conditions       = $this->constructConditions($value, $model);
587 584
                 $conditionString .= str_replace('{op}', 'or', $conditions['conditionString']) . ' {op} ';
588 585
                 $conditionValues  = array_merge($conditionValues, $conditions['conditionValues']);
589
-            }
590
-            else
586
+            } else
591 587
             {
592 588
                 if (is_array($value)) 
593 589
                 {
@@ -596,13 +592,11 @@  discard block
 block discarded – undo
596 592
                     {
597 593
                         $value1 = $value['val1'];
598 594
                         $value2 = $value['val2'];
599
-                    }
600
-                    else
595
+                    } else
601 596
                     {
602 597
                         $value = array_key_exists('val', $value) ? $value['val'] : '';
603 598
                     }
604
-                }
605
-                else
599
+                } else
606 600
                 {
607 601
                     $operator = '=';
608 602
                 }
@@ -614,29 +608,24 @@  discard block
 block discarded – undo
614 608
 
615 609
                     $conditionString  .= $key . ' <= ? {op} ';
616 610
                     $conditionValues[] = $value2;
617
-                }
618
-                elseif (strtolower($operator) == 'in') 
611
+                } elseif (strtolower($operator) == 'in') 
619 612
                 {
620 613
                     $conditionValues  = array_merge($conditionValues, $value);
621 614
                     $inBindingsString = rtrim(str_repeat('?,', count($value)), ',');
622 615
                     $conditionString .= $key . ' in (' . rtrim($inBindingsString, ',') . ') {op} ';
623
-                }
624
-                elseif (strtolower($operator) == 'null') 
616
+                } elseif (strtolower($operator) == 'null') 
625 617
                 {
626 618
                     $conditionString .= $key . ' is null {op} ';
627
-                }
628
-                elseif (strtolower($operator) == 'not null') 
619
+                } elseif (strtolower($operator) == 'not null') 
629 620
                 {
630 621
                     $conditionString .= $key . ' is not null {op} ';
631
-                }
632
-                elseif (strtolower($operator) == 'has') 
622
+                } elseif (strtolower($operator) == 'has') 
633 623
                 {
634 624
                     $sql              = $model->withTrashed()->has($key)->toSql();
635 625
                     $conditions       = $this->constructConditions($value, $model->first()->$key);
636 626
                     $conditionString .= rtrim(substr($sql, strpos($sql, 'exists')), ')') . ' and ' . $conditions['conditionString'] . ')';
637 627
                     $conditionValues  = array_merge($conditionValues, $conditions['conditionValues']);
638
-                }
639
-                else
628
+                } else
640 629
                 {
641 630
                     $conditionString  .= $key . ' ' . $operator . ' ? {op} ';
642 631
                     $conditionValues[] = $value;
Please login to merge, or discard this patch.