ResetPassword::toMail() - Code Metrics - Inspection of "Changes" - SherifElfadaly/Laravel-Api-Skeleton - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( f8ccd7...a2ea8b )

by Sherif

created 2018-03-28 19:32 UTC

ResetPassword::toMail() A

↳ Parent: ResetPassword

Complexity

Conditions	1
Paths	1

Size

Total Lines	8
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	8
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	6
nc	1
nop	1

<?php

namespace App\Modules\V1\Notifications\Notifications;

use Illuminate\Bus\Queueable;
use Illuminate\Notifications\Notification;
use Illuminate\Contracts\Queue\ShouldQueue;
use Illuminate\Notifications\Messages\MailMessage;
use Illuminate\Notifications\Messages\BroadcastMessage;

class ResetPassword extends Notification implements ShouldQueue
{
    use Queueable;

    protected $token;

    /**
     * Create a new notification instance.
     *
     * @return void

     */
    public function __construct($token)
    {
        $this->$token = $token;
    }

    /**
     * Get the notification's delivery channels.
     *
     * @param  mixed  $notifiable
     * @return array
     */
    public function via($notifiable)

    {
        return ['mail'];
    }

    /**
     * Get the mail representation of the notification.
     *
     * @param  mixed  $notifiable
     * @return \Illuminate\Notifications\Messages\MailMessage
     */
    public function toMail($notifiable)

    {
        return (new MailMessage)
            ->subject('Reset passowrd')
            ->line('Reset passowrd')
            ->line('To reset your password click on the button below')
            ->action('Reset password', env('RESET_PASSWORD_URL') . '/' . $this->token);
    }
}

1			<?php
2
3			namespace App\Modules\V1\Notifications\Notifications;
4
5			use Illuminate\Bus\Queueable;
6			use Illuminate\Notifications\Notification;
7			use Illuminate\Contracts\Queue\ShouldQueue;
8			use Illuminate\Notifications\Messages\MailMessage;
9			use Illuminate\Notifications\Messages\BroadcastMessage;
10
11			class ResetPassword extends Notification implements ShouldQueue
12			{
13			use Queueable;
14
15			protected $token;
16
17			/**
18			* Create a new notification instance.
19			*
20			* @return void
			0 ignored issues – show Comprehensibility Best Practice introduced 2018-03-28 19:43 UTC by Report Bug Copy Issue Report Adding a `@return` annotation to constructors is generally not recommended as a constructor does not have a meaningful return value. Adding a `@return` annotation to a constructor is not recommended, since a constructor does not have a meaningful return value. Please refer to the PHP core documentation on constructors. Loading history...
21			*/
22			public function __construct($token)
23			{
24			$this->$token = $token;
25			}
26
27			/**
28			* Get the notification's delivery channels.
29			*
30			* @param mixed $notifiable
31			* @return array
32			*/
33			public function via($notifiable)
			0 ignored issues – show Unused Code introduced 2018-03-28 19:43 UTC by Report Bug Copy Issue Report The parameter `$notifiable` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
34			{
35			return ['mail'];
36			}
37
38			/**
39			* Get the mail representation of the notification.
40			*
41			* @param mixed $notifiable
42			* @return \Illuminate\Notifications\Messages\MailMessage
43			*/
44			public function toMail($notifiable)
			0 ignored issues – show Unused Code introduced 2018-03-28 19:43 UTC by Report Bug Copy Issue Report The parameter `$notifiable` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
45			{
46			return (new MailMessage)
47			->subject('Reset passowrd')
48			->line('Reset passowrd')
49			->line('To reset your password click on the button below')
50			->action('Reset password', env('RESET_PASSWORD_URL') . '/' . $this->token);
51			}
52			}

SherifElfadaly / Laravel-Api-Skeleton

Push — master ( f8ccd7...a2ea8b )

ResetPassword::toMail() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like