ReportRepository - Code Metrics - Inspection of "Api versioning" - SherifElfadaly/Laravel-Api-Skeleton - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c7d5ad...0208a8 )

by Sherif

created 2016-03-30 18:29 UTC

ReportRepository A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	66
Duplicated Lines	30.3 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	8
c	1
b	0
f	0
lcom	1
cbo	2
dl	20
loc	66
rs	10

3 Methods

Rating	Name	Duplication	Size	Complexity
A	getModel()	0	5	2
A	find()	10	17	3
A	first()	10	17	3

How to fix Duplicated Code

<?php namespace App\Modules\Reporting\Repositories\V1;

use App\Modules\Core\AbstractRepositories\AbstractRepository;

class ReportRepository extends AbstractRepository
{
	/**
	 * Return the model full namespace.
	 * 
	 * @return string
	 */
	protected function getModel()
	{
        $apiVersion = \Request::header('api-version') ?: 1;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
		return 'App\Modules\Reporting\Report';
	}

	/**
     * Render the given report db view.
     * 
     * @param  integer $id
     * @param  array   $relations
     * @param  array   $columns
     * @return object
     */
    public function find($id, $relations = [], $columns = array('*'))
    {
		$report = call_user_func_array("{$this->getModel()}::with", array($relations))->find($id, $columns);

        if ( ! \Core::users()->can($report->view_name, 'reports'))

        {
            $error = $this->errorHandler->noPermissions();
            abort($error['status'], $error['message']);
        }

		if ( ! $report) 

		{
			$error = $this->errorHandler->notFound('report');
			abort($error['status'], $error['message']);
		}
        return \DB::table($report->view_name)->get();
    }

    /**
     * Render the given report db view based on the given
     * condition.
     *
     * @param  array   $conditions array of conditions
     * @param  array   $relations
     * @param  array   $colunmns
/**
 * @param array $germany
 * @param array $ireland
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return object
     */
    public function first($conditions, $relations = [], $columns = array('*'))
    {
		$conditions = $this->constructConditions($conditions);
		$report     = call_user_func_array("{$this->getModel()}::with", array($relations))->whereRaw($conditions['conditionString'], $conditions['conditionValues'])->first($columns);
        
        if ( ! \Core::users()->can($report->view_name, 'reports'))

        {
            $error = $this->errorHandler->noPermissions();
            abort($error['status'], $error['message']);
        }
		if ( ! $report) 

		{
			$error = $this->errorHandler->notFound('report');
			abort($error['status'], $error['message']);
		}
        return \DB::table($report->view_name)->get();  
    }
}


1		<?php namespace App\Modules\Reporting\Repositories\V1;
2
3		use App\Modules\Core\AbstractRepositories\AbstractRepository;
4
5		class ReportRepository extends AbstractRepository
6		{
7		/**
8		* Return the model full namespace.
9		*
10		* @return string
11		*/
12		protected function getModel()
13		{
14		$apiVersion = \Request::header('api-version') ?: 1;
		0 ignored issues – show Unused Code introduced 2016-03-30 18:32 UTC by Report Bug Copy Issue Report `$apiVersion` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
15		return 'App\Modules\Reporting\Report';
16		}
17
18		/**
19		* Render the given report db view.
20		*
21		* @param integer $id
22		* @param array $relations
23		* @param array $columns
24		* @return object
25		*/
26		public function find($id, $relations = [], $columns = array('*'))
27		{
28		$report = call_user_func_array("{$this->getModel()}::with", array($relations))->find($id, $columns);
29
30	View Code Duplication	if ( ! \Core::users()->can($report->view_name, 'reports'))
		0 ignored issues – show Duplication introduced 2016-03-30 18:32 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
31		{
32		$error = $this->errorHandler->noPermissions();
33		abort($error['status'], $error['message']);
34		}
35
36	View Code Duplication	if ( ! $report)
		0 ignored issues – show Duplication introduced 2016-03-30 18:32 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
37		{
38		$error = $this->errorHandler->notFound('report');
39		abort($error['status'], $error['message']);
40		}
41		return \DB::table($report->view_name)->get();
42		}
43
44		/**
45		* Render the given report db view based on the given
46		* condition.
47		*
48		* @param array $conditions array of conditions
49		* @param array $relations
50		* @param array $colunmns
		0 ignored issues – show Documentation introduced 2016-03-30 14:44 UTC by Report Bug Copy Issue Report There is no parameter named `$colunmns`. Did you maybe mean `$columns`? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. It has, however, found a similar but not annotated parameter which might be a good fit. Consider the following example. The parameter `$ireland` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $ireland */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was changed, but the annotation was not. Loading history...
51		* @return object
52		*/
53		public function first($conditions, $relations = [], $columns = array('*'))
54		{
55		$conditions = $this->constructConditions($conditions);
56		$report = call_user_func_array("{$this->getModel()}::with", array($relations))->whereRaw($conditions['conditionString'], $conditions['conditionValues'])->first($columns);
57
58	View Code Duplication	if ( ! \Core::users()->can($report->view_name, 'reports'))
		0 ignored issues – show Duplication introduced 2016-03-30 18:32 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
59		{
60		$error = $this->errorHandler->noPermissions();
61		abort($error['status'], $error['message']);
62		}
63	View Code Duplication	if ( ! $report)
		0 ignored issues – show Duplication introduced 2016-03-30 18:32 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
64		{
65		$error = $this->errorHandler->notFound('report');
66		abort($error['status'], $error['message']);
67		}
68		return \DB::table($report->view_name)->get();
69		}
70		}
71

SherifElfadaly / Laravel-Api-Skeleton

Push — master ( c7d5ad...0208a8 )

ReportRepository A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like