RoleService::assignPermissions() - Code Metrics - Inspection of "Service layer" - SherifElfadaly/Laravel-Api-Skeleton - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( cf2713...aee5ae )

by Sherif

created 2020-03-30 10:11 UTC

RoleService::assignPermissions() A

↳ Parent: RoleService

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	11
Ratio	100 %

Importance

Changes

Metric	Value
dl	11
loc	11
rs	9.9
c	0
b	0
f	0
cc	1
nc	1
nop	2

<?php namespace App\Modules\Roles\Services;

use App\Modules\Core\BaseClasses\BaseService;
use App\Modules\Roles\Repositories\RoleRepository;

class RoleService extends BaseService
{
    /**
     * Init new object.
     *
     * @param   RoleRepository $repo
     * @return  void

     */
    public function __construct(RoleRepository $repo)
    {
        parent::__construct($repo);
    }

    /**
     * Assign the given permission ids to the given role.
     *
     * @param  integer $roleId
     * @param  array   $permissionIds
     * @return object
     */
    public function assignPermissions($roleId, $permissionIds)

    {
        $role = false;
        \DB::transaction(function () use ($roleId, $permissionIds, &$role) {
            $role = $this->repo->find($roleId);
            $this->repo->detachPermissions($roleId);
            $this->repo->attachPermissions($roleId, $permissionIds);
        });

        return $role;
    }
}


1		<?php namespace App\Modules\Roles\Services;
2
3		use App\Modules\Core\BaseClasses\BaseService;
4		use App\Modules\Roles\Repositories\RoleRepository;
5
6		class RoleService extends BaseService
7		{
8		/**
9		* Init new object.
10		*
11		* @param RoleRepository $repo
12		* @return void
		0 ignored issues – show Comprehensibility Best Practice introduced 2020-03-05 13:37 UTC by Report Bug Copy Issue Report Adding a `@return` annotation to constructors is generally not recommended as a constructor does not have a meaningful return value. Adding a `@return` annotation to a constructor is not recommended, since a constructor does not have a meaningful return value. Please refer to the PHP core documentation on constructors. Loading history...
13		*/
14		public function __construct(RoleRepository $repo)
15		{
16		parent::__construct($repo);
17		}
18
19		/**
20		* Assign the given permission ids to the given role.
21		*
22		* @param integer $roleId
23		* @param array $permissionIds
24		* @return object
25		*/
26	View Code Duplication	public function assignPermissions($roleId, $permissionIds)
		0 ignored issues – show Duplication introduced 2018-07-15 12:48 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
27		{
28		$role = false;
29		\DB::transaction(function () use ($roleId, $permissionIds, &$role) {
30		$role = $this->repo->find($roleId);
31		$this->repo->detachPermissions($roleId);
32		$this->repo->attachPermissions($roleId, $permissionIds);
33		});
34
35		return $role;
36		}
37		}
38

SherifElfadaly / Laravel-Api-Skeleton

Push — master ( cf2713...aee5ae )

RoleService::assignPermissions() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like