ReportService::getReport() - Code Metrics - Inspection of "Service layer" - SherifElfadaly/Laravel-Api-Skeleton - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( cf2713...aee5ae )

by Sherif

created 2020-03-30 10:11 UTC

ReportService::getReport() A

↳ Parent: ReportService

Complexity

Conditions	4
Paths	3

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	18
rs	9.6666
c	0
b	0
f	0
cc	4
nc	3
nop	4

<?php namespace App\Modules\Reporting\Services;

use App\Modules\Core\BaseClasses\BaseService;
use App\Modules\Reporting\Repositories\ReportRepository;
use App\Modules\Users\Services\UserService;

class ReportService extends BaseService
{
    /**
     * @var UserService
     */
    protected $userService;

    /**
     * Init new object.
     *
     * @param   ReportRepository $repo
     * @return  void

     */
    public function __construct(ReportRepository $repo, UserService $userService)
    {
        $this->userService = $userService;
        parent::__construct($repo);
    }

    /**
     * Render the given report db view based on the given
     * condition.
     *
     * @param  string  $reportName
     * @param  array   $conditions
     * @param  integer $perPage
     * @param  boolean $skipPermission
     * @return object
     */
    public function getReport($reportName, $conditions = [], $perPage = 0, $skipPermission = false)
    {
        /**
         * Fetch the report from db.
         */
        $report = $this->repo->first(['report_name' => $reportName]);

        /**
         * Check report existance and permission.
         */
        if (! $report) {
            \ErrorHandler::notFound('report');
        } elseif (! $skipPermission && ! $this->userService->can($report->view_name, 'report')) {
            \ErrorHandler::noPermissions();
        }

       return $this->repo->renderReport($report, $conditions, $perPage);
    }
}


1			<?php namespace App\Modules\Reporting\Services;
2
3			use App\Modules\Core\BaseClasses\BaseService;
4			use App\Modules\Reporting\Repositories\ReportRepository;
5			use App\Modules\Users\Services\UserService;
6
7			class ReportService extends BaseService
8			{
9			/**
10			* @var UserService
11			*/
12			protected $userService;
13
14			/**
15			* Init new object.
16			*
17			* @param ReportRepository $repo
18			* @return void
			0 ignored issues – show Comprehensibility Best Practice introduced 2020-03-05 13:37 UTC by Report Bug Copy Issue Report Adding a `@return` annotation to constructors is generally not recommended as a constructor does not have a meaningful return value. Adding a `@return` annotation to a constructor is not recommended, since a constructor does not have a meaningful return value. Please refer to the PHP core documentation on constructors. Loading history...
19			*/
20			public function __construct(ReportRepository $repo, UserService $userService)
21			{
22			$this->userService = $userService;
23			parent::__construct($repo);
24			}
25
26			/**
27			* Render the given report db view based on the given
28			* condition.
29			*
30			* @param string $reportName
31			* @param array $conditions
32			* @param integer $perPage
33			* @param boolean $skipPermission
34			* @return object
35			*/
36			public function getReport($reportName, $conditions = [], $perPage = 0, $skipPermission = false)
37			{
38			/**
39			* Fetch the report from db.
40			*/
41			$report = $this->repo->first(['report_name' => $reportName]);
42
43			/**
44			* Check report existance and permission.
45			*/
46			if (! $report) {
47			\ErrorHandler::notFound('report');
48			} elseif (! $skipPermission && ! $this->userService->can($report->view_name, 'report')) {
49			\ErrorHandler::noPermissions();
50			}
51
52			return $this->repo->renderReport($report, $conditions, $perPage);
53			}
54			}
55

SherifElfadaly / Laravel-Api-Skeleton

Push — master ( cf2713...aee5ae )

ReportService::getReport() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like