Completed
Push — master ( 03841e...c8ea4b )
by Sherif
05:27
created

UsersController   A

Complexity

Total Complexity 10

Size/Duplication

Total Lines 103
Duplicated Lines 8.74 %

Coupling/Cohesion

Components 1
Dependencies 3

Importance

Changes 2
Bugs 0 Features 0
Metric Value
wmc 10
c 2
b 0
f 0
lcom 1
cbo 3
dl 9
loc 103
rs 10

5 Methods

Rating   Name   Duplication   Size   Complexity  
A getAccount() 0 5 3
A getLogout() 0 4 1
A postRegister() 0 6 1
A postLogin() 0 13 4
A postAssigngroups() 9 9 1

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1
<?php
2
namespace App\Modules\Acl\Http\Controllers;
3
4
use Illuminate\Foundation\Http\FormRequest;
5
use App\Modules\Core\Http\Controllers\BaseApiController;
6
use Illuminate\Http\Request;
7
8
class UsersController extends BaseApiController
9
{
10
    /**
11
     * The name of the model that is used by the base api controller 
12
     * to preform actions like (add, edit ... etc).
13
     * @var string
14
     */
15
    protected $model               = 'users';
16
17
    /**
18
     * List of all route actions that the base api controller
19
     * will skip permissions check for them.
20
     * @var array
21
     */
22
    protected $skipPermissionCheck = ['account', 'logout'];
23
24
    /**
25
     * List of all route actions that the base api controller
26
     * will skip login check for them.
27
     * @var array
28
     */
29
    protected $skipLoginCheck = ['login', 'register'];
30
31
    /**
32
     * The validations rules used by the base api controller
33
     * to check before add.
34
     * @var array
35
     */
36
    protected $validationRules  = [
37
    'email'    => 'required|email|unique:users,email,{id}',
38
    'password' => 'min:6'
39
    ];
40
41
    /**
42
     * Return the logged in user account.
43
     * 
44
     * @return object
45
     */
46
    public function getAccount()
47
    {
48
       $relations = $this->relations && $this->relations['find'] ? $this->relations['find'] : [];
49
       return \Response::json(call_user_func_array("\Core::{$this->model}", [])->find(\Auth::id(), $relations), 200);
50
    }
51
52
    /**
53
     * Logout the user.
54
     * 
55
     * @return void
56
     */
57
    public function getLogout()
58
    {
59
        return \Response::json(\Auth::logout(), 200);
60
    }
61
62
    /**
63
     * Handle a registration request.
64
     *
65
     * @param  \Illuminate\Http\Request  $request
66
     * @return \Illuminate\Http\Response
67
     */
68
    public function postRegister(Request $request)
69
    {
70
        $this->validate($request, ['email' => 'required|email|unique:users,email,{id}','password' => 'required|min:6']);
71
72
        return \Response::json(\Auth::loginUsingId(\Core::users()->create($request->all())->id), 200);
73
    }
74
75
    /**
76
     * Handle a login request to the application.
77
     *
78
     * @param  \Illuminate\Http\Request  $request
79
     * @return \Illuminate\Http\Response
80
     */
81
    public function postLogin(Request $request)
82
    {
83
        if (\Auth::attempt($request->all())) 
84
        {
85
            $relations = $this->relations && $this->relations['find'] ? $this->relations['find'] : [];
86
            return \Response::json(call_user_func_array("\Core::{$this->model}", [])->find(\Auth::id(), $relations), 200);
87
        }
88
        else
89
        {
90
            $error = $this->errorHandler->loginFailed();
91
            abort($error['status'], $error['message']);
92
        }
93
    }
94
95
    /**
96
     * Handle an assign groups to user request.
97
     *
98
     * @param  \Illuminate\Http\Request  $request
99
     * @return \Illuminate\Http\Response
100
     */
101 View Code Duplication
    public function postAssigngroups(Request $request)
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
102
    {
103
        $this->validate($request, [
104
            'group_ids' => 'required|exists:groups,id', 
105
            'user_id'   => 'required|exists:users,id'
106
            ]);
107
108
        return \Response::json(\Core::users()->assignGroups($request->get('user_id'), $request->get('group_ids')), 200);
109
    }
110
}
111