Inspection of "docker & errors changes" - SherifElfadaly/Laravel-Api-Skeleton - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 0d52ea...f30158 )

by Sherif

created 2020-04-05 00:41 UTC

Status

Indentation +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -2,8 +2,8 @@
 block discarded – undo
 
 return [
     
-    /**
-     * Here goes your error messages.
-     */
+	/**
+	 * Here goes your error messages.
+	 */
 
 ];

Please login to merge, or discard this patch.

src/Modules/Reporting/Services/ReportService.php 1 patch

Indentation +41 added lines, -41 removed lines patch added patch discarded remove patch

@@ -8,49 +8,49 @@
 block discarded – undo
 
 class ReportService extends BaseService
 {
-    /**
-     * @var UserService
-     */
-    protected $userService;
+	/**
+	 * @var UserService
+	 */
+	protected $userService;
 
-    /**
-     * Init new object.
-     *
-     * @param   ReportRepository $repo
-     * @return  void
-     */
-    public function __construct(ReportRepository $repo, UserService $userService)
-    {
-        $this->userService = $userService;
-        parent::__construct($repo);
-    }
+	/**
+	 * Init new object.
+	 *
+	 * @param   ReportRepository $repo
+	 * @return  void
+	 */
+	public function __construct(ReportRepository $repo, UserService $userService)
+	{
+		$this->userService = $userService;
+		parent::__construct($repo);
+	}
 
-    /**
-     * Render the given report db view based on the given
-     * condition.
-     *
-     * @param  string  $reportName
-     * @param  array   $conditions
-     * @param  integer $perPage
-     * @param  boolean $skipPermission
-     * @return object
-     */
-    public function getReport($reportName, $conditions = [], $perPage = 0, $skipPermission = false)
-    {
-        /**
-         * Fetch the report from db.
-         */
-        $report = $this->repo->first(['report_name' => $reportName]);
+	/**
+	 * Render the given report db view based on the given
+	 * condition.
+	 *
+	 * @param  string  $reportName
+	 * @param  array   $conditions
+	 * @param  integer $perPage
+	 * @param  boolean $skipPermission
+	 * @return object
+	 */
+	public function getReport($reportName, $conditions = [], $perPage = 0, $skipPermission = false)
+	{
+		/**
+		 * Fetch the report from db.
+		 */
+		$report = $this->repo->first(['report_name' => $reportName]);
 
-        /**
-         * Check report existance and permission.
-         */
-        if (! $report) {
-            \Errors::notFound('report');
-        } elseif (! $skipPermission && ! $this->userService->can($report->view_name, 'report')) {
-            \Errors::noPermissions();
-        }
+		/**
+		 * Check report existance and permission.
+		 */
+		if (! $report) {
+			\Errors::notFound('report');
+		} elseif (! $skipPermission && ! $this->userService->can($report->view_name, 'report')) {
+			\Errors::noPermissions();
+		}
 
-        return $this->repo->renderReport($report, $conditions, $perPage);
-    }
+		return $this->repo->renderReport($report, $conditions, $perPage);
+	}
 }

Please login to merge, or discard this patch.

src/ApiSkeletonServiceProvider.php 1 patch

Indentation +39 added lines, -39 removed lines patch added patch discarded remove patch

@@ -6,45 +6,45 @@
 block discarded – undo
 
 class ApiSkeletonServiceProvider extends ServiceProvider
 {
-    /**
-     * Perform post-registration booting of services.
-     *
-     * @return void
-     */
-    public function boot()
-    {
-        $this->publishes([
-            __DIR__.'/Modules'                               => app_path('Modules'),
-            __DIR__.'/Modules/Core/Resources/Assets'         => base_path('public/doc/assets'),
-            __DIR__.'/../lang'                               => base_path('resources/lang'),
-            __DIR__.'/../files/Handler.php'                  => app_path('Exceptions/Handler.php'),
-            __DIR__.'/../files/AuthServiceProvider.php'      => app_path('Providers/AuthServiceProvider.php'),
-            __DIR__.'/../files/BroadcastServiceProvider.php' => app_path('Providers/BroadcastServiceProvider.php'),
-            __DIR__.'/../files/Kernel.php'                   => app_path('Console/Kernel.php'),
-            __DIR__.'/../files/HttpKernel.php'               => app_path('Http/Kernel.php'),
-            __DIR__.'/../files/channels.php'                 => base_path('routes/channels.php'),
-            __DIR__.'/../phpcs.xml'                          => base_path('/phpcs.xml'),
-            __DIR__.'/../docker'                             => base_path('/docker'),
-            __DIR__.'/../docker-compose.yml'                 => base_path('/docker-compose.yml'),
-            __DIR__.'/../.dockerignore'                      => base_path('/.dockerignore'),
-        ]);
+	/**
+	 * Perform post-registration booting of services.
+	 *
+	 * @return void
+	 */
+	public function boot()
+	{
+		$this->publishes([
+			__DIR__.'/Modules'                               => app_path('Modules'),
+			__DIR__.'/Modules/Core/Resources/Assets'         => base_path('public/doc/assets'),
+			__DIR__.'/../lang'                               => base_path('resources/lang'),
+			__DIR__.'/../files/Handler.php'                  => app_path('Exceptions/Handler.php'),
+			__DIR__.'/../files/AuthServiceProvider.php'      => app_path('Providers/AuthServiceProvider.php'),
+			__DIR__.'/../files/BroadcastServiceProvider.php' => app_path('Providers/BroadcastServiceProvider.php'),
+			__DIR__.'/../files/Kernel.php'                   => app_path('Console/Kernel.php'),
+			__DIR__.'/../files/HttpKernel.php'               => app_path('Http/Kernel.php'),
+			__DIR__.'/../files/channels.php'                 => base_path('routes/channels.php'),
+			__DIR__.'/../phpcs.xml'                          => base_path('/phpcs.xml'),
+			__DIR__.'/../docker'                             => base_path('/docker'),
+			__DIR__.'/../docker-compose.yml'                 => base_path('/docker-compose.yml'),
+			__DIR__.'/../.dockerignore'                      => base_path('/.dockerignore'),
+		]);
 
-        $this->publishes([
-            __DIR__.'/../config/skeleton.php' => config_path('skeleton.php'),
-            __DIR__.'/../files/auth.php'      => config_path('auth.php'),
-        ], 'config');
-    }
+		$this->publishes([
+			__DIR__.'/../config/skeleton.php' => config_path('skeleton.php'),
+			__DIR__.'/../files/auth.php'      => config_path('auth.php'),
+		], 'config');
+	}
 
-    /**
-     * Register any package services.
-     *
-     * @return void
-     */
-    public function register()
-    {
-        $this->mergeConfigFrom(
-            __DIR__.'/../config/skeleton.php',
-            'skeleton'
-        );
-    }
+	/**
+	 * Register any package services.
+	 *
+	 * @return void
+	 */
+	public function register()
+	{
+		$this->mergeConfigFrom(
+			__DIR__.'/../config/skeleton.php',
+			'skeleton'
+		);
+	}
 }

Please login to merge, or discard this patch.

		@@ -2,8 +2,8 @@
		block discarded – undo
2	2
3	3	return [
4	4
5		- /**
6		- * Here goes your error messages.
7		- */
	5	+ /**
	6	+ * Here goes your error messages.
	7	+ */
8	8
9	9	];

		@@ -8,49 +8,49 @@
		block discarded – undo
8	8
9	9	class ReportService extends BaseService
10	10	{
11		- /**
12		- * @var UserService
13		- */
14		- protected $userService;
	11	+ /**
	12	+ * @var UserService
	13	+ */
	14	+ protected $userService;
15	15
16		- /**
17		- * Init new object.
18		- *
19		- * @param ReportRepository $repo
20		- * @return void
21		- */
22		- public function __construct(ReportRepository $repo, UserService $userService)
23		- {
24		- $this->userService = $userService;
25		- parent::__construct($repo);
26		- }
	16	+ /**
	17	+ * Init new object.
	18	+ *
	19	+ * @param ReportRepository $repo
	20	+ * @return void
	21	+ */
	22	+ public function __construct(ReportRepository $repo, UserService $userService)
	23	+ {
	24	+ $this->userService = $userService;
	25	+ parent::__construct($repo);
	26	+ }
27	27
28		- /**
29		- * Render the given report db view based on the given
30		- * condition.
31		- *
32		- * @param string $reportName
33		- * @param array $conditions
34		- * @param integer $perPage
35		- * @param boolean $skipPermission
36		- * @return object
37		- */
38		- public function getReport($reportName, $conditions = [], $perPage = 0, $skipPermission = false)
39		- {
40		- /**
41		- * Fetch the report from db.
42		- */
43		- $report = $this->repo->first(['report_name' => $reportName]);
	28	+ /**
	29	+ * Render the given report db view based on the given
	30	+ * condition.
	31	+ *
	32	+ * @param string $reportName
	33	+ * @param array $conditions
	34	+ * @param integer $perPage
	35	+ * @param boolean $skipPermission
	36	+ * @return object
	37	+ */
	38	+ public function getReport($reportName, $conditions = [], $perPage = 0, $skipPermission = false)
	39	+ {
	40	+ /**
	41	+ * Fetch the report from db.
	42	+ */
	43	+ $report = $this->repo->first(['report_name' => $reportName]);
44	44
45		- /**
46		- * Check report existance and permission.
47		- */
48		- if (! $report) {
49		- \Errors::notFound('report');
50		- } elseif (! $skipPermission && ! $this->userService->can($report->view_name, 'report')) {
51		- \Errors::noPermissions();
52		- }
	45	+ /**
	46	+ * Check report existance and permission.
	47	+ */
	48	+ if (! $report) {
	49	+ \Errors::notFound('report');
	50	+ } elseif (! $skipPermission && ! $this->userService->can($report->view_name, 'report')) {
	51	+ \Errors::noPermissions();
	52	+ }
53	53
54		- return $this->repo->renderReport($report, $conditions, $perPage);
55		- }
	54	+ return $this->repo->renderReport($report, $conditions, $perPage);
	55	+ }
56	56	}

		@@ -6,45 +6,45 @@
		block discarded – undo
6	6
7	7	class ApiSkeletonServiceProvider extends ServiceProvider
8	8	{
9		- /**
10		- * Perform post-registration booting of services.
11		- *
12		- * @return void
13		- */
14		- public function boot()
15		- {
16		- $this->publishes([
17		- __DIR__.'/Modules' => app_path('Modules'),
18		- __DIR__.'/Modules/Core/Resources/Assets' => base_path('public/doc/assets'),
19		- __DIR__.'/../lang' => base_path('resources/lang'),
20		- __DIR__.'/../files/Handler.php' => app_path('Exceptions/Handler.php'),
21		- __DIR__.'/../files/AuthServiceProvider.php' => app_path('Providers/AuthServiceProvider.php'),
22		- __DIR__.'/../files/BroadcastServiceProvider.php' => app_path('Providers/BroadcastServiceProvider.php'),
23		- __DIR__.'/../files/Kernel.php' => app_path('Console/Kernel.php'),
24		- __DIR__.'/../files/HttpKernel.php' => app_path('Http/Kernel.php'),
25		- __DIR__.'/../files/channels.php' => base_path('routes/channels.php'),
26		- __DIR__.'/../phpcs.xml' => base_path('/phpcs.xml'),
27		- __DIR__.'/../docker' => base_path('/docker'),
28		- __DIR__.'/../docker-compose.yml' => base_path('/docker-compose.yml'),
29		- __DIR__.'/../.dockerignore' => base_path('/.dockerignore'),
30		- ]);
	9	+ /**
	10	+ * Perform post-registration booting of services.
	11	+ *
	12	+ * @return void
	13	+ */
	14	+ public function boot()
	15	+ {
	16	+ $this->publishes([
	17	+ __DIR__.'/Modules' => app_path('Modules'),
	18	+ __DIR__.'/Modules/Core/Resources/Assets' => base_path('public/doc/assets'),
	19	+ __DIR__.'/../lang' => base_path('resources/lang'),
	20	+ __DIR__.'/../files/Handler.php' => app_path('Exceptions/Handler.php'),
	21	+ __DIR__.'/../files/AuthServiceProvider.php' => app_path('Providers/AuthServiceProvider.php'),
	22	+ __DIR__.'/../files/BroadcastServiceProvider.php' => app_path('Providers/BroadcastServiceProvider.php'),
	23	+ __DIR__.'/../files/Kernel.php' => app_path('Console/Kernel.php'),
	24	+ __DIR__.'/../files/HttpKernel.php' => app_path('Http/Kernel.php'),
	25	+ __DIR__.'/../files/channels.php' => base_path('routes/channels.php'),
	26	+ __DIR__.'/../phpcs.xml' => base_path('/phpcs.xml'),
	27	+ __DIR__.'/../docker' => base_path('/docker'),
	28	+ __DIR__.'/../docker-compose.yml' => base_path('/docker-compose.yml'),
	29	+ __DIR__.'/../.dockerignore' => base_path('/.dockerignore'),
	30	+ ]);
31	31
32		- $this->publishes([
33		- __DIR__.'/../config/skeleton.php' => config_path('skeleton.php'),
34		- __DIR__.'/../files/auth.php' => config_path('auth.php'),
35		- ], 'config');
36		- }
	32	+ $this->publishes([
	33	+ __DIR__.'/../config/skeleton.php' => config_path('skeleton.php'),
	34	+ __DIR__.'/../files/auth.php' => config_path('auth.php'),
	35	+ ], 'config');
	36	+ }
37	37
38		- /**
39		- * Register any package services.
40		- *
41		- * @return void
42		- */
43		- public function register()
44		- {
45		- $this->mergeConfigFrom(
46		- __DIR__.'/../config/skeleton.php',
47		- 'skeleton'
48		- );
49		- }
	38	+ /**
	39	+ * Register any package services.
	40	+ *
	41	+ * @return void
	42	+ */
	43	+ public function register()
	44	+ {
	45	+ $this->mergeConfigFrom(
	46	+ __DIR__.'/../config/skeleton.php',
	47	+ 'skeleton'
	48	+ );
	49	+ }
50	50	}

SherifElfadaly / Laravel-Api-Skeleton

Push — master ( 0d52ea...f30158 )

Status

Category

Indentation +3 added lines, -3 removed lines patch added patch discarded remove patch

Indentation +41 added lines, -41 removed lines patch added patch discarded remove patch

Indentation +39 added lines, -39 removed lines patch added patch discarded remove patch