UsersController::sendreset() - Code Metrics - Inspection of "Remove implicit controllers" - SherifElfadaly/Laravel-Api-Skeleton - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 09a99f...0f3793 )

by Sherif

created 2016-04-06 22:14 UTC

UsersController::sendreset() A

↳ Parent: UsersController

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Metric	Value
dl	0
loc	6
rs	9.4285
cc	1
eloc	3
nc	1
nop	1

<?php
namespace App\Modules\V1\Acl\Http\Controllers;

use Illuminate\Foundation\Http\FormRequest;
use App\Modules\V1\Core\Http\Controllers\BaseApiController;
use Illuminate\Http\Request;

class UsersController extends BaseApiController
{
    /**
     * The name of the model that is used by the base api controller 
     * to preform actions like (add, edit ... etc).
     * @var string
     */
    protected $model               = 'users';

    /**
     * List of all route actions that the base api controller
     * will skip permissions check for them.
     * @var array
     */
    protected $skipPermissionCheck = ['account', 'logout', 'block', 'unblock', 'editprofile', 'sendreset'];

    /**
     * List of all route actions that the base api controller
     * will skip login check for them.
     * @var array
     */
    protected $skipLoginCheck      = ['login', 'register', 'sendreset', 'resetpassword'];

    /**
     * The validations rules used by the base api controller
     * to check before add.
     * @var array
     */
    protected $validationRules     = [
    'email'    => 'required|email|unique:users,email,{id}',
    'password' => 'min:6'
    ];

    /**
     * Return the logged in user account.
     * 
     * @return \Illuminate\Http\Response
     */
    public function account()
    {
       $relations = $this->relations && $this->relations['find'] ? $this->relations['find'] : [];
       return \Response::json(call_user_func_array("\Core::{$this->model}", [])->find(\JWTAuth::parseToken()->authenticate()->id, $relations), 200);
    }

    /**
     * Block the user.
     *
     * @param  integer  $id
     * @return \Illuminate\Http\Response
     */
    public function block($id)
    {
        return \Response::json(\Core::users()->block($id), 200);
    }

    /**
     * Unblock the user.
     *
     * @param  integer  $id
     * @return \Illuminate\Http\Response
     */
    public function unblock($id)
    {
        return \Response::json(\Core::users()->unblock($id), 200);
    }

    /**
     * Logout the user.
     * 
     * @return \Illuminate\Http\Response
     */
    public function logout()
    {
        return \Response::json(\Core::users()->logout(), 200);
    }

    /**
     * Handle a registration request.
     *
     * @param  \Illuminate\Http\Request  $request
     * @return \Illuminate\Http\Response
     */
    public function register(Request $request)

    {
        $this->validate($request, [
            'email'    => 'email|unique:users,email,{id}', 
            'password' => 'min:6'
            ]);

        return \Response::json(\Core::users()->register($request->only('email', 'password')), 200);
    }

    /**
     * Handle a login request of the none admin to the application.
     *
     * @param  \Illuminate\Http\Request  $request
     * @return \Illuminate\Http\Response
     */
    public function login(Request $request)
    {
        $this->validate($request, [
            'email'    => 'required|email', 
            'password' => 'required|min:6',
            'admin'    => 'boolean'
            ]);

        return \Response::json(\Core::users()->login($request->only('email', 'password'), $request->get('admin')), 200);
    }

    /**
     * Handle an assign groups to user request.
     *
     * @param  \Illuminate\Http\Request  $request
     * @return \Illuminate\Http\Response
     */
    public function assigngroups(Request $request)

    {
        $this->validate($request, [
            'group_ids' => 'required|exists:groups,id', 
            'user_id'   => 'required|exists:users,id'
            ]);

        return \Response::json(\Core::users()->assignGroups($request->get('user_id'), $request->get('group_ids')), 200);
    }

    /**
     * Handle the editing of the user profile.
     *
     * @param  \Illuminate\Http\Request  $request
     * @return \Illuminate\Http\Response
     */
    public function editprofile(Request $request)
    {
        return \Response::json(\Core::users()->editProfile($request->all()), 200);
    }

    /**
     * Send a reset link to the given user.
     *
     * @param  \Illuminate\Http\Request  $request
     * @return \Illuminate\Http\Response
     */
    public function sendreset(Request $request)
    {
        $this->validate($request, ['email' => 'required|email', 'url' => 'required|url']);

        return \Response::json(\Core::users()->sendReset($request->only('email'), $request->get('url')), 200);
    }

    /**
     * Reset the given user's password.
     *
     * @param  \Illuminate\Http\Request  $request
     * @return \Illuminate\Http\Response
     */
    public function resetpassword(Request $request)
    {
        $this->validate($request, [
            'token'                 => 'required',
            'email'                 => 'required|email',
            'password'              => 'required|confirmed|min:6',
            'password_confirmation' => 'required',
        ]);

        return \Response::json(\Core::users()->resetPassword($request->only('email', 'password', 'password_confirmation', 'token')), 200);
    }
}


1		<?php
2		namespace App\Modules\V1\Acl\Http\Controllers;
3
4		use Illuminate\Foundation\Http\FormRequest;
5		use App\Modules\V1\Core\Http\Controllers\BaseApiController;
6		use Illuminate\Http\Request;
7
8		class UsersController extends BaseApiController
9		{
10		/**
11		* The name of the model that is used by the base api controller
12		* to preform actions like (add, edit ... etc).
13		* @var string
14		*/
15		protected $model = 'users';
16
17		/**
18		* List of all route actions that the base api controller
19		* will skip permissions check for them.
20		* @var array
21		*/
22		protected $skipPermissionCheck = ['account', 'logout', 'block', 'unblock', 'editprofile', 'sendreset'];
23
24		/**
25		* List of all route actions that the base api controller
26		* will skip login check for them.
27		* @var array
28		*/
29		protected $skipLoginCheck = ['login', 'register', 'sendreset', 'resetpassword'];
30
31		/**
32		* The validations rules used by the base api controller
33		* to check before add.
34		* @var array
35		*/
36		protected $validationRules = [
37		'email' => 'required\|email\|unique:users,email,{id}',
38		'password' => 'min:6'
39		];
40
41		/**
42		* Return the logged in user account.
43		*
44		* @return \Illuminate\Http\Response
45		*/
46		public function account()
47		{
48		$relations = $this->relations && $this->relations['find'] ? $this->relations['find'] : [];
49		return \Response::json(call_user_func_array("\Core::{$this->model}", [])->find(\JWTAuth::parseToken()->authenticate()->id, $relations), 200);
50		}
51
52		/**
53		* Block the user.
54		*
55		* @param integer $id
56		* @return \Illuminate\Http\Response
57		*/
58		public function block($id)
59		{
60		return \Response::json(\Core::users()->block($id), 200);
61		}
62
63		/**
64		* Unblock the user.
65		*
66		* @param integer $id
67		* @return \Illuminate\Http\Response
68		*/
69		public function unblock($id)
70		{
71		return \Response::json(\Core::users()->unblock($id), 200);
72		}
73
74		/**
75		* Logout the user.
76		*
77		* @return \Illuminate\Http\Response
78		*/
79		public function logout()
80		{
81		return \Response::json(\Core::users()->logout(), 200);
82		}
83
84		/**
85		* Handle a registration request.
86		*
87		* @param \Illuminate\Http\Request $request
88		* @return \Illuminate\Http\Response
89		*/
90	View Code Duplication	public function register(Request $request)
		0 ignored issues – show Duplication introduced 2016-04-05 16:10 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
91		{
92		$this->validate($request, [
93		'email' => 'email\|unique:users,email,{id}',
94		'password' => 'min:6'
95		]);
96
97		return \Response::json(\Core::users()->register($request->only('email', 'password')), 200);
98		}
99
100		/**
101		* Handle a login request of the none admin to the application.
102		*
103		* @param \Illuminate\Http\Request $request
104		* @return \Illuminate\Http\Response
105		*/
106		public function login(Request $request)
107		{
108		$this->validate($request, [
109		'email' => 'required\|email',
110		'password' => 'required\|min:6',
111		'admin' => 'boolean'
112		]);
113
114		return \Response::json(\Core::users()->login($request->only('email', 'password'), $request->get('admin')), 200);
115		}
116
117		/**
118		* Handle an assign groups to user request.
119		*
120		* @param \Illuminate\Http\Request $request
121		* @return \Illuminate\Http\Response
122		*/
123	View Code Duplication	public function assigngroups(Request $request)
		0 ignored issues – show Duplication introduced 2016-04-05 16:10 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
124		{
125		$this->validate($request, [
126		'group_ids' => 'required\|exists:groups,id',
127		'user_id' => 'required\|exists:users,id'
128		]);
129
130		return \Response::json(\Core::users()->assignGroups($request->get('user_id'), $request->get('group_ids')), 200);
131		}
132
133		/**
134		* Handle the editing of the user profile.
135		*
136		* @param \Illuminate\Http\Request $request
137		* @return \Illuminate\Http\Response
138		*/
139		public function editprofile(Request $request)
140		{
141		return \Response::json(\Core::users()->editProfile($request->all()), 200);
142		}
143
144		/**
145		* Send a reset link to the given user.
146		*
147		* @param \Illuminate\Http\Request $request
148		* @return \Illuminate\Http\Response
149		*/
150		public function sendreset(Request $request)
151		{
152		$this->validate($request, ['email' => 'required\|email', 'url' => 'required\|url']);
153
154		return \Response::json(\Core::users()->sendReset($request->only('email'), $request->get('url')), 200);
155		}
156
157		/**
158		* Reset the given user's password.
159		*
160		* @param \Illuminate\Http\Request $request
161		* @return \Illuminate\Http\Response
162		*/
163		public function resetpassword(Request $request)
164		{
165		$this->validate($request, [
166		'token' => 'required',
167		'email' => 'required\|email',
168		'password' => 'required\|confirmed\|min:6',
169		'password_confirmation' => 'required',
170		]);
171
172		return \Response::json(\Core::users()->resetPassword($request->only('email', 'password', 'password_confirmation', 'token')), 200);
173		}
174		}
175

SherifElfadaly / Laravel-Api-Skeleton

Push — master ( 09a99f...0f3793 )

UsersController::sendreset() A

Complexity

Size

Duplication

Duplication Side-by-Side

Filter issues like