Completed
Push — master ( 43d6b6...7fd3dc )
by Sherif
12:33
created
src/Modules/V1/Acl/Http/Controllers/UsersController.php 1 patch
Doc Comments   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
56 56
     /**
57 57
      * Return the logged in user account.
58 58
      * 
59
-     * @return \Illuminate\Http\Response
59
+     * @return \Illuminate\Http\JsonResponse
60 60
      */
61 61
     public function account()
62 62
     {
@@ -67,7 +67,7 @@  discard block
 block discarded – undo
67 67
      * Block the user.
68 68
      *
69 69
      * @param  integer  $id Id of the user.
70
-     * @return \Illuminate\Http\Response
70
+     * @return \Illuminate\Http\JsonResponse
71 71
      */
72 72
     public function block($id)
73 73
     {
@@ -78,7 +78,7 @@  discard block
 block discarded – undo
78 78
      * Unblock the user.
79 79
      *
80 80
      * @param  integer  $id Id of the user.
81
-     * @return \Illuminate\Http\Response
81
+     * @return \Illuminate\Http\JsonResponse
82 82
      */
83 83
     public function unblock($id)
84 84
     {
@@ -88,7 +88,7 @@  discard block
 block discarded – undo
88 88
     /**
89 89
      * Logout the user.
90 90
      * 
91
-     * @return \Illuminate\Http\Response
91
+     * @return \Illuminate\Http\JsonResponse
92 92
      */
93 93
     public function logout()
94 94
     {
@@ -99,7 +99,7 @@  discard block
 block discarded – undo
99 99
      * Handle a registration request.
100 100
      *
101 101
      * @param  \Illuminate\Http\Request  $request
102
-     * @return \Illuminate\Http\Response
102
+     * @return \Illuminate\Http\JsonResponse
103 103
      */
104 104
     public function register(Request $request)
105 105
     {
@@ -116,7 +116,7 @@  discard block
 block discarded – undo
116 116
      * Handle a login request to the application.
117 117
      *
118 118
      * @param  \Illuminate\Http\Request  $request
119
-     * @return \Illuminate\Http\Response
119
+     * @return \Illuminate\Http\JsonResponse
120 120
      */
121 121
     public function login(Request $request)
122 122
     {
@@ -133,7 +133,7 @@  discard block
 block discarded – undo
133 133
      * Handle a social login request of the none admin to the application.
134 134
      *
135 135
      * @param  \Illuminate\Http\Request  $request
136
-     * @return \Illuminate\Http\Response
136
+     * @return \Illuminate\Http\JsonResponse
137 137
      */
138 138
     public function loginSocial(Request $request)
139 139
     {
@@ -150,7 +150,7 @@  discard block
 block discarded – undo
150 150
      * Assign the given groups to the given user.
151 151
      *
152 152
      * @param  \Illuminate\Http\Request  $request
153
-     * @return \Illuminate\Http\Response
153
+     * @return \Illuminate\Http\JsonResponse
154 154
      */
155 155
     public function assigngroups(Request $request)
156 156
     {
@@ -166,7 +166,7 @@  discard block
 block discarded – undo
166 166
      * Send a reset link to the given user.
167 167
      *
168 168
      * @param  \Illuminate\Http\Request  $request
169
-     * @return \Illuminate\Http\Response
169
+     * @return \Illuminate\Http\JsonResponse
170 170
      */
171 171
     public function sendreset(Request $request)
172 172
     {
@@ -179,7 +179,7 @@  discard block
 block discarded – undo
179 179
      * Reset the given user's password.
180 180
      *
181 181
      * @param  \Illuminate\Http\Request  $request
182
-     * @return \Illuminate\Http\Response
182
+     * @return \Illuminate\Http\JsonResponse
183 183
      */
184 184
     public function resetpassword(Request $request)
185 185
     {
@@ -197,7 +197,7 @@  discard block
 block discarded – undo
197 197
      * Change the logged in user password.
198 198
      *
199 199
      * @param  \Illuminate\Http\Request  $request
200
-     * @return \Illuminate\Http\Response
200
+     * @return \Illuminate\Http\JsonResponse
201 201
      */
202 202
     public function changePassword(Request $request)
203 203
     {
@@ -214,7 +214,7 @@  discard block
 block discarded – undo
214 214
      * Refresh the expired login token.
215 215
      *
216 216
      * @param  \Illuminate\Http\Request  $request
217
-     * @return \Illuminate\Http\Response
217
+     * @return \Illuminate\Http\JsonResponse
218 218
      */
219 219
     public function refreshtoken(Request $request)
220 220
     {
@@ -232,8 +232,8 @@  discard block
 block discarded – undo
232 232
      * @param  string $groupName The name of the requested group.
233 233
      * @param  integer $perPage  Number of rows per page default 15.
234 234
      * @param  string  $sortBy   The name of the column to sort by.
235
-     * @param  boolean $desc     Sort ascending or descinding (1: desc, 0: asc).
236
-     * @return \Illuminate\Http\Response
235
+     * @param  integer $desc     Sort ascending or descinding (1: desc, 0: asc).
236
+     * @return \Illuminate\Http\JsonResponse
237 237
      */
238 238
     public function group(Request $request, $groupName, $perPage = false, $sortBy = 'created_at', $desc = 1)
239 239
     {
@@ -244,7 +244,7 @@  discard block
 block discarded – undo
244 244
      * Save the given data to the logged in user.
245 245
      *
246 246
      * @param  \Illuminate\Http\Request  $request
247
-     * @return \Illuminate\Http\Response
247
+     * @return \Illuminate\Http\JsonResponse|null
248 248
      */
249 249
     public function saveProfile(Request $request) 
250 250
     {
Please login to merge, or discard this patch.
src/Modules/V1/Acl/AclUser.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -10,7 +10,7 @@  discard block
 block discarded – undo
10 10
     use SoftDeletes, HasApiTokens;
11 11
     protected $table    = 'users';
12 12
     protected $dates    = ['created_at', 'updated_at', 'deleted_at'];
13
-    protected $hidden   = ['password', 'remember_token','deleted_at', 'two_factor_code'];
13
+    protected $hidden   = ['password', 'remember_token', 'deleted_at', 'two_factor_code'];
14 14
     protected $guarded  = ['id'];
15 15
     protected $fillable = ['name', 'email', 'password'];
16 16
     public $searchable  = ['name', 'email'];
@@ -43,7 +43,7 @@  discard block
 block discarded – undo
43 43
 
44 44
     public function groups()
45 45
     {
46
-        return $this->belongsToMany('\App\Modules\V1\Acl\AclGroup','users_groups','user_id','group_id')->whereNull('users_groups.deleted_at')->withTimestamps();
46
+        return $this->belongsToMany('\App\Modules\V1\Acl\AclGroup', 'users_groups', 'user_id', 'group_id')->whereNull('users_groups.deleted_at')->withTimestamps();
47 47
     }
48 48
 
49 49
     /**
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
      */
85 85
     public function receivesBroadcastNotificationsOn()
86 86
     {
87
-        return 'users.' . $this->id;
87
+        return 'users.'.$this->id;
88 88
     }
89 89
     
90 90
     public static function boot()
Please login to merge, or discard this patch.
src/Modules/V1/Acl/Database/Seeds/AssignRelationsSeeder.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -18,7 +18,7 @@
 block discarded – undo
18 18
         /**
19 19
 		 * Assign the permissions to the admin group.
20 20
 		 */
21
-        \DB::table('permissions')->orderBy('created_at', 'asc')->whereIn('model', ['users', 'permissions', 'groups', 'oauthClients'])->each(function ($permission) use ($adminGroupId) {
21
+        \DB::table('permissions')->orderBy('created_at', 'asc')->whereIn('model', ['users', 'permissions', 'groups', 'oauthClients'])->each(function($permission) use ($adminGroupId) {
22 22
         	\DB::table('groups_permissions')->insert(
23 23
 				[
24 24
 				'permission_id' => $permission->id,
Please login to merge, or discard this patch.
src/Modules/V1/Core/Console/Commands/GenerateDoc.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -62,7 +62,7 @@  discard block
 block discarded – undo
62 62
                 $route['response'] = $this->getResponseObject($classProperties['model'], $route['name'], $route['returnDocBlock']);
63 63
 
64 64
                 preg_match('/api\/v1\/([^#]+)\//iU', $route['uri'], $module);
65
-                $docData['modules'][$module[1]][substr($route['prefix'], strlen('/api/v1/' . $module[1] . '/') - 1)][] = $route;
65
+                $docData['modules'][$module[1]][substr($route['prefix'], strlen('/api/v1/'.$module[1].'/') - 1)][] = $route;
66 66
 
67 67
                 $this->getModels($classProperties['model'], $docData);
68 68
             }
@@ -79,7 +79,7 @@  discard block
 block discarded – undo
79 79
      */
80 80
     protected function getRoutes()
81 81
     {
82
-        return collect(\Route::getRoutes())->map(function ($route) {
82
+        return collect(\Route::getRoutes())->map(function($route) {
83 83
             if (strpos($route->uri(), 'api/v') !== false) 
84 84
             {
85 85
                 return [
@@ -111,7 +111,7 @@  discard block
 block discarded – undo
111 111
         ];
112 112
 
113 113
 
114
-        if (! $skipLoginCheck || ! in_array($method, $skipLoginCheck)) 
114
+        if ( ! $skipLoginCheck || ! in_array($method, $skipLoginCheck)) 
115 115
         {
116 116
             $route['headers']['Authrization'] = 'Bearer {token}';
117 117
         }
@@ -165,16 +165,16 @@  discard block
 block discarded – undo
165 165
                 }
166 166
                 else
167 167
                 {
168
-                    $route['body'] = eval('return ' . str_replace(',\'.$request->get(\'id\')', ',{id}\'', $match[1]) . ';');
168
+                    $route['body'] = eval('return '.str_replace(',\'.$request->get(\'id\')', ',{id}\'', $match[1]).';');
169 169
                 }
170 170
 
171 171
                 foreach ($route['body'] as &$rule) 
172 172
                 {
173
-                    if(strpos($rule, 'unique'))
173
+                    if (strpos($rule, 'unique'))
174 174
                     {
175 175
                         $rule = substr($rule, 0, strpos($rule, 'unique') + 6);
176 176
                     }
177
-                    elseif(strpos($rule, 'exists'))
177
+                    elseif (strpos($rule, 'exists'))
178 178
                     {
179 179
                         $rule = substr($rule, 0, strpos($rule, 'exists') - 1);
180 180
                     }
@@ -247,10 +247,10 @@  discard block
 block discarded – undo
247 247
             $model      = factory($modelClass)->make();
248 248
             $modelArr   = $model->toArray();
249 249
 
250
-            if ( $model->trans && ! $model->trans->count()) 
250
+            if ($model->trans && ! $model->trans->count()) 
251 251
             {
252 252
                 $modelArr['trans'] = [
253
-                    'en' => factory($modelClass . 'Translation')->make()->toArray()
253
+                    'en' => factory($modelClass.'Translation')->make()->toArray()
254 254
                 ];
255 255
             }
256 256
 
Please login to merge, or discard this patch.
src/Modules/V1/Core/Http/Controllers/BaseApiController.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -35,7 +35,7 @@  discard block
 block discarded – undo
35 35
         $this->skipPermissionCheck = property_exists($this, 'skipPermissionCheck') ? $this->skipPermissionCheck : [];
36 36
         $this->skipLoginCheck      = property_exists($this, 'skipLoginCheck') ? $this->skipLoginCheck : [];
37 37
         $this->repo                = call_user_func_array("\Core::{$this->model}", []);
38
-        $route                     = explode('@',\Route::currentRouteAction())[1];
38
+        $route                     = explode('@', \Route::currentRouteAction())[1];
39 39
 
40 40
         $this->checkPermission($route);
41 41
         $this->setRelations($route);
@@ -253,7 +253,7 @@  discard block
 block discarded – undo
253 253
 
254 254
             if ($isPasswordClient && (in_array($permission, $this->skipPermissionCheck) || \Core::users()->can($permission, $this->model)))
255 255
             {}
256
-            elseif ( ! $isPasswordClient && $user->tokenCan($this->model . '-' . $permission)) 
256
+            elseif ( ! $isPasswordClient && $user->tokenCan($this->model.'-'.$permission)) 
257 257
             {}
258 258
             else
259 259
             {
Please login to merge, or discard this patch.