Sf4 / Api

src/Routing/ApiLoader.php

<?php
/**
 * Created by PhpStorm.
 * User: siim
 * Date: 3.03.19
 * Time: 20:42
 */

namespace Sf4\Api\Routing;

use Symfony\Component\Config\Loader\Loader;
use Symfony\Component\Routing\RouteCollection;

class ApiLoader extends Loader
{
    public const TYPE = 'sf4_api';

    /** @var bool $isLoaded */
    protected $isLoaded = false;

    /**
     * @param mixed $resource
     * @param null $type

Are you sure the doc-type for parameter $type is correct as it would always require null to be passed?

     * @return RouteCollection|null
     */
    public function load($resource, $type = null): ?RouteCollection
    {
        if (true === $this->isLoaded) {
            return null;
        }

        $routes = new RouteCollection();

        $importedRoutes = $this->import(
            '@Sf4ApiBundle/Resources/config/routing.yaml',
            'yaml'
        );
        $routes->addCollection($importedRoutes);

It seems like $importedRoutes can also be of type null; however, parameter $collection of Symfony\Component\Routing\RouteCollection::addCollection() does only seem to accept Symfony\Component\Routing\RouteCollection, maybe add an additional type check?

        $this->isLoaded = true;

        return $routes;
    }

    /**
     * @param mixed $resource
     * @param null $type

Are you sure the doc-type for parameter $type is correct as it would always require null to be passed?

     * @return bool
     */
    public function supports($resource, $type = null): bool
    {
        return static::TYPE === $type;
    }
}