Sf4 / Api

src/RequestHandler/Traits/CacheAdapterTrait.php

<?php
/**
 * Created by PhpStorm.
 * User: siim
 * Date: 21.02.19
 * Time: 20:22
 */

namespace Sf4\Api\RequestHandler\Traits;

use Sf4\Api\Services\CacheAdapterInterface;

trait CacheAdapterTrait
{

    /** @var CacheAdapterInterface $cacheAdapter */
    protected $cacheAdapter;

    /**
     * @return CacheAdapterInterface
     */
    public function getCacheAdapter(): CacheAdapterInterface
    {
        return $this->cacheAdapter;
    }

    /**
     * @param CacheAdapterInterface $cacheAdapter
     */
    public function setCacheAdapter(CacheAdapterInterface $cacheAdapter): void
    {
        $this->cacheAdapter = $cacheAdapter;
    }

    /**
     * @param string $cacheKey
     * @param \Closure $closure
     * @param array $tags
     * @param null $expiresAfter

Are you sure the doc-type for parameter $expiresAfter is correct as it would always require null to be passed?

     * @return mixed|null
     * @throws \Psr\Cache\CacheException
     * @throws \Psr\Cache\InvalidArgumentException
     */
    public function getCacheDataOrAdd(string $cacheKey, \Closure $closure, array $tags = [], $expiresAfter = null)
    {
        $cacheKey = md5($cacheKey);
        $data = null;
        $cacheItem = $this->getCacheAdapter()->getItem($cacheKey);
        if ($cacheItem && $cacheItem->isHit()) {
            $data = $cacheItem->get();
        } else {
            $data = $closure();
            if ($data && $cacheItem) {
                $cacheItem->set($data);
                if (!empty($tags)) {
                    $cacheItem->tag($tags);
                }
                if ($expiresAfter) {

$expiresAfter is of type null, thus it always evaluated to false.

                    $cacheItem->expiresAfter($expiresAfter);
                }
                $this->getCacheAdapter()->save($cacheItem);
            }
        }

        return $data;
    }

    /**
     * @param string $cacheKey
     * @throws \Psr\Cache\InvalidArgumentException
     */
    public function removeByKey(string $cacheKey): void
    {
        if (empty($cacheKey)) {
            $cacheKey = md5($cacheKey);
            $this->getCacheAdapter()->delete($cacheKey);
        }
    }

    /**
     * @param array $tags
     */
    public function removeByTag(array $tags): void
    {
        $this->getCacheAdapter()->invalidateTags($tags);
    }
}