SitesTrait::addSite() - Code Metrics - Inspection of "Add bundle" - Sf4/Api - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( bea9fb...617266 )

by Siim

created 2019-03-01 07:36 UTC

SitesTrait::addSite() A

↳ Parent: SitesTrait

Complexity

Conditions	6
Paths	4

Size

Total Lines	11
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	6
eloc	7
nc	4
nop	1
dl	0
loc	11
rs	9.2222
c	0
b	0
f	0

<?php
/**
 * Created by PhpStorm.
 * User: siim
 * Date: 18.02.19
 * Time: 9:06
 */

namespace Sf4\Api\RequestHandler\Traits;

use Sf4\Api\DependencyInjection\Configuration;

trait SitesTrait
{
    /** @var array|null $sites */
    protected $sites = [];

    /**
     * @return array|null
     */
    public function getSites(): ?array
    {
        return $this->sites;
    }

    /**
     * @param array|null $sites
     */
    public function setSites(?array $sites): void
    {
        $this->sites = $sites;
    }

    /**
     * @param array|null $sites
     */
    public function addSites(?array $sites)
    {
        if (!$sites) {

            return ;
        }

        foreach ($sites as $site) {
            $this->addSite($site);
        }
    }

    /**
     * @param array $site
     */
    public function addSite(array $site)
    {
        if (isset($site[Configuration::SITES_SITE]) &&
            isset($site[Configuration::SITES_URL]) &&
            isset($site[Configuration::SITES_TOKEN])) {
            foreach ($this->sites as $thisSite) {
                if ($thisSite[Configuration::SITES_SITE] === $site[Configuration::SITES_SITE]) {
                    return ;
                }
            }
            $this->sites[] = $site;
        }
    }
}


1			<?php
2			/**
3			* Created by PhpStorm.
4			* User: siim
5			* Date: 18.02.19
6			* Time: 9:06
7			*/
8
9			namespace Sf4\Api\RequestHandler\Traits;
10
11			use Sf4\Api\DependencyInjection\Configuration;
12
13			trait SitesTrait
14			{
15			/** @var array\|null $sites */
16			protected $sites = [];
17
18			/**
19			* @return array\|null
20			*/
21			public function getSites(): ?array
22			{
23			return $this->sites;
24			}
25
26			/**
27			* @param array\|null $sites
28			*/
29			public function setSites(?array $sites): void
30			{
31			$this->sites = $sites;
32			}
33
34			/**
35			* @param array\|null $sites
36			*/
37			public function addSites(?array $sites)
38			{
39			if (!$sites) {
			0 ignored issues – show Bug Best Practice introduced 2019-03-01 07:47 UTC by Report Bug Copy Issue Report The expression `$sites` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
40			return ;
41			}
42
43			foreach ($sites as $site) {
44			$this->addSite($site);
45			}
46			}
47
48			/**
49			* @param array $site
50			*/
51			public function addSite(array $site)
52			{
53			if (isset($site[Configuration::SITES_SITE]) &&
54			isset($site[Configuration::SITES_URL]) &&
55			isset($site[Configuration::SITES_TOKEN])) {
56			foreach ($this->sites as $thisSite) {
57			if ($thisSite[Configuration::SITES_SITE] === $site[Configuration::SITES_SITE]) {
58			return ;
59			}
60			}
61			$this->sites[] = $site;
62			}
63			}
64			}
65

Sf4 / Api

Push — master ( bea9fb...617266 )

SitesTrait::addSite() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like