Setono\VariableResolver\Variable\Value\Value

Complexity

Total Complexity

5

Size/Duplication

Total Lines	30
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	createFromString()	0	3	1
A	getValue()	0	7	2
A	createFromCallable()	0	3	1
A	__construct()	0	3	1

<?php

declare(strict_types=1);

namespace Setono\VariableResolver\Variable\Value;

final class Value implements ValueInterface
{
    /** @var callable|string */
    private $value;

    /**
     * @param string|callable $value
     */
    private function __construct($value)
    {
        $this->value = $value;
    }

    public static function createFromString(string $value): self
    {
        return new self($value);
    }

    public static function createFromCallable(callable $callable): self
    {
        return new self($callable);
    }

    public function getValue(): string
    {
        if (is_callable($this->value)) {
            $this->value = call_user_func($this->value);
        }

        return $this->value;

The expression return $this->value could return the type callable which is incompatible with the type-hinted return string. Consider adding an additional type-check to rule them out.

    }
}