Setono /
SyliusStockMovementPlugin
| Total Complexity | 3 |
| Total Lines | 23 |
| Duplicated Lines | 0 % |
| Changes | 0 | ||
| 1 | <?php |
||
| 11 | final class StaticExchangeRateCurrencyConverter extends CurrencyConverter |
||
| 12 | { |
||
| 13 | /** @var CurrencyConverterInterface */ |
||
| 14 | private $currencyConverter; |
||
| 15 | |||
| 16 | public function __construct(CurrencyConverterInterface $currencyConverter) |
||
| 19 | } |
||
| 20 | |||
| 21 | public function convert(int $amount, string $sourceCurrency, string $targetCurrency, array $conversionContext = []): Money |
||
| 22 | { |
||
| 23 | // notice that Sylius' currency converter will return the same amount if the source > target currency pair does not exist |
||
| 24 | // i.e. if you input EUR 100 and your target is DKK, but no exchange rate exists between EUR and DKK |
||
| 25 | // Sylius' currency converter will return 100 although the expected result is something like 745 |
||
| 26 | $converted = $this->currencyConverter->convert($amount, $sourceCurrency, $targetCurrency); |
||
| 27 | |||
| 28 | return new Money($converted, new Currency($targetCurrency)); |
||
| 29 | } |
||
| 30 | |||
| 31 | public function supports(int $amount, string $sourceCurrency, string $targetCurrency, array $conversionContext = []): bool |
||
| 34 | } |
||
| 35 | } |
||
| 36 |
Let?s assume that you have a directory layout like this:
. |-- OtherDir | |-- Bar.php | `-- Foo.php `-- SomeDir `-- Foo.phpand let?s assume the following content of
Bar.php:If both files
OtherDir/Foo.phpandSomeDir/Foo.phpare loaded in the same runtime, you will see a PHP error such as the following:PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.phpHowever, as
OtherDir/Foo.phpdoes not necessarily have to be loaded and the error is only triggered if it is loaded beforeOtherDir/Bar.php, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: