Setono\SyliusSchedulerPlugin\Command\ScheduleJobCommand

Complexity

Total Complexity

6

Size/Duplication

Total Lines	71
Duplicated Lines	0 %

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	10	1
A	execute()	0	19	4
A	configure()	0	5	1

<?php

declare(strict_types=1);

namespace Setono\SyliusSchedulerPlugin\Command;

use Setono\SyliusSchedulerPlugin\Doctrine\ORM\JobRepositoryInterface;
use Setono\SyliusSchedulerPlugin\Doctrine\ORM\ScheduleRepositoryInterface;
use Setono\SyliusSchedulerPlugin\Factory\JobFactoryInterface;
use Setono\SyliusSchedulerPlugin\Model\JobInterface;
use Symfony\Bundle\FrameworkBundle\Command\ContainerAwareCommand;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Input\InputOption;
use Symfony\Component\Console\Output\OutputInterface;

class ScheduleJobCommand extends ContainerAwareCommand

The class Symfony\Bundle\FrameworkBundle\Command\ContainerAwareCommand has been deprecated: since Symfony 4.2, use {@see Command} instead.

{
    protected static $defaultName = 'setono:scheduler:schedule';

    /**
     * @var JobFactoryInterface
     */
    private $jobFactory;

    /**
     * @var JobRepositoryInterface
     */
    private $jobRepository;

    /**
     * @var ScheduleRepositoryInterface
     */
    private $scheduleRepository;

    /**
     * @param JobFactoryInterface $jobFactory
     * @param JobRepositoryInterface $jobRepository
     * @param ScheduleRepositoryInterface $scheduleRepository
     */
    public function __construct(
        JobFactoryInterface $jobFactory,
        JobRepositoryInterface $jobRepository,
        ScheduleRepositoryInterface $scheduleRepository
    ) {
        $this->jobFactory = $jobFactory;
        $this->jobRepository = $jobRepository;
        $this->scheduleRepository = $scheduleRepository;

        parent::__construct();
    }

    /**
     * @noinspection ReturnTypeCanBeDeclaredInspection
     */
    protected function configure()
    {
        $this
            ->setDescription('Schedule jobs from the queue.')
            ->addOption('queue', null, InputOption::VALUE_OPTIONAL | InputOption::VALUE_IS_ARRAY, 'Restrict to one or more queues.', [])
        ;
    }

    /**
     * {@inheritdoc}
     *
     * @noinspection ReturnTypeCanBeDeclaredInspection
     */
    protected function execute(InputInterface $input, OutputInterface $output)
    {
        $restrictedQueues = $input->getOption('queue');

        $now = new \DateTime();
        $schedules = $this->scheduleRepository->findByQueues($restrictedQueues);

It seems like $restrictedQueues can also be of type boolean and null and string; however, parameter $restrictedQueues of Setono\SyliusSchedulerPlugin\Doctrine\ORM\ScheduleRepositoryInterface::findByQueues() does only seem to accept array, maybe add an additional type check?

        foreach ($schedules as $schedule) {
            if (!$schedule->isNextJobShouldBeCreated($now)) {
                continue;
            }

            $job = $this->jobFactory->createFromSchedule($schedule);
            $job->setState(JobInterface::STATE_PENDING);
            $this->jobRepository->add($job);

            $output->writeln(sprintf(
                '%s scheduled to run at %s',
                (string) $job,
                null === $job->getExecuteAfter() ? '' : $job->getExecuteAfter()->format('Y-m-d H:i:s')
            ));
        }
    }
}