ShipmentViewFactory::create() - Code Metrics - Inspection of "[WIP] API" - Setono/SyliusLagersystemPlugin - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#1)

by Igor

created 2020-03-04 07:24 UTC

ShipmentViewFactory::create() A

↳ Parent: ShipmentViewFactory

Complexity

Conditions	1
Paths	1

Size

Total Lines	11
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	5
nc	1
nop	2
dl	0
loc	11
rs	10
c	1
b	0
f	0

<?php

declare(strict_types=1);

namespace Setono\SyliusLagersystemPlugin\Factory;

use Setono\SyliusLagersystemPlugin\View\ShipmentView;
use Sylius\Component\Core\Model\OrderInterface;
use Sylius\Component\Core\Model\ShipmentInterface;

class ShipmentViewFactory implements ShipmentViewFactoryInterface
{
    /** @var ShippingMethodViewFactoryInterface */
    protected $shippingMethodViewFactory;

    /** @var string */
    protected $shipmentViewClass;

    public function __construct(
        ShippingMethodViewFactoryInterface $shippingMethodViewFactory,
        string $shipmentViewClass
    ) {
        $this->shippingMethodViewFactory = $shippingMethodViewFactory;
        $this->shipmentViewClass = $shipmentViewClass;
    }

    public function create(ShipmentInterface $shipment, string $locale): ShipmentView
    {
        /** @var OrderInterface $order */
        $order = $shipment->getOrder();


        /** @var ShipmentView $shipmentView */
        $shipmentView = new $this->shipmentViewClass();
        $shipmentView->state = $shipment->getState();
        $shipmentView->method = $this->shippingMethodViewFactory->create($shipment, $locale);

        return $shipmentView;
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Setono\SyliusLagersystemPlugin\Factory;
6
7			use Setono\SyliusLagersystemPlugin\View\ShipmentView;
8			use Sylius\Component\Core\Model\OrderInterface;
9			use Sylius\Component\Core\Model\ShipmentInterface;
10
11			class ShipmentViewFactory implements ShipmentViewFactoryInterface
12			{
13			/** @var ShippingMethodViewFactoryInterface */
14			protected $shippingMethodViewFactory;
15
16			/** @var string */
17			protected $shipmentViewClass;
18
19			public function __construct(
20			ShippingMethodViewFactoryInterface $shippingMethodViewFactory,
21			string $shipmentViewClass
22			) {
23			$this->shippingMethodViewFactory = $shippingMethodViewFactory;
24			$this->shipmentViewClass = $shipmentViewClass;
25			}
26
27			public function create(ShipmentInterface $shipment, string $locale): ShipmentView
28			{
29			/** @var OrderInterface $order */
30			$order = $shipment->getOrder();
			0 ignored issues – show Unused Code introduced 2020-03-02 23:08 UTC by Report Bug Copy Issue Report The assignment to `$order` is dead and can be removed. Loading history...
31
32			/** @var ShipmentView $shipmentView */
33			$shipmentView = new $this->shipmentViewClass();
34			$shipmentView->state = $shipment->getState();
35			$shipmentView->method = $this->shippingMethodViewFactory->create($shipment, $locale);
36
37			return $shipmentView;
38			}
39			}
40

Setono / SyliusLagersystemPlugin

Pull Request — master (#1)

ShipmentViewFactory::create() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like