Setono\SyliusLagersystemPlugin\Factory\Product\ProductVariantViewFactory

Complexity

Total Complexity

6

Size/Duplication

Total Lines	49
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
A	create()	0	33	5

<?php

declare(strict_types=1);

namespace Setono\SyliusLagersystemPlugin\Factory\Product;

use Loevgaard\SyliusBarcodePlugin\Model\BarcodeAwareInterface;
use Loevgaard\SyliusBrandPlugin\Model\BrandAwareInterface;
use Setono\SyliusLagersystemPlugin\Factory\Loevgaard\BrandViewFactoryInterface;
use Setono\SyliusLagersystemPlugin\View\Product\ProductVariantView;
use Sylius\Component\Core\Model\ProductInterface;
use Sylius\Component\Core\Model\ProductVariantInterface;
use Webmozart\Assert\Assert;

class ProductVariantViewFactory implements ProductVariantViewFactoryInterface
{
    /** @var BrandViewFactoryInterface */
    private $brandViewFactory;

    /** @var string */
    private $productVariantViewClass;

    public function __construct(
        BrandViewFactoryInterface $brandViewFactory,
        string $productVariantViewClass
    ) {
        $this->brandViewFactory = $brandViewFactory;
        $this->productVariantViewClass = $productVariantViewClass;
    }

    public function create(ProductVariantInterface $variant, string $localeCode): ProductVariantView
    {
        $translation = $variant->getTranslation($localeCode);

        $weight = $variant->getShippingWeight();
        if (null !== $weight) {
            $weight = (int) ceil(1000 * $variant->getShippingWeight());
        }

        /** @var ProductVariantView $variantView */
        $variantView = new $this->productVariantViewClass();
        $variantView->id = $variant->getId();
        $variantView->code = $variant->getCode();
        $variantView->name = $translation->getName();

The method getName() does not exist on Sylius\Component\Resource\Model\TranslationInterface. It seems like you code against a sub-type of said class. However, the method does not exist in Sylius\Component\Resource\Model\AbstractTranslation or Sylius\Component\Product\Model\ProductOptionValueTranslationInterface or spec\Sylius\Component\Resource\Model\ConcreteTranslation or Sylius\Component\Product\Model\ProductOptionValueTranslation or AppBundle\Entity\BookTranslation or Sylius\Component\Product\Model\ProductOptionValueTranslation. Are you sure you never get one of those?

        $variantView->weight = $weight;
        $variantView->onHand = $variant->getOnHand();

        /** @var ProductInterface|BrandAwareInterface|null $product */
        $product = $variant->getProduct();
        Assert::notNull($product);

        if ($product instanceof BrandAwareInterface) {
            $brand = $product->getBrand();
            if (null !== $brand) {
                $variantView->brand = $this->brandViewFactory->create($brand);
            }
        }

        if ($variant instanceof BarcodeAwareInterface) {
            $variantView->barcode = $variant->getBarcode();
        }

        return $variantView;
    }
}