Setono\SyliusLagersystemPlugin\Factory\Product\ProductVariantViewFactory

Complexity

Total Complexity

2

Size/Duplication

Total Lines	23
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	3	1
A	create()	0	13	1

<?php

declare(strict_types=1);

namespace Setono\SyliusLagersystemPlugin\Factory\Product;

use Setono\SyliusLagersystemPlugin\View\Product\ProductVariantView;
use Sylius\Component\Core\Model\ProductVariantInterface;

final class ProductVariantViewFactory implements ProductVariantViewFactoryInterface
{
    /** @var string */
    private $productVariantViewClass;

    public function __construct(string $productVariantViewClass)
    {
        $this->productVariantViewClass = $productVariantViewClass;
    }

    public function create(ProductVariantInterface $variant, string $localeCode): ProductVariantView
    {
        $translation = $variant->getTranslation($localeCode);

        /** @var ProductVariantView $variantView */
        $variantView = new $this->productVariantViewClass();
        $variantView->id = $variant->getId();
        $variantView->code = $variant->getCode();
        $variantView->name = $translation->getName();

The method getName() does not exist on Sylius\Component\Resource\Model\TranslationInterface. It seems like you code against a sub-type of said class. However, the method does not exist in Sylius\Component\Resource\Model\AbstractTranslation or Sylius\Component\Product\Model\ProductOptionValueTranslationInterface or spec\Sylius\Component\Resource\Model\ConcreteTranslation or Sylius\Component\Product\Model\ProductOptionValueTranslation or AppBundle\Entity\BookTranslation or Sylius\Component\Product\Model\ProductOptionValueTranslation. Are you sure you never get one of those?

        $variantView->weight = (int) ceil(1000 * $variant->getShippingWeight());
        $variantView->onHand = $variant->getOnHand();

        return $variantView;
    }
}