Setono\SyliusLagersystemPlugin\Factory\PaymentMethodViewFactory

Complexity

Total Complexity

2

Size/Duplication

Total Lines	21
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	create()	0	11	1
A	__construct()	0	3	1

<?php

declare(strict_types=1);

namespace Setono\SyliusLagersystemPlugin\Factory;

use Setono\SyliusLagersystemPlugin\View\PaymentMethodView;
use Sylius\Component\Core\Model\PaymentMethodInterface;

final class PaymentMethodViewFactory implements PaymentMethodViewFactoryInterface
{
    /** @var string */
    private $paymentMethodViewClass;

    public function __construct(string $paymentMethodViewClass)
    {
        $this->paymentMethodViewClass = $paymentMethodViewClass;
    }

    public function create(PaymentMethodInterface $paymentMethod, string $locale): PaymentMethodView
    {
        $translation = $paymentMethod->getTranslation($locale);

        /** @var PaymentMethodView $paymentMethodView */
        $paymentMethodView = new $this->paymentMethodViewClass();
        $paymentMethodView->code = $paymentMethod->getCode() ?? '';
        $paymentMethodView->name = $translation->getName() ?? '';

The method getName() does not exist on Sylius\Component\Resource\Model\TranslationInterface. It seems like you code against a sub-type of said class. However, the method does not exist in Sylius\Component\Resource\Model\AbstractTranslation or Sylius\Component\Product\Model\ProductOptionValueTranslationInterface or spec\Sylius\Component\Resource\Model\ConcreteTranslation or Sylius\Component\Product\Model\ProductOptionValueTranslation or AppBundle\Entity\BookTranslation or Sylius\Component\Product\Model\ProductOptionValueTranslation. Are you sure you never get one of those?

        $paymentMethodView->description = $translation->getDescription() ?? '';

The method getDescription() does not exist on Sylius\Component\Resource\Model\TranslationInterface. It seems like you code against a sub-type of Sylius\Component\Resource\Model\TranslationInterface such as Sylius\Component\Product\Model\ProductTranslationInterface or Sylius\Component\Taxonomy\Model\TaxonTranslationInterface or Sylius\Component\Shipping\Model\ShippingMethodTranslationInterface or Sylius\Component\Payment\Model\PaymentMethodTranslationInterface or Sylius\Component\Taxonomy\Model\TaxonTranslation or Sylius\Component\Shipping\Model\ShippingMethodTranslation or Sylius\Component\Payment\Model\PaymentMethodTranslation or Sylius\Component\Product\Model\ProductTranslation.

        return $paymentMethodView;
    }
}