Setono\SyliusLagersystemPlugin\Factory\ShippingMethodViewFactory

Complexity

Total Complexity

2

Size/Duplication

Total Lines	25
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	create()	0	14	1
A	__construct()	0	4	1

<?php

declare(strict_types=1);

namespace Setono\SyliusLagersystemPlugin\Factory;

use Setono\SyliusLagersystemPlugin\View\ShippingMethodView;
use Sylius\Component\Core\Model\ShipmentInterface;
use Webmozart\Assert\Assert;

class ShippingMethodViewFactory implements ShippingMethodViewFactoryInterface
{
    /** @var string */
    protected $shippingMethodViewClass;

    public function __construct(
        string $shippingMethodViewClass
    ) {
        $this->shippingMethodViewClass = $shippingMethodViewClass;
    }

    public function create(ShipmentInterface $shipment, string $locale): ShippingMethodView
    {
        $shippingMethod = $shipment->getMethod();
        Assert::notNull($shippingMethod);

        $translation = $shippingMethod->getTranslation($locale);

        /** @var ShippingMethodView $shippingMethodView */
        $shippingMethodView = new $this->shippingMethodViewClass();
        $shippingMethodView->code = $shippingMethod->getCode();
        $shippingMethodView->name = $translation->getName();

The method getName() does not exist on Sylius\Component\Resource\Model\TranslationInterface. It seems like you code against a sub-type of said class. However, the method does not exist in Sylius\Component\Resource\Model\AbstractTranslation or Sylius\Component\Product\Model\ProductOptionValueTranslationInterface or spec\Sylius\Component\Resource\Model\ConcreteTranslation or Sylius\Component\Product\Model\ProductOptionValueTranslation or AppBundle\Entity\BookTranslation or Sylius\Component\Product\Model\ProductOptionValueTranslation. Are you sure you never get one of those?

        $shippingMethodView->description = $translation->getDescription();

The method getDescription() does not exist on Sylius\Component\Resource\Model\TranslationInterface. It seems like you code against a sub-type of Sylius\Component\Resource\Model\TranslationInterface such as Sylius\Component\Product\Model\ProductTranslationInterface or Sylius\Component\Taxonomy\Model\TaxonTranslationInterface or Sylius\Component\Shipping\Model\ShippingMethodTranslationInterface or Sylius\Component\Payment\Model\PaymentMethodTranslationInterface or Sylius\Component\Taxonomy\Model\TaxonTranslation or Sylius\Component\Shipping\Model\ShippingMethodTranslation or Sylius\Component\Payment\Model\PaymentMethodTranslation or Sylius\Component\Product\Model\ProductTranslation.

        return $shippingMethodView;
    }
}