Setono\SyliusLagersystemPlugin\Factory\Order\ItemViewFactory

Complexity

Total Complexity

3

Size/Duplication

Total Lines	42
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	8	1
A	create()	0	21	2

<?php

declare(strict_types=1);

namespace Setono\SyliusLagersystemPlugin\Factory\Order;

use Setono\SyliusLagersystemPlugin\Factory\Product\ProductVariantViewFactoryInterface;
use Setono\SyliusLagersystemPlugin\View\Order\ItemView;
use Sylius\Component\Core\Model\OrderItemInterface;
use Sylius\Component\Core\Model\OrderItemUnitInterface;

class ItemViewFactory implements ItemViewFactoryInterface
{
    /** @var ProductVariantViewFactoryInterface */
    protected $productVariantViewFactory;

    /** @var ItemUnitViewFactoryInterface */
    protected $itemUnitViewFactory;

    /** @var string */
    protected $itemViewClass;

    public function __construct(
        ProductVariantViewFactoryInterface $productVariantViewFactory,
        ItemUnitViewFactoryInterface $itemUnitViewFactory,
        string $itemViewClass
    ) {
        $this->productVariantViewFactory = $productVariantViewFactory;
        $this->itemUnitViewFactory = $itemUnitViewFactory;
        $this->itemViewClass = $itemViewClass;
    }

    public function create(OrderItemInterface $item, string $localeCode): ItemView
    {
        /** @var ItemView $itemView */
        $itemView = new $this->itemViewClass();
        $itemView->id = $item->getId();
        $itemView->quantity = $item->getQuantity();
        $itemView->total = $item->getTotal();
        $itemView->variant = $this->productVariantViewFactory->create(
            $item->getVariant(),

It seems like $item->getVariant() can also be of type null; however, parameter $variant of Setono\SyliusLagersystemPlugin\Factory\Product\ProductVariantViewFactoryInterface::create() does only seem to accept Sylius\Component\Core\Model\ProductVariantInterface, maybe add an additional type check?

            $localeCode
        );

        /** @var OrderItemUnitInterface $itemUnit */
        foreach ($item->getUnits() as $itemUnit) {
            $itemView->units[] = $this->itemUnitViewFactory->create(
                $itemUnit,
                $localeCode
            );
        }

        return $itemView;
    }
}