Setono / DAOBundle

src/DependencyInjection/SetonoDAOExtension.php

<?php

declare(strict_types=1);

namespace Setono\DAOBundle\DependencyInjection;

use Symfony\Component\Config\FileLocator;
use Symfony\Component\DependencyInjection\ContainerBuilder;
use Symfony\Component\DependencyInjection\Extension\Extension;
use Symfony\Component\DependencyInjection\Loader\XmlFileLoader;

final class SetonoDAOExtension extends Extension
{
    /**
     * {@inheritdoc}
     *
     * @throws \Exception
     */
    public function load(array $config, ContainerBuilder $container): void
    {
        $config = $this->processConfiguration($this->getConfiguration([], $container), $config);

It seems like $this->getConfiguration(array(), $container) can also be of type null; however, parameter $configuration of Symfony\Component\DependencyInjection\Extension\Extension::processConfiguration() does only seem to accept Symfony\Component\Config\Definition\ConfigurationInterface, maybe add an additional type check?

        $loader = new XmlFileLoader($container, new FileLocator(__DIR__.'/../Resources/config'));

        $container->setParameter('setono_dao.customer_id', $config['customer_id']);
        $container->setParameter('setono_dao.password', $config['password']);
        $container->setParameter('setono_dao.base_url', $config['base_url']);

        if (isset($config['http_client'])) {
            $container->setParameter('setono_dao.http_client', $config['http_client']);
        }

        if (isset($config['request_factory'])) {
            $container->setParameter('setono_dao.request_factory', $config['request_factory']);
        }

        if (isset($config['stream_factory'])) {
            $container->setParameter('setono_dao.stream_factory', $config['stream_factory']);
        }

        $loader->load('services.xml');
    }
}