Setono\DAOBundle\DependencyInjection\Compiler\RegisterHttpClientPass::process()

Complexity

Conditions	4
Paths	4

Size

Total Lines	10
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function process(ContainerBuilder $container): void
    {
        if ($container->hasParameter(self::HTTP_CLIENT_PARAMETER)) {
            if (!$container->has($container->getParameter(self::HTTP_CLIENT_PARAMETER))) {

It seems like $container->getParameter(self::HTTP_CLIENT_PARAMETER) can also be of type array; however, parameter $id of Symfony\Component\DependencyInjection\ContainerBuilder::has() does only seem to accept string, maybe add an additional type check?

                throw new ServiceNotFoundException($container->getParameter(self::HTTP_CLIENT_PARAMETER));
            }

            $container->setAlias(self::HTTP_CLIENT_SERVICE_ID, $container->getParameter(self::HTTP_CLIENT_PARAMETER));

It seems like $container->getParameter(self::HTTP_CLIENT_PARAMETER) can also be of type array; however, parameter $id of Symfony\Component\DependencyInjection\ContainerBuilder::setAlias() does only seem to accept Symfony\Component\DependencyInjection\Alias|string, maybe add an additional type check?

        } elseif ($container->has(BuzzClientInterface::class)) {
            $container->setAlias(self::HTTP_CLIENT_SERVICE_ID, BuzzClientInterface::class);
        }