Setono\DAOBundle\DependencyInjection\Compiler\RegisterFactoriesPass

Complexity

Total Complexity

8

Size/Duplication

Total Lines	28
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	process()	0	8	2
A	registerFactory()	0	14	6

<?php

declare(strict_types=1);

namespace Setono\DAOBundle\DependencyInjection\Compiler;

use Nyholm\Psr7\Factory\Psr17Factory;
use Psr\Http\Message\RequestFactoryInterface;
use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface;
use Symfony\Component\DependencyInjection\ContainerBuilder;
use Symfony\Component\DependencyInjection\Exception\ServiceNotFoundException;

final class RegisterFactoriesPass implements CompilerPassInterface
{
    private const PSR17_FACTORY_SERVICE_ID = 'setono_dao.psr17_factory';

    public function process(ContainerBuilder $container): void
    {
        if (class_exists(Psr17Factory::class)) {
            // this service is used later if the Psr17Factory exists. Else it will be automatically removed by Symfony
            $container->register(self::PSR17_FACTORY_SERVICE_ID, Psr17Factory::class);
        }

        $this->registerFactory($container, 'setono_dao.request_factory', 'setono_dao.request_factory', RequestFactoryInterface::class);
    }

    private function registerFactory(ContainerBuilder $container, string $parameter, string $service, string $factoryInterface): void
    {
        if ($container->hasParameter($parameter)) {
            if (!$container->has($container->getParameter($parameter))) {

It seems like $container->getParameter($parameter) can also be of type array; however, parameter $id of Symfony\Component\DependencyInjection\ContainerBuilder::has() does only seem to accept string, maybe add an additional type check?

                throw new ServiceNotFoundException($container->getParameter($parameter));
            }

            $container->setAlias($service, $container->getParameter($parameter));

It seems like $container->getParameter($parameter) can also be of type array; however, parameter $id of Symfony\Component\DependencyInjection\ContainerBuilder::setAlias() does only seem to accept Symfony\Component\DependencyInjection\Alias|string, maybe add an additional type check?

        } elseif ($container->has($factoryInterface)) {
            $container->setAlias($service, $factoryInterface);
        } elseif ($container->has('nyholm.psr7.psr17_factory')) {
            $container->setAlias($service, 'nyholm.psr7.psr17_factory');
        } elseif (class_exists(Psr17Factory::class)) {
            $container->setAlias($service, self::PSR17_FACTORY_SERVICE_ID);
        }
    }
}