ShredderCommand.handle() - Code Metrics - Inspection of "Hernoemen folders." - SetBased/py-kerapu - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed

Push — master ( 15d04b...75383a )

by P.R.

created 2017-01-25 14:58 UTC

ShredderCommand.handle() B

↳ Parent: ShredderCommand

Complexity

Conditions

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	3
c	1
b	0
f	0
dl	0
loc	25
rs	8.8571

"""
Kerapu
"""
from cleo import Command
# .scrutinizer.yml
before_commands:
    - sudo pip install abc # Python2
    - sudo pip3 install abc # Python3

from kerapu.shredder.BoomBestandenShredder import BoomBestandenShredder
from kerapu.shredder.ReferentieShredder import ReferentieShredder
from kerapu.style.KerapuStyle import KerapuStyle


class ShredderCommand(Command):

    """
    Converteert XML-bestanden met groupertabellen naar CSV-bestanden

    kerapu:shredder
        {XML-bestand : XML-bestand met groupertabellen, b.v. BoomBestanden.xml, Referenties.xml}
        {folder : Folder waar de CSV-bestanden moeten worden opgeslagen}
    """

    # ------------------------------------------------------------------------------------------------------------------
    def handle(self):
        """
        Executes the command.
        """
        self.output = KerapuStyle(self.input, self.output)
class Foo:
    def __init__(self, x=None):
        self.x = x

        filename = self.argument('XML-bestand')

        folder = self.argument('folder')


        # Lees de eerste gedeelte van het XML-bestand en bepaal type.
        kop = open(filename, 'rt').read(1024)

        if '<InlezenBoomBestanden>' in kop:
            shredder = BoomBestandenShredder(self.output, folder)
            shredder.shred_xml_file(filename)

        elif '<InlezenReferenties>' in kop:
            shredder = ReferentieShredder(self.output, folder)
            shredder.shred_xml_file(filename)

        else:
            raise RuntimeError("Tag <InlezenBoomBestanden> of <InlezenReferenties> niet gevonden in '{}'".
                               format(filename))

        return 0

# ----------------------------------------------------------------------------------------------------------------------


GitHub Access Token became invalid

Push — master ( 15d04b...75383a )

ShredderCommand.handle() B

Complexity

Size

Duplication

Importance

1. Missing Dependencies

2. Missing init.py files

1			"""
2			Kerapu
3			"""
4			from cleo import Command
			0 ignored issues – show Configuration introduced 2017-01-25 15:03 UTC by Report Bug Copy Issue Report The import `cleo` could not be resolved. This can be caused by one of the following: 1. Missing Dependencies This error could indicate a configuration issue of Pylint. Make sure that your libraries are available by adding the necessary commands. # .scrutinizer.yml before_commands: - sudo pip install abc # Python2 - sudo pip3 install abc # Python3 Tip: We are currently not using virtualenv to run pylint, when installing your modules make sure to use the command for the correct version. 2. Missing __init__.py files This error could also result from missing `__init__.py` files in your module folders. Make sure that you place one file in each sub-folder. Loading history...
5
6			from kerapu.shredder.BoomBestandenShredder import BoomBestandenShredder
7			from kerapu.shredder.ReferentieShredder import ReferentieShredder
8			from kerapu.style.KerapuStyle import KerapuStyle
9
10
11			class ShredderCommand(Command):
			0 ignored issues – show Coding Style introduced 2017-01-25 15:03 UTC by Report Bug Copy Issue Report This class has no `__init__` method. Loading history...
12			"""
13			Converteert XML-bestanden met groupertabellen naar CSV-bestanden
14
15			kerapu:shredder
16			{XML-bestand : XML-bestand met groupertabellen, b.v. BoomBestanden.xml, Referenties.xml}
17			{folder : Folder waar de CSV-bestanden moeten worden opgeslagen}
18			"""
19
20			# ------------------------------------------------------------------------------------------------------------------
21			def handle(self):
22			"""
23			Executes the command.
24			"""
25			self.output = KerapuStyle(self.input, self.output)
			0 ignored issues – show Bug introduced 2017-01-25 15:03 UTC by Report Bug Copy Issue Report The Instance of `ShredderCommand` does not seem to have a member named `input`. This check looks for calls to members that are non-existent. These calls will fail. The member could have been renamed or removed. Loading history... Coding Style introduced 2017-01-25 15:03 UTC by Report Bug Copy Issue Report The attribute `output` was defined outside `__init__`. It is generally a good practice to initialize all attributes to default values in the `__init__` method: class Foo: def __init__(self, x=None): self.x = x Loading history...
26
27			filename = self.argument('XML-bestand')
			0 ignored issues – show Bug introduced 2017-01-25 15:03 UTC by Report Bug Copy Issue Report The Instance of `ShredderCommand` does not seem to have a member named `argument`. This check looks for calls to members that are non-existent. These calls will fail. The member could have been renamed or removed. Loading history...
28			folder = self.argument('folder')
			0 ignored issues – show Bug introduced 2017-01-25 15:03 UTC by Report Bug Copy Issue Report The Instance of `ShredderCommand` does not seem to have a member named `argument`. This check looks for calls to members that are non-existent. These calls will fail. The member could have been renamed or removed. Loading history...
29
30			# Lees de eerste gedeelte van het XML-bestand en bepaal type.
31			kop = open(filename, 'rt').read(1024)
32
33			if '<InlezenBoomBestanden>' in kop:
34			shredder = BoomBestandenShredder(self.output, folder)
35			shredder.shred_xml_file(filename)
36
37			elif '<InlezenReferenties>' in kop:
38			shredder = ReferentieShredder(self.output, folder)
39			shredder.shred_xml_file(filename)
40
41			else:
42			raise RuntimeError("Tag <InlezenBoomBestanden> of <InlezenReferenties> niet gevonden in '{}'".
43			format(filename))
44
45			return 0
46
47			# ----------------------------------------------------------------------------------------------------------------------
48

SetBased / py-kerapu

GitHub Access Token became invalid

Push — master ( 15d04b...75383a )

ShredderCommand.handle() B

Complexity

Size

Duplication

Importance

1. Missing Dependencies

2. Missing __init__.py files

Duplication Side-by-Side

Filter issues like

2. Missing init.py files