ControllerCommand - Code Metrics - Inspection of "Enk-100: Make Enarksh a cleo application." - SetBased/py-enarksh - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#3)

by Oleg

created 2016-08-01 11:10 UTC

ControllerCommand A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	29
Duplicated Lines	0 %

Test Coverage

Coverage

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	29
ccs	0
cts	9
cp	0
rs	10
wmc	2

1 Method

Rating	Name	Duplication	Size	Complexity
A	handle()	0	12	2

"""
Enarksh

Copyright 2013-2016 Set Based IT Consultancy

Licence MIT
"""
# ----------------------------------------------------------------------------------------------------------------------
from cleo import Command

from enarksh.Controller.Controller import Controller
from enarksh.style.EnarkshStyle import EnarkshStyle


# ----------------------------------------------------------------------------------------------------------------------
class ControllerCommand(Command):
    """
    Starts the controller.
    """

    name = 'controller'

    options = [
        {
            'name': 'daemonize',
            'shortcut': 'd',
            'flag': True,
            'description': 'If set, use demonize'
        }
    ]

    # ------------------------------------------------------------------------------------------------------------------
    def handle(self):
        """
        Executes the controller command.
        """
        self._io = EnarkshStyle(self.input, self.output)
class Foo:
    def __init__(self, x=None):
        self.x = x

        controller = Controller()

        if self.option('daemonize'):
            controller._daemonize()
class MyParent:
    def __init__(self):
        self._x = 1;
        self.y = 2;

class MyChild(MyParent):
    def some_method(self):
        return self._x    # Ok, since accessed from a child class

class AnotherClass:
    def some_method(self, instance_of_my_child):
        return instance_of_my_child._x   # Would be flagged as AnotherClass is not
                                         # a child class of MyParent

        controller.main()


# ----------------------------------------------------------------------------------------------------------------------


1			"""
2			Enarksh
3
4			Copyright 2013-2016 Set Based IT Consultancy
5
6			Licence MIT
7			"""
8			# ----------------------------------------------------------------------------------------------------------------------
9			from cleo import Command
10
11			from enarksh.Controller.Controller import Controller
12			from enarksh.style.EnarkshStyle import EnarkshStyle
13
14
15			# ----------------------------------------------------------------------------------------------------------------------
16			class ControllerCommand(Command):
17			"""
18			Starts the controller.
19			"""
20
21			name = 'controller'
22
23			options = [
24			{
25			'name': 'daemonize',
26			'shortcut': 'd',
27			'flag': True,
28			'description': 'If set, use demonize'
29			}
30			]
31
32			# ------------------------------------------------------------------------------------------------------------------
33			def handle(self):
34			"""
35			Executes the controller command.
36			"""
37			self._io = EnarkshStyle(self.input, self.output)
			0 ignored issues – show Coding Style introduced 2016-08-01 11:12 UTC by Report Bug Copy Issue Report The attribute `_io` was defined outside `__init__`. It is generally a good practice to initialize all attributes to default values in the `__init__` method: class Foo: def __init__(self, x=None): self.x = x Loading history...
38
39			controller = Controller()
40
41			if self.option('daemonize'):
42			controller._daemonize()
			0 ignored issues – show Coding Style Best Practice introduced 2016-08-01 11:12 UTC by Report Bug Copy Issue Report It seems like `_daemonize` was declared protected and should not be accessed from this context. Prefixing a member variable `_` is usually regarded as the equivalent of declaring it with protected visibility that exists in other languages. Consequentially, such a member should only be accessed from the same class or a child class: class MyParent: def __init__(self): self._x = 1; self.y = 2; class MyChild(MyParent): def some_method(self): return self._x # Ok, since accessed from a child class class AnotherClass: def some_method(self, instance_of_my_child): return instance_of_my_child._x # Would be flagged as AnotherClass is not # a child class of MyParent Loading history...
43
44			controller.main()
45
46
47			# ----------------------------------------------------------------------------------------------------------------------
48

SetBased / py-enarksh

GitHub Access Token became invalid

Pull Request — master (#3)

ControllerCommand A

Complexity

Size/Duplication

Test Coverage

Importance

1 Method

Duplication Side-by-Side

Filter issues like