Total Complexity | 2 |
Total Lines | 43 |
Duplicated Lines | 0 % |
Coverage | 0% |
Changes | 1 | ||
Bugs | 0 | Features | 0 |
1 | """ |
||
15 | class NodeActionMessageEventHandler(NodeActionMessageBaseEventHandler): |
||
16 | """ |
||
17 | An event handler for a NodeActionMessage received events. |
||
18 | """ |
||
19 | |||
20 | # ------------------------------------------------------------------------------------------------------------------ |
||
21 | @staticmethod |
||
22 | def handle(_event, message, controller): |
||
23 | """ |
||
24 | Handles a NodeActionMessage received event. |
||
25 | |||
26 | :param * _event: Not used. |
||
27 | :param enarksh.controller.message.NodeActionMessage.NodeActionMessage message: The message. |
||
28 | :param enarksh.controller.Controller.Controller controller: The controller. |
||
29 | """ |
||
30 | del _event |
||
31 | |||
32 | # Compose a response message for client. |
||
33 | response = {'ret': 0, |
||
34 | 'message': ''} |
||
35 | |||
36 | try: |
||
37 | run_node = DataLayer.enk_back_run_node_get_by_uri(message.uri) |
||
38 | |||
39 | NodeActionMessageBaseEventHandler.base_handle(controller, |
||
40 | response, |
||
41 | run_node['sch_id'], |
||
42 | run_node['rnd_id'], |
||
43 | message.act_id, |
||
44 | '', |
||
45 | False, |
||
46 | False) |
||
47 | except Exception as exception: |
||
1 ignored issue
–
show
|
|||
48 | print(exception, file=sys.stderr) |
||
49 | traceback.print_exc(file=sys.stderr) |
||
50 | |||
51 | response['ret'] = -1 |
||
52 | response['message'] = 'Internal error' |
||
53 | |||
54 | DataLayer.rollback() |
||
55 | |||
56 | # Send response message to the CLI client. |
||
57 | controller.message_controller.send_message('lockstep', response) |
||
58 | |||
60 |
Generally, you would want to handle very specific errors in the exception handler. This ensure that you do not hide other types of errors which should be fixed.
So, unless you specifically plan to handle any error, consider adding a more specific exception.