SerhiiCho /
timeago
| Conditions | 4 |
| Total Lines | 66 |
| Code Lines | 62 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | package tests |
||
| 72 | func TestTakeRuWithOnlineFlag(t *testing.T) { |
||
| 73 | cases := []struct { |
||
| 74 | date string |
||
| 75 | result string |
||
| 76 | lang string |
||
| 77 | }{ |
||
| 78 | {smallSubTime(time.Second * 2), "В сети", "ru"}, |
||
| 79 | {smallSubTime(time.Second), "В сети", "ru"}, |
||
| 80 | {smallSubTime(-1 * time.Second), "В сети", "ru"}, |
||
| 81 | {smallSubTime(-2 * time.Second), "В сети", "ru"}, |
||
| 82 | {smallSubTime(-9 * time.Second), "В сети", "ru"}, |
||
| 83 | {smallSubTime(-10 * time.Second), "В сети", "ru"}, |
||
| 84 | {smallSubTime(-11 * time.Second), "В сети", "ru"}, |
||
| 85 | {smallSubTime(-20 * time.Second), "В сети", "ru"}, |
||
| 86 | {smallSubTime(-21 * time.Second), "В сети", "ru"}, |
||
| 87 | {smallSubTime(-22 * time.Second), "В сети", "ru"}, |
||
| 88 | {smallSubTime(-30 * time.Second), "В сети", "ru"}, |
||
| 89 | {smallSubTime(-31 * time.Second), "В сети", "ru"}, |
||
| 90 | {smallSubTime(-60 * time.Second), "1 минута назад", "ru"}, |
||
| 91 | {smallSubTime(-1 * time.Minute), "1 минута назад", "ru"}, |
||
| 92 | {smallSubTime(-2 * time.Minute), "2 минуты назад", "ru"}, |
||
| 93 | {smallSubTime(-9 * time.Minute), "9 минут назад", "ru"}, |
||
| 94 | {smallSubTime(-10 * time.Minute), "10 минут назад", "ru"}, |
||
| 95 | {smallSubTime(-11 * time.Minute), "11 минут назад", "ru"}, |
||
| 96 | {smallSubTime(-20 * time.Minute), "20 минут назад", "ru"}, |
||
| 97 | {smallSubTime(-21 * time.Minute), "21 минута назад", "ru"}, |
||
| 98 | {smallSubTime(-22 * time.Minute), "22 минуты назад", "ru"}, |
||
| 99 | {smallSubTime(-30 * time.Minute), "30 минут назад", "ru"}, |
||
| 100 | {smallSubTime(-31 * time.Minute), "31 минута назад", "ru"}, |
||
| 101 | {smallSubTime(-60 * time.Minute), "1 час назад", "ru"}, |
||
| 102 | {smallSubTime(-1 * time.Hour), "1 час назад", "ru"}, |
||
| 103 | {smallSubTime(-2 * time.Hour), "2 часа назад", "ru"}, |
||
| 104 | {smallSubTime(-9 * time.Hour), "9 часов назад", "ru"}, |
||
| 105 | {smallSubTime(-10 * time.Hour), "10 часов назад", "ru"}, |
||
| 106 | {smallSubTime(-11 * time.Hour), "11 часов назад", "ru"}, |
||
| 107 | {smallSubTime(-20 * time.Hour), "20 часов назад", "ru"}, |
||
| 108 | {smallSubTime(-21 * time.Hour), "21 час назад", "ru"}, |
||
| 109 | {smallSubTime(-23 * time.Hour), "23 часа назад", "ru"}, |
||
| 110 | {smallSubTime(-24 * time.Hour), "1 день назад", "ru"}, |
||
| 111 | {smallSubTime(-30 * time.Hour), "1 день назад", "ru"}, |
||
| 112 | {smallSubTime((-24 * 2) * time.Hour), "2 дня назад", "ru"}, |
||
| 113 | {smallSubTime((-24 * 6) * time.Hour), "6 дней назад", "ru"}, |
||
| 114 | {smallSubTime((-24 * 7) * time.Hour), "1 неделя назад", "ru"}, |
||
| 115 | {smallSubTime((-24 * 14) * time.Hour), "2 недели назад", "ru"}, |
||
| 116 | {smallSubTime((-24 * 21) * time.Hour), "3 недели назад", "ru"}, |
||
| 117 | {bigSubTime(0, 1, 1), "1 месяц назад", "ru"}, |
||
| 118 | {bigSubTime(0, 2, 1), "2 месяца назад", "ru"}, |
||
| 119 | {bigSubTime(0, 9, 1), "9 месяцев назад", "ru"}, |
||
| 120 | {bigSubTime(0, 11, 1), "11 месяцев назад", "ru"}, |
||
| 121 | {bigSubTime(0, 12, 1), "1 год назад", "ru"}, |
||
| 122 | {bigSubTime(1, 0, 1), "1 год назад", "ru"}, |
||
| 123 | {bigSubTime(2, 0, 1), "2 года назад", "ru"}, |
||
| 124 | {bigSubTime(5, 0, 1), "5 лет назад", "ru"}, |
||
| 125 | {bigSubTime(6, 0, 1), "6 лет назад", "ru"}, |
||
| 126 | {bigSubTime(7, 0, 1), "7 лет назад", "ru"}, |
||
| 127 | {bigSubTime(21, 0, 1), "21 год назад", "ru"}, |
||
| 128 | {bigSubTime(31, 0, 1), "31 год назад", "ru"}, |
||
| 129 | {bigSubTime(100, 0, 1), "100 лет назад", "ru"}, |
||
| 130 | } |
||
| 131 | |||
| 132 | for _, tc := range cases { |
||
| 133 | t.Run("result for "+tc.date+"|online", func(test *testing.T) { |
||
| 134 | timeago.Set("language", tc.lang) |
||
| 135 | |||
| 136 | if res := timeago.Take(tc.date + "|online"); res != tc.result { |
||
| 137 | test.Errorf("Result must be %s, but got %s instead", tc.result, res) |
||
| 138 | } |
||
| 174 |
