SerhiiCho /
timeago
| Conditions | 4 |
| Total Lines | 57 |
| Code Lines | 53 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | package tests |
||
| 10 | func TestTakeRu(t *testing.T) { |
||
| 11 | cases := []struct { |
||
| 12 | date string |
||
| 13 | result string |
||
| 14 | lang string |
||
| 15 | }{ |
||
| 16 | {smallSubTime(-60 * time.Second), "1 минута назад", "ru"}, |
||
| 17 | {smallSubTime(-1 * time.Minute), "1 минута назад", "ru"}, |
||
| 18 | {smallSubTime(-2 * time.Minute), "2 минуты назад", "ru"}, |
||
| 19 | {smallSubTime(-5 * time.Minute), "5 минут назад", "ru"}, |
||
| 20 | {smallSubTime(-9 * time.Minute), "9 минут назад", "ru"}, |
||
| 21 | {smallSubTime(-10 * time.Minute), "10 минут назад", "ru"}, |
||
| 22 | {smallSubTime(-11 * time.Minute), "11 минут назад", "ru"}, |
||
| 23 | {smallSubTime(-20 * time.Minute), "20 минут назад", "ru"}, |
||
| 24 | {smallSubTime(-21 * time.Minute), "21 минута назад", "ru"}, |
||
| 25 | {smallSubTime(-22 * time.Minute), "22 минуты назад", "ru"}, |
||
| 26 | {smallSubTime(-30 * time.Minute), "30 минут назад", "ru"}, |
||
| 27 | {smallSubTime(-31 * time.Minute), "31 минута назад", "ru"}, |
||
| 28 | {smallSubTime(-59 * time.Minute), "59 минут назад", "ru"}, |
||
| 29 | {smallSubTime(-60 * time.Minute), "1 час назад", "ru"}, |
||
| 30 | {smallSubTime(-1 * time.Hour), "1 час назад", "ru"}, |
||
| 31 | {smallSubTime(-2 * time.Hour), "2 часа назад", "ru"}, |
||
| 32 | {smallSubTime(-9 * time.Hour), "9 часов назад", "ru"}, |
||
| 33 | {smallSubTime(-10 * time.Hour), "10 часов назад", "ru"}, |
||
| 34 | {smallSubTime(-11 * time.Hour), "11 часов назад", "ru"}, |
||
| 35 | {smallSubTime(-20 * time.Hour), "20 часов назад", "ru"}, |
||
| 36 | {smallSubTime(-21 * time.Hour), "21 час назад", "ru"}, |
||
| 37 | {smallSubTime(-23 * time.Hour), "23 часа назад", "ru"}, |
||
| 38 | {smallSubTime(-24 * time.Hour), "1 день назад", "ru"}, |
||
| 39 | {smallSubTime(-30 * time.Hour), "1 день назад", "ru"}, |
||
| 40 | {smallSubTime((-24 * 2) * time.Hour), "2 дня назад", "ru"}, |
||
| 41 | {smallSubTime((-24 * 6) * time.Hour), "6 дней назад", "ru"}, |
||
| 42 | {smallSubTime((-24 * 7) * time.Hour), "1 неделя назад", "ru"}, |
||
| 43 | {smallSubTime((-24 * 14) * time.Hour), "2 недели назад", "ru"}, |
||
| 44 | {smallSubTime((-24 * 21) * time.Hour), "3 недели назад", "ru"}, |
||
| 45 | {bigSubTime(0, 1, 1), "1 месяц назад", "ru"}, |
||
| 46 | {bigSubTime(0, 2, 1), "2 месяца назад", "ru"}, |
||
| 47 | {bigSubTime(0, 9, 1), "9 месяцев назад", "ru"}, |
||
| 48 | {bigSubTime(0, 11, 1), "11 месяцев назад", "ru"}, |
||
| 49 | {bigSubTime(0, 12, 1), "1 год назад", "ru"}, |
||
| 50 | {bigSubTime(1, 0, 1), "1 год назад", "ru"}, |
||
| 51 | {bigSubTime(2, 0, 1), "2 года назад", "ru"}, |
||
| 52 | {bigSubTime(5, 0, 1), "5 лет назад", "ru"}, |
||
| 53 | {bigSubTime(6, 0, 1), "6 лет назад", "ru"}, |
||
| 54 | {bigSubTime(7, 0, 1), "7 лет назад", "ru"}, |
||
| 55 | {bigSubTime(21, 0, 1), "21 год назад", "ru"}, |
||
| 56 | {bigSubTime(31, 0, 1), "31 год назад", "ru"}, |
||
| 57 | {bigSubTime(100, 0, 1), "100 лет назад", "ru"}, |
||
| 58 | } |
||
| 59 | |||
| 60 | for _, tc := range cases { |
||
| 61 | t.Run("result for "+tc.date, func(test *testing.T) { |
||
| 62 | timeago.Set("language", tc.lang) |
||
| 63 | timeago.Set("location", "Europe/Kiev") |
||
| 64 | |||
| 65 | if res := timeago.Take(tc.date); res != tc.result { |
||
| 66 | test.Errorf("Result must be %s, but got %s instead", tc.result, res) |
||
| 67 | } |
||
| 174 |
