Conditions | 5 |
Total Lines | 57 |
Code Lines | 50 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | package tests |
||
12 | func TestParseRu(t *testing.T) { |
||
13 | cases := []struct { |
||
14 | date time.Time |
||
15 | res string |
||
16 | }{ |
||
17 | {subMinutes(1), "1 минута назад"}, |
||
18 | {subMinutes(2), "2 минуты назад"}, |
||
19 | {subMinutes(5), "5 минут назад"}, |
||
20 | {subMinutes(9), "9 минут назад"}, |
||
21 | {subMinutes(10), "10 минут назад"}, |
||
22 | {subMinutes(11), "11 минут назад"}, |
||
23 | {subMinutes(20), "20 минут назад"}, |
||
24 | {subMinutes(21), "21 минута назад"}, |
||
25 | {subMinutes(22), "22 минуты назад"}, |
||
26 | {subMinutes(30), "30 минут назад"}, |
||
27 | {subMinutes(31), "31 минута назад"}, |
||
28 | {subMinutes(59), "59 минут назад"}, |
||
29 | {subHours(1), "1 час назад"}, |
||
30 | {subHours(2), "2 часа назад"}, |
||
31 | {subHours(9), "9 часов назад"}, |
||
32 | {subHours(10), "10 часов назад"}, |
||
33 | {subHours(11), "11 часов назад"}, |
||
34 | {subHours(20), "20 часов назад"}, |
||
35 | {subHours(21), "21 час назад"}, |
||
36 | {subHours(23), "23 часа назад"}, |
||
37 | {subDays(1), "1 день назад"}, |
||
38 | {subDays(2), "2 дня назад"}, |
||
39 | {subDays(6), "6 дней назад"}, |
||
40 | {subWeeks(1), "1 неделя назад"}, |
||
41 | {subWeeks(2), "2 недели назад"}, |
||
42 | {subWeeks(3), "3 недели назад"}, |
||
43 | {subMonths(1), "1 месяц назад"}, |
||
44 | {subMonths(2), "2 месяца назад"}, |
||
45 | {subMonths(9), "9 месяцев назад"}, |
||
46 | {subMonths(11), "11 месяцев назад"}, |
||
47 | {subYears(1), "1 год назад"}, |
||
48 | {subYears(2), "2 года назад"}, |
||
49 | {subYears(5), "5 лет назад"}, |
||
50 | {subYears(6), "6 лет назад"}, |
||
51 | {subYears(7), "7 лет назад"}, |
||
52 | {subYears(21), "21 год назад"}, |
||
53 | {subYears(31), "31 год назад"}, |
||
54 | {subYears(100), "100 лет назад"}, |
||
55 | } |
||
56 | |||
57 | for _, tc := range cases { |
||
58 | t.Run("result for "+tc.date.String(), func(test *testing.T) { |
||
59 | timeago.Reconfigure(timeago.Config{Language: langRu}) |
||
60 | |||
61 | res, err := timeago.Parse(tc.date) |
||
62 | |||
63 | if err != nil { |
||
64 | test.Errorf("Error must be nil, but got %v instead", err) |
||
65 | } |
||
66 | |||
67 | if res != tc.res { |
||
68 | test.Errorf("Result must be %s, but got %s instead", tc.res, res) |
||
69 | } |
||
109 |