Conditions | 5 |
Total Lines | 62 |
Code Lines | 55 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | package tests |
||
12 | func TestParseNl(t *testing.T) { |
||
13 | cases := []struct { |
||
14 | date time.Time |
||
15 | res string |
||
16 | }{ |
||
17 | {subMinutes(1), "1 minuut geleden"}, |
||
18 | {subMinutes(2), "2 minuten geleden"}, |
||
19 | {subMinutes(5), "5 minuten geleden"}, |
||
20 | {subMinutes(9), "9 minuten geleden"}, |
||
21 | {subMinutes(10), "10 minuten geleden"}, |
||
22 | {subMinutes(11), "11 minuten geleden"}, |
||
23 | {subMinutes(20), "20 minuten geleden"}, |
||
24 | {subMinutes(21), "21 minuten geleden"}, |
||
25 | {subMinutes(22), "22 minuten geleden"}, |
||
26 | {subMinutes(30), "30 minuten geleden"}, |
||
27 | {subMinutes(31), "31 minuten geleden"}, |
||
28 | {subMinutes(59), "59 minuten geleden"}, |
||
29 | {subMinutes(60), "1 uur geleden"}, |
||
30 | {subHours(1), "1 uur geleden"}, |
||
31 | {subHours(2), "2 uur geleden"}, |
||
32 | {subHours(9), "9 uur geleden"}, |
||
33 | {subHours(10), "10 uur geleden"}, |
||
34 | {subHours(11), "11 uur geleden"}, |
||
35 | {subHours(20), "20 uur geleden"}, |
||
36 | {subHours(21), "21 uur geleden"}, |
||
37 | {subHours(23), "23 uur geleden"}, |
||
38 | {subDays(1), "1 dag geleden"}, |
||
39 | {subDays(2), "2 dagen geleden"}, |
||
40 | {subDays(6), "6 dagen geleden"}, |
||
41 | {subWeeks(1), "1 week geleden"}, |
||
42 | {subWeeks(2), "2 weken geleden"}, |
||
43 | {subWeeks(3), "3 weken geleden"}, |
||
44 | {subMonths(1), "1 maand geleden"}, |
||
45 | {subMonths(2), "2 maanden geleden"}, |
||
46 | {subMonths(3), "3 maanden geleden"}, |
||
47 | {subMonths(4), "4 maanden geleden"}, |
||
48 | {subMonths(5), "5 maanden geleden"}, |
||
49 | {subMonths(6), "6 maanden geleden"}, |
||
50 | {subMonths(7), "7 maanden geleden"}, |
||
51 | {subMonths(8), "8 maanden geleden"}, |
||
52 | {subMonths(9), "9 maanden geleden"}, |
||
53 | {subMonths(10), "10 maanden geleden"}, |
||
54 | {subMonths(11), "11 maanden geleden"}, |
||
55 | {subYears(1), "1 jaar geleden"}, |
||
56 | {subYears(2), "2 jaar geleden"}, |
||
57 | {subYears(21), "21 jaar geleden"}, |
||
58 | {subYears(31), "31 jaar geleden"}, |
||
59 | {subYears(100), "100 jaar geleden"}, |
||
60 | } |
||
61 | |||
62 | for _, tc := range cases { |
||
63 | t.Run("result for "+tc.date.String(), func(test *testing.T) { |
||
64 | timeago.Reconfigure(timeago.Config{Language: langNl}) |
||
65 | |||
66 | res, err := timeago.Parse(tc.date) |
||
67 | |||
68 | if err != nil { |
||
69 | test.Errorf("Error must be nil, but got %v instead", err) |
||
70 | } |
||
71 | |||
72 | if res != tc.res { |
||
73 | test.Errorf("Result must be %s, but got %s instead", tc.res, res) |
||
74 | } |
||
114 |