Conditions | 5 |
Total Lines | 56 |
Code Lines | 49 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | package tests |
||
12 | func TestParseEn(t *testing.T) { |
||
13 | cases := []struct { |
||
14 | date time.Time |
||
15 | res string |
||
16 | }{ |
||
17 | {subMinutes(1), "1 minute ago"}, |
||
18 | {subMinutes(2), "2 minutes ago"}, |
||
19 | {subMinutes(5), "5 minutes ago"}, |
||
20 | {subMinutes(9), "9 minutes ago"}, |
||
21 | {subMinutes(10), "10 minutes ago"}, |
||
22 | {subMinutes(11), "11 minutes ago"}, |
||
23 | {subMinutes(20), "20 minutes ago"}, |
||
24 | {subMinutes(21), "21 minutes ago"}, |
||
25 | {subMinutes(22), "22 minutes ago"}, |
||
26 | {subMinutes(30), "30 minutes ago"}, |
||
27 | {subMinutes(31), "31 minutes ago"}, |
||
28 | {subMinutes(59), "59 minutes ago"}, |
||
29 | {subHours(1), "1 hour ago"}, |
||
30 | {subHours(2), "2 hours ago"}, |
||
31 | {subHours(9), "9 hours ago"}, |
||
32 | {subHours(10), "10 hours ago"}, |
||
33 | {subHours(11), "11 hours ago"}, |
||
34 | {subHours(20), "20 hours ago"}, |
||
35 | {subHours(21), "21 hours ago"}, |
||
36 | {subHours(23), "23 hours ago"}, |
||
37 | {subDays(1), "1 day ago"}, |
||
38 | {subDays(2), "2 days ago"}, |
||
39 | {subDays(4), "4 days ago"}, |
||
40 | {subDays(5), "5 days ago"}, |
||
41 | {subDays(6), "6 days ago"}, |
||
42 | {subWeeks(1), "1 week ago"}, |
||
43 | {subWeeks(2), "2 weeks ago"}, |
||
44 | {subWeeks(3), "3 weeks ago"}, |
||
45 | {subMonths(1), "1 month ago"}, |
||
46 | {subMonths(2), "2 months ago"}, |
||
47 | {subMonths(9), "9 months ago"}, |
||
48 | {subMonths(11), "11 months ago"}, |
||
49 | {subYears(1), "1 year ago"}, |
||
50 | {subYears(2), "2 years ago"}, |
||
51 | {subYears(21), "21 years ago"}, |
||
52 | {subYears(31), "31 years ago"}, |
||
53 | {subYears(100), "100 years ago"}, |
||
54 | } |
||
55 | |||
56 | for _, tc := range cases { |
||
57 | t.Run("result for "+tc.date.String(), func(test *testing.T) { |
||
58 | timeago.Reconfigure(timeago.Config{Language: langEn}) |
||
59 | |||
60 | res, err := timeago.Parse(tc.date) |
||
61 | |||
62 | if err != nil { |
||
63 | test.Errorf("Error must be nil, but got %v instead", err) |
||
64 | } |
||
65 | |||
66 | if res != tc.res { |
||
67 | test.Errorf("Result must be %s, but got %s instead", tc.res, res) |
||
68 | } |
||
107 |