Conditions | 4 |
Total Lines | 122 |
Code Lines | 116 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | package timeago |
||
124 | func TestTake(t *testing.T) { |
||
125 | cases := []struct { |
||
126 | date string |
||
127 | result string |
||
128 | lang string |
||
129 | }{ |
||
130 | // english |
||
131 | {smallSubTime(time.Second * 2), "0 seconds ago", "en"}, |
||
132 | {smallSubTime(time.Second), "0 seconds ago", "en"}, |
||
133 | {smallSubTime(-1 * time.Second), "1 second ago", "en"}, |
||
134 | {smallSubTime(-2 * time.Second), "2 seconds ago", "en"}, |
||
135 | {smallSubTime(-9 * time.Second), "9 seconds ago", "en"}, |
||
136 | {smallSubTime(-10 * time.Second), "10 seconds ago", "en"}, |
||
137 | {smallSubTime(-11 * time.Second), "11 seconds ago", "en"}, |
||
138 | {smallSubTime(-20 * time.Second), "20 seconds ago", "en"}, |
||
139 | {smallSubTime(-21 * time.Second), "21 second ago", "en"}, |
||
140 | {smallSubTime(-22 * time.Second), "22 seconds ago", "en"}, |
||
141 | {smallSubTime(-30 * time.Second), "30 seconds ago", "en"}, |
||
142 | {smallSubTime(-31 * time.Second), "31 second ago", "en"}, |
||
143 | {smallSubTime(-59 * time.Second), "59 seconds ago", "en"}, |
||
144 | {smallSubTime(-60 * time.Second), "1 minute ago", "en"}, |
||
145 | {smallSubTime(-1 * time.Minute), "1 minute ago", "en"}, |
||
146 | {smallSubTime(-2 * time.Minute), "2 minutes ago", "en"}, |
||
147 | {smallSubTime(-9 * time.Minute), "9 minutes ago", "en"}, |
||
148 | {smallSubTime(-10 * time.Minute), "10 minutes ago", "en"}, |
||
149 | {smallSubTime(-11 * time.Minute), "11 minutes ago", "en"}, |
||
150 | {smallSubTime(-20 * time.Minute), "20 minutes ago", "en"}, |
||
151 | {smallSubTime(-21 * time.Minute), "21 minute ago", "en"}, |
||
152 | {smallSubTime(-22 * time.Minute), "22 minutes ago", "en"}, |
||
153 | {smallSubTime(-30 * time.Minute), "30 minutes ago", "en"}, |
||
154 | {smallSubTime(-31 * time.Minute), "31 minute ago", "en"}, |
||
155 | {smallSubTime(-59 * time.Minute), "59 minutes ago", "en"}, |
||
156 | {smallSubTime(-60 * time.Minute), "1 hour ago", "en"}, |
||
157 | {smallSubTime(-1 * time.Hour), "1 hour ago", "en"}, |
||
158 | {smallSubTime(-2 * time.Hour), "2 hours ago", "en"}, |
||
159 | {smallSubTime(-9 * time.Hour), "9 hours ago", "en"}, |
||
160 | {smallSubTime(-10 * time.Hour), "10 hours ago", "en"}, |
||
161 | {smallSubTime(-11 * time.Hour), "11 hours ago", "en"}, |
||
162 | {smallSubTime(-20 * time.Hour), "20 hours ago", "en"}, |
||
163 | {smallSubTime(-21 * time.Hour), "21 hour ago", "en"}, |
||
164 | {smallSubTime(-23 * time.Hour), "23 hours ago", "en"}, |
||
165 | {smallSubTime(-24 * time.Hour), "1 day ago", "en"}, |
||
166 | {smallSubTime(-47 * time.Hour), "1 day ago", "en"}, |
||
167 | {smallSubTime((-24 * 2) * time.Hour), "2 days ago", "en"}, |
||
168 | {smallSubTime((-24 * 6) * time.Hour), "6 days ago", "en"}, |
||
169 | {smallSubTime((-24 * 7) * time.Hour), "1 week ago", "en"}, |
||
170 | {smallSubTime((-24 * 14) * time.Hour), "2 weeks ago", "en"}, |
||
171 | {smallSubTime((-24 * 21) * time.Hour), "3 weeks ago", "en"}, |
||
172 | {bigSubTime(0, 1, 1), "1 month ago", "en"}, |
||
173 | {bigSubTime(0, 2, 1), "2 months ago", "en"}, |
||
174 | {bigSubTime(0, 9, 1), "9 months ago", "en"}, |
||
175 | {bigSubTime(0, 11, 1), "11 months ago", "en"}, |
||
176 | {bigSubTime(0, 12, 1), "1 year ago", "en"}, |
||
177 | {bigSubTime(1, 0, 1), "1 year ago", "en"}, |
||
178 | {bigSubTime(2, 0, 1), "2 years ago", "en"}, |
||
179 | {bigSubTime(21, 0, 1), "21 year ago", "en"}, |
||
180 | {bigSubTime(31, 0, 1), "31 year ago", "en"}, |
||
181 | {bigSubTime(100, 0, 1), "100 years ago", "en"}, |
||
182 | // russian |
||
183 | {smallSubTime(time.Second * 2), "0 секунд назад", "ru"}, |
||
184 | {smallSubTime(time.Second), "0 секунд назад", "ru"}, |
||
185 | {smallSubTime(-1 * time.Second), "1 секунда назад", "ru"}, |
||
186 | {smallSubTime(-2 * time.Second), "2 секунды назад", "ru"}, |
||
187 | {smallSubTime(-9 * time.Second), "9 секунд назад", "ru"}, |
||
188 | {smallSubTime(-10 * time.Second), "10 секунд назад", "ru"}, |
||
189 | {smallSubTime(-11 * time.Second), "11 секунд назад", "ru"}, |
||
190 | {smallSubTime(-20 * time.Second), "20 секунд назад", "ru"}, |
||
191 | {smallSubTime(-21 * time.Second), "21 секунда назад", "ru"}, |
||
192 | {smallSubTime(-22 * time.Second), "22 секунды назад", "ru"}, |
||
193 | {smallSubTime(-30 * time.Second), "30 секунд назад", "ru"}, |
||
194 | {smallSubTime(-31 * time.Second), "31 секунда назад", "ru"}, |
||
195 | {smallSubTime(-59 * time.Second), "59 секунд назад", "ru"}, |
||
196 | {smallSubTime(-60 * time.Second), "1 минута назад", "ru"}, |
||
197 | {smallSubTime(-1 * time.Minute), "1 минута назад", "ru"}, |
||
198 | {smallSubTime(-2 * time.Minute), "2 минуты назад", "ru"}, |
||
199 | {smallSubTime(-9 * time.Minute), "9 минут назад", "ru"}, |
||
200 | {smallSubTime(-10 * time.Minute), "10 минут назад", "ru"}, |
||
201 | {smallSubTime(-11 * time.Minute), "11 минут назад", "ru"}, |
||
202 | {smallSubTime(-20 * time.Minute), "20 минут назад", "ru"}, |
||
203 | {smallSubTime(-21 * time.Minute), "21 минута назад", "ru"}, |
||
204 | {smallSubTime(-22 * time.Minute), "22 минуты назад", "ru"}, |
||
205 | {smallSubTime(-30 * time.Minute), "30 минут назад", "ru"}, |
||
206 | {smallSubTime(-31 * time.Minute), "31 минута назад", "ru"}, |
||
207 | {smallSubTime(-59 * time.Minute), "59 минут назад", "ru"}, |
||
208 | {smallSubTime(-60 * time.Minute), "1 час назад", "ru"}, |
||
209 | {smallSubTime(-1 * time.Hour), "1 час назад", "ru"}, |
||
210 | {smallSubTime(-2 * time.Hour), "2 часа назад", "ru"}, |
||
211 | {smallSubTime(-9 * time.Hour), "9 часов назад", "ru"}, |
||
212 | {smallSubTime(-10 * time.Hour), "10 часов назад", "ru"}, |
||
213 | {smallSubTime(-11 * time.Hour), "11 часов назад", "ru"}, |
||
214 | {smallSubTime(-20 * time.Hour), "20 часов назад", "ru"}, |
||
215 | {smallSubTime(-21 * time.Hour), "21 час назад", "ru"}, |
||
216 | {smallSubTime(-23 * time.Hour), "23 часа назад", "ru"}, |
||
217 | {smallSubTime(-24 * time.Hour), "1 день назад", "ru"}, |
||
218 | {smallSubTime(-47 * time.Hour), "1 день назад", "ru"}, |
||
219 | {smallSubTime((-24 * 2) * time.Hour), "2 дня назад", "ru"}, |
||
220 | {smallSubTime((-24 * 6) * time.Hour), "6 дней назад", "ru"}, |
||
221 | {smallSubTime((-24 * 7) * time.Hour), "1 неделя назад", "ru"}, |
||
222 | {smallSubTime((-24 * 14) * time.Hour), "2 недели назад", "ru"}, |
||
223 | {smallSubTime((-24 * 21) * time.Hour), "3 недели назад", "ru"}, |
||
224 | {bigSubTime(0, 1, 1), "1 месяц назад", "ru"}, |
||
225 | {bigSubTime(0, 2, 1), "2 месяца назад", "ru"}, |
||
226 | {bigSubTime(0, 9, 1), "9 месяцев назад", "ru"}, |
||
227 | {bigSubTime(0, 11, 1), "11 месяцев назад", "ru"}, |
||
228 | {bigSubTime(0, 12, 1), "1 год назад", "ru"}, |
||
229 | {bigSubTime(1, 0, 1), "1 год назад", "ru"}, |
||
230 | {bigSubTime(2, 0, 1), "2 года назад", "ru"}, |
||
231 | {bigSubTime(5, 0, 1), "5 лет назад", "ru"}, |
||
232 | {bigSubTime(6, 0, 1), "6 лет назад", "ru"}, |
||
233 | {bigSubTime(7, 0, 1), "7 лет назад", "ru"}, |
||
234 | {bigSubTime(21, 0, 1), "21 год назад", "ru"}, |
||
235 | {bigSubTime(31, 0, 1), "31 год назад", "ru"}, |
||
236 | {bigSubTime(100, 0, 1), "100 лет назад", "ru"}, |
||
237 | } |
||
238 | |||
239 | for _, tc := range cases { |
||
240 | t.Run("result for "+tc.date, func(test *testing.T) { |
||
241 | Set("language", tc.lang) |
||
242 | Set("location", "Europe/Kiev") |
||
243 | |||
244 | if res := Take(tc.date); res != tc.result { |
||
245 | test.Errorf("Result must be %s, but got %s instead", tc.result, res) |
||
246 | } |
||
376 |