Conditions | 4 |
Total Lines | 57 |
Code Lines | 53 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | package tests |
||
10 | func TestParseRu(t *testing.T) { |
||
11 | cases := []struct { |
||
12 | date string |
||
13 | result string |
||
14 | }{ |
||
15 | {smallSubTime(-60 * time.Second), "1 минута назад"}, |
||
16 | {smallSubTime(-1 * time.Minute), "1 минута назад"}, |
||
17 | {smallSubTime(-2 * time.Minute), "2 минуты назад"}, |
||
18 | {smallSubTime(-5 * time.Minute), "5 минут назад"}, |
||
19 | {smallSubTime(-9 * time.Minute), "9 минут назад"}, |
||
20 | {smallSubTime(-10 * time.Minute), "10 минут назад"}, |
||
21 | {smallSubTime(-11 * time.Minute), "11 минут назад"}, |
||
22 | {smallSubTime(-20 * time.Minute), "20 минут назад"}, |
||
23 | {smallSubTime(-21 * time.Minute), "21 минута назад"}, |
||
24 | {smallSubTime(-22 * time.Minute), "22 минуты назад"}, |
||
25 | {smallSubTime(-30 * time.Minute), "30 минут назад"}, |
||
26 | {smallSubTime(-31 * time.Minute), "31 минута назад"}, |
||
27 | {smallSubTime(-59 * time.Minute), "59 минут назад"}, |
||
28 | {smallSubTime(-60 * time.Minute), "1 час назад"}, |
||
29 | {smallSubTime(-1 * time.Hour), "1 час назад"}, |
||
30 | {smallSubTime(-2 * time.Hour), "2 часа назад"}, |
||
31 | {smallSubTime(-9 * time.Hour), "9 часов назад"}, |
||
32 | {smallSubTime(-10 * time.Hour), "10 часов назад"}, |
||
33 | {smallSubTime(-11 * time.Hour), "11 часов назад"}, |
||
34 | {smallSubTime(-20 * time.Hour), "20 часов назад"}, |
||
35 | {smallSubTime(-21 * time.Hour), "21 час назад"}, |
||
36 | {smallSubTime(-23 * time.Hour), "23 часа назад"}, |
||
37 | {smallSubTime(-24 * time.Hour), "1 день назад"}, |
||
38 | {smallSubTime(-30 * time.Hour), "1 день назад"}, |
||
39 | {smallSubTime((-24 * 2) * time.Hour), "2 дня назад"}, |
||
40 | {smallSubTime((-24 * 6) * time.Hour), "6 дней назад"}, |
||
41 | {smallSubTime((-24 * 7) * time.Hour), "1 неделя назад"}, |
||
42 | {smallSubTime((-24 * 14) * time.Hour), "2 недели назад"}, |
||
43 | {smallSubTime((-24 * 21) * time.Hour), "3 недели назад"}, |
||
44 | {bigSubTime(0, 1, 1), "1 месяц назад"}, |
||
45 | {bigSubTime(0, 2, 1), "2 месяца назад"}, |
||
46 | {bigSubTime(0, 9, 1), "9 месяцев назад"}, |
||
47 | {bigSubTime(0, 11, 1), "11 месяцев назад"}, |
||
48 | {bigSubTime(0, 12, 1), "1 год назад"}, |
||
49 | {bigSubTime(1, 0, 1), "1 год назад"}, |
||
50 | {bigSubTime(2, 0, 1), "2 года назад"}, |
||
51 | {bigSubTime(5, 0, 1), "5 лет назад"}, |
||
52 | {bigSubTime(6, 0, 1), "6 лет назад"}, |
||
53 | {bigSubTime(7, 0, 1), "7 лет назад"}, |
||
54 | {bigSubTime(21, 0, 1), "21 год назад"}, |
||
55 | {bigSubTime(31, 0, 1), "31 год назад"}, |
||
56 | {bigSubTime(100, 0, 1), "100 лет назад"}, |
||
57 | } |
||
58 | |||
59 | for _, tc := range cases { |
||
60 | t.Run("result for "+tc.date, func(test *testing.T) { |
||
61 | SetConfig(Config{ |
||
62 | Language: "ru", |
||
63 | Location: "Europe/Kiev", |
||
64 | }) |
||
65 | |||
66 | if res := Parse(tc.date); res != tc.result { |
||
67 | test.Errorf("Result must be %s, but got %s instead", tc.result, res) |
||
178 |