SerhiiCho /
timeago
| Conditions | 5 |
| Total Lines | 56 |
| Code Lines | 49 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | package tests |
||
| 11 | func TestParseEs(t *testing.T) { |
||
| 12 | cases := []struct { |
||
| 13 | date time.Time |
||
| 14 | res string |
||
| 15 | }{ |
||
| 16 | {utils.SubMinutes(1), "hace 1 minuto"}, |
||
| 17 | {utils.SubMinutes(2), "hace 2 minutos"}, |
||
| 18 | {utils.SubMinutes(5), "hace 5 minutos"}, |
||
| 19 | {utils.SubMinutes(9), "hace 9 minutos"}, |
||
| 20 | {utils.SubMinutes(10), "hace 10 minutos"}, |
||
| 21 | {utils.SubMinutes(11), "hace 11 minutos"}, |
||
| 22 | {utils.SubMinutes(20), "hace 20 minutos"}, |
||
| 23 | {utils.SubMinutes(21), "hace 21 minutos"}, |
||
| 24 | {utils.SubMinutes(22), "hace 22 minutos"}, |
||
| 25 | {utils.SubMinutes(30), "hace 30 minutos"}, |
||
| 26 | {utils.SubMinutes(31), "hace 31 minutos"}, |
||
| 27 | {utils.SubMinutes(59), "hace 59 minutos"}, |
||
| 28 | {utils.SubHours(1), "hace 1 hora"}, |
||
| 29 | {utils.SubHours(2), "hace 2 horas"}, |
||
| 30 | {utils.SubHours(9), "hace 9 horas"}, |
||
| 31 | {utils.SubHours(10), "hace 10 horas"}, |
||
| 32 | {utils.SubHours(11), "hace 11 horas"}, |
||
| 33 | {utils.SubHours(20), "hace 20 horas"}, |
||
| 34 | {utils.SubHours(21), "hace 21 horas"}, |
||
| 35 | {utils.SubHours(23), "hace 23 horas"}, |
||
| 36 | {utils.SubDays(1), "hace 1 día"}, |
||
| 37 | {utils.SubDays(2), "hace 2 días"}, |
||
| 38 | {utils.SubDays(4), "hace 4 días"}, |
||
| 39 | {utils.SubDays(5), "hace 5 días"}, |
||
| 40 | {utils.SubDays(6), "hace 6 días"}, |
||
| 41 | {utils.SubWeeks(1), "hace 1 semana"}, |
||
| 42 | {utils.SubWeeks(2), "hace 2 semanas"}, |
||
| 43 | {utils.SubWeeks(3), "hace 3 semanas"}, |
||
| 44 | {utils.SubMonths(1), "hace 1 mes"}, |
||
| 45 | {utils.SubMonths(2), "hace 2 meses"}, |
||
| 46 | {utils.SubMonths(9), "hace 9 meses"}, |
||
| 47 | {utils.SubMonths(11), "hace 11 meses"}, |
||
| 48 | {utils.SubYears(1), "hace 1 año"}, |
||
| 49 | {utils.SubYears(2), "hace 2 años"}, |
||
| 50 | {utils.SubYears(21), "hace 21 años"}, |
||
| 51 | {utils.SubYears(31), "hace 31 años"}, |
||
| 52 | {utils.SubYears(100), "hace 100 años"}, |
||
| 53 | } |
||
| 54 | |||
| 55 | for _, tc := range cases { |
||
| 56 | t.Run("result for "+tc.date.String(), func(test *testing.T) { |
||
| 57 | ago.Reconfigure(ago.Config{Language: ago.LangEs}) |
||
| 58 | |||
| 59 | res, err := ago.Parse(tc.date) |
||
| 60 | |||
| 61 | if err != nil { |
||
| 62 | test.Errorf("Error must be nil, but got %v instead", err) |
||
| 63 | } |
||
| 64 | |||
| 65 | if res != tc.res { |
||
| 66 | test.Errorf("Result must be %s, but got %s instead", tc.res, res) |
||
| 67 | } |
||
| 106 |
