Conditions | 5 |
Total Lines | 62 |
Code Lines | 55 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | package tests |
||
11 | func TestParseDe(t *testing.T) { |
||
12 | cases := []struct { |
||
13 | date time.Time |
||
14 | res string |
||
15 | }{ |
||
16 | {utils.SubMinutes(1), "Vor 1 Minute"}, |
||
17 | {utils.SubMinutes(2), "Vor 2 Minuten"}, |
||
18 | {utils.SubMinutes(5), "Vor 5 Minuten"}, |
||
19 | {utils.SubMinutes(9), "Vor 9 Minuten"}, |
||
20 | {utils.SubMinutes(10), "Vor 10 Minuten"}, |
||
21 | {utils.SubMinutes(11), "Vor 11 Minuten"}, |
||
22 | {utils.SubMinutes(20), "Vor 20 Minuten"}, |
||
23 | {utils.SubMinutes(21), "Vor 21 Minuten"}, |
||
24 | {utils.SubMinutes(22), "Vor 22 Minuten"}, |
||
25 | {utils.SubMinutes(30), "Vor 30 Minuten"}, |
||
26 | {utils.SubMinutes(31), "Vor 31 Minuten"}, |
||
27 | {utils.SubMinutes(59), "Vor 59 Minuten"}, |
||
28 | {utils.SubMinutes(60), "Vor 1 Stunde"}, |
||
29 | {utils.SubHours(1), "Vor 1 Stunde"}, |
||
30 | {utils.SubHours(2), "Vor 2 Stunden"}, |
||
31 | {utils.SubHours(9), "Vor 9 Stunden"}, |
||
32 | {utils.SubHours(10), "Vor 10 Stunden"}, |
||
33 | {utils.SubHours(11), "Vor 11 Stunden"}, |
||
34 | {utils.SubHours(20), "Vor 20 Stunden"}, |
||
35 | {utils.SubHours(21), "Vor 21 Stunden"}, |
||
36 | {utils.SubHours(23), "Vor 23 Stunden"}, |
||
37 | {utils.SubDays(1), "Vor 1 Tag"}, |
||
38 | {utils.SubDays(2), "Vor 2 Tagen"}, |
||
39 | {utils.SubDays(6), "Vor 6 Tagen"}, |
||
40 | {utils.SubWeeks(1), "Vor 1 Woche"}, |
||
41 | {utils.SubWeeks(2), "Vor 2 Wochen"}, |
||
42 | {utils.SubWeeks(3), "Vor 3 Wochen"}, |
||
43 | {utils.SubMonths(1), "Vor 1 Monat"}, |
||
44 | {utils.SubMonths(2), "Vor 2 Monaten"}, |
||
45 | {utils.SubMonths(3), "Vor 3 Monaten"}, |
||
46 | {utils.SubMonths(4), "Vor 4 Monaten"}, |
||
47 | {utils.SubMonths(5), "Vor 5 Monaten"}, |
||
48 | {utils.SubMonths(6), "Vor 6 Monaten"}, |
||
49 | {utils.SubMonths(7), "Vor 7 Monaten"}, |
||
50 | {utils.SubMonths(8), "Vor 8 Monaten"}, |
||
51 | {utils.SubMonths(9), "Vor 9 Monaten"}, |
||
52 | {utils.SubMonths(10), "Vor 10 Monaten"}, |
||
53 | {utils.SubMonths(11), "Vor 11 Monaten"}, |
||
54 | {utils.SubYears(1), "Vor 1 Jahr"}, |
||
55 | {utils.SubYears(2), "Vor 2 Jahren"}, |
||
56 | {utils.SubYears(21), "Vor 21 Jahren"}, |
||
57 | {utils.SubYears(31), "Vor 31 Jahren"}, |
||
58 | {utils.SubYears(100), "Vor 100 Jahren"}, |
||
59 | } |
||
60 | |||
61 | for _, tc := range cases { |
||
62 | t.Run("result for "+tc.date.String(), func(test *testing.T) { |
||
63 | ago.Reconfigure(ago.Config{Language: ago.LangDe}) |
||
64 | |||
65 | res, err := ago.Parse(tc.date) |
||
66 | |||
67 | if err != nil { |
||
68 | test.Errorf("Error must be nil, but got %v instead", err) |
||
69 | } |
||
70 | |||
71 | if res != tc.res { |
||
72 | test.Errorf("Result must be %s, but got %s instead", tc.res, res) |
||
73 | } |
||
113 |