SerhiiCho /
timeago
| Conditions | 5 |
| Total Lines | 68 |
| Code Lines | 61 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | package tests |
||
| 11 | func TestParseWithNoSuffixFlag(t *testing.T) { |
||
| 12 | cases := []struct { |
||
| 13 | date time.Time |
||
| 14 | res string |
||
| 15 | lang string |
||
| 16 | }{ |
||
| 17 | {utils.SubMinutes(1), "1 minute", ago.LangEn}, |
||
| 18 | {utils.SubMinutes(2), "2 minutes", ago.LangEn}, |
||
| 19 | {utils.SubMinutes(3), "3 minutes", ago.LangEn}, |
||
| 20 | {utils.SubMinutes(4), "4 minutes", ago.LangEn}, |
||
| 21 | {utils.SubMinutes(5), "5 minutes", ago.LangEn}, |
||
| 22 | {utils.SubMinutes(10), "10 minutes", ago.LangEn}, |
||
| 23 | {utils.SubMinutes(11), "11 minutes", ago.LangEn}, |
||
| 24 | {utils.SubMinutes(20), "20 minutes", ago.LangEn}, |
||
| 25 | {utils.SubMinutes(21), "21 minutes", ago.LangEn}, |
||
| 26 | {utils.SubMinutes(22), "22 minutes", ago.LangEn}, |
||
| 27 | {utils.SubMinutes(30), "30 minutes", ago.LangEn}, |
||
| 28 | {utils.SubMinutes(31), "31 minutes", ago.LangEn}, |
||
| 29 | {utils.SubHours(1), "1 hour", ago.LangEn}, |
||
| 30 | {utils.SubHours(2), "2 hours", ago.LangEn}, |
||
| 31 | {utils.SubHours(9), "9 hours", ago.LangEn}, |
||
| 32 | {utils.SubHours(10), "10 hours", ago.LangEn}, |
||
| 33 | {utils.SubHours(11), "11 hours", ago.LangEn}, |
||
| 34 | {utils.SubHours(20), "20 hours", ago.LangEn}, |
||
| 35 | {utils.SubHours(21), "21 hours", ago.LangEn}, |
||
| 36 | {utils.SubHours(23), "23 hours", ago.LangEn}, |
||
| 37 | {utils.SubDays(1), "1 day", ago.LangEn}, |
||
| 38 | {utils.SubDays(2), "2 days", ago.LangEn}, |
||
| 39 | {utils.SubDays(6), "6 days", ago.LangEn}, |
||
| 40 | {utils.SubWeeks(1), "1 week", ago.LangEn}, |
||
| 41 | {utils.SubWeeks(2), "2 weeks", ago.LangEn}, |
||
| 42 | {utils.SubWeeks(3), "3 weeks", ago.LangEn}, |
||
| 43 | {utils.SubMonths(1), "1 month", ago.LangEn}, |
||
| 44 | {utils.SubMonths(2), "2 months", ago.LangEn}, |
||
| 45 | {utils.SubMonths(3), "3 months", ago.LangEn}, |
||
| 46 | {utils.SubMonths(4), "4 months", ago.LangEn}, |
||
| 47 | {utils.SubMonths(5), "5 months", ago.LangEn}, |
||
| 48 | {utils.SubMonths(6), "6 months", ago.LangEn}, |
||
| 49 | {utils.SubMonths(7), "7 months", ago.LangEn}, |
||
| 50 | {utils.SubMonths(8), "8 months", ago.LangEn}, |
||
| 51 | {utils.SubMonths(9), "9 months", ago.LangEn}, |
||
| 52 | {utils.SubMonths(10), "10 months", ago.LangEn}, |
||
| 53 | {utils.SubMonths(11), "11 months", ago.LangEn}, |
||
| 54 | {utils.SubMonths(12), "1 year", ago.LangEn}, |
||
| 55 | {utils.SubYears(4), "4 years", ago.LangEn}, |
||
| 56 | {utils.SubYears(5), "5 years", ago.LangEn}, |
||
| 57 | {utils.SubYears(11), "11 years", ago.LangEn}, |
||
| 58 | {utils.SubYears(29), "29 years", ago.LangEn}, |
||
| 59 | {utils.SubYears(92), "92 years", ago.LangEn}, |
||
| 60 | {utils.SubMinutes(1), "1 минута", ago.LangRu}, |
||
| 61 | {utils.SubMinutes(2), "2 минуты", ago.LangRu}, |
||
| 62 | {utils.SubMonths(3), "3 месяца", ago.LangRu}, |
||
| 63 | {utils.SubWeeks(2), "2 недели", ago.LangRu}, |
||
| 64 | {utils.SubYears(77), "77 лет", ago.LangRu}, |
||
| 65 | } |
||
| 66 | |||
| 67 | for _, tc := range cases { |
||
| 68 | t.Run("result for "+tc.date.String(), func(test *testing.T) { |
||
| 69 | ago.Reconfigure(ago.Config{Language: tc.lang}) |
||
| 70 | |||
| 71 | res, err := ago.Parse(tc.date, ago.OptNoSuffix) |
||
| 72 | |||
| 73 | if err != nil { |
||
| 74 | test.Errorf("Error must be nil, but got %v instead", err) |
||
| 75 | } |
||
| 76 | |||
| 77 | if res != tc.res { |
||
| 78 | test.Errorf("Result must be %s, but got %s instead", tc.res, res) |
||
| 79 | } |
||
| 83 |
