SerhiiCho /
timeago
| Conditions | 5 |
| Total Lines | 57 |
| Code Lines | 50 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | package tests |
||
| 11 | func TestParseRu(t *testing.T) { |
||
| 12 | cases := []struct { |
||
| 13 | date time.Time |
||
| 14 | res string |
||
| 15 | }{ |
||
| 16 | {utils.SubMinutes(1), "1 минута назад"}, |
||
| 17 | {utils.SubMinutes(2), "2 минуты назад"}, |
||
| 18 | {utils.SubMinutes(5), "5 минут назад"}, |
||
| 19 | {utils.SubMinutes(9), "9 минут назад"}, |
||
| 20 | {utils.SubMinutes(10), "10 минут назад"}, |
||
| 21 | {utils.SubMinutes(11), "11 минут назад"}, |
||
| 22 | {utils.SubMinutes(20), "20 минут назад"}, |
||
| 23 | {utils.SubMinutes(21), "21 минута назад"}, |
||
| 24 | {utils.SubMinutes(22), "22 минуты назад"}, |
||
| 25 | {utils.SubMinutes(30), "30 минут назад"}, |
||
| 26 | {utils.SubMinutes(31), "31 минута назад"}, |
||
| 27 | {utils.SubMinutes(59), "59 минут назад"}, |
||
| 28 | {utils.SubHours(1), "1 час назад"}, |
||
| 29 | {utils.SubHours(2), "2 часа назад"}, |
||
| 30 | {utils.SubHours(9), "9 часов назад"}, |
||
| 31 | {utils.SubHours(10), "10 часов назад"}, |
||
| 32 | {utils.SubHours(11), "11 часов назад"}, |
||
| 33 | {utils.SubHours(20), "20 часов назад"}, |
||
| 34 | {utils.SubHours(21), "21 час назад"}, |
||
| 35 | {utils.SubHours(23), "23 часа назад"}, |
||
| 36 | {utils.SubDays(1), "1 день назад"}, |
||
| 37 | {utils.SubDays(2), "2 дня назад"}, |
||
| 38 | {utils.SubDays(6), "6 дней назад"}, |
||
| 39 | {utils.SubWeeks(1), "1 неделя назад"}, |
||
| 40 | {utils.SubWeeks(2), "2 недели назад"}, |
||
| 41 | {utils.SubWeeks(3), "3 недели назад"}, |
||
| 42 | {utils.SubMonths(1), "1 месяц назад"}, |
||
| 43 | {utils.SubMonths(2), "2 месяца назад"}, |
||
| 44 | {utils.SubMonths(9), "9 месяцев назад"}, |
||
| 45 | {utils.SubMonths(11), "11 месяцев назад"}, |
||
| 46 | {utils.SubYears(1), "1 год назад"}, |
||
| 47 | {utils.SubYears(2), "2 года назад"}, |
||
| 48 | {utils.SubYears(5), "5 лет назад"}, |
||
| 49 | {utils.SubYears(6), "6 лет назад"}, |
||
| 50 | {utils.SubYears(7), "7 лет назад"}, |
||
| 51 | {utils.SubYears(21), "21 год назад"}, |
||
| 52 | {utils.SubYears(31), "31 год назад"}, |
||
| 53 | {utils.SubYears(100), "100 лет назад"}, |
||
| 54 | } |
||
| 55 | |||
| 56 | for _, tc := range cases { |
||
| 57 | t.Run("result for "+tc.date.String(), func(test *testing.T) { |
||
| 58 | ago.Reconfigure(ago.Config{Language: ago.LangRu}) |
||
| 59 | |||
| 60 | res, err := ago.Parse(tc.date) |
||
| 61 | |||
| 62 | if err != nil { |
||
| 63 | test.Errorf("Error must be nil, but got %v instead", err) |
||
| 64 | } |
||
| 65 | |||
| 66 | if res != tc.res { |
||
| 67 | test.Errorf("Result must be %s, but got %s instead", tc.res, res) |
||
| 68 | } |
||
| 126 |
