Gitter\Resources\AbstractResource

Complexity

Total Complexity

8

Size/Duplication

Total Lines	105
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	client()	0	4	1
B	fetch()	0	36	3
A	stream()	0	11	1
A	viaHttp()	0	4	1
A	viaStream()	0	4	1

<?php declare(strict_types=1);
/**
 * This file is part of GitterApi package.
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */
namespace Gitter\Resources;

use Gitter\Adapters\AdapterInterface;
use Gitter\Adapters\HttpAdapter;
use Gitter\Adapters\StreamAdapter;
use Gitter\Route;
use Gitter\Client;
use Gitter\Support\Observer;
use GuzzleHttp\Exception\ClientException;
use Serafim\Evacuator\Evacuator;
use GuzzleHttp\Exception\RequestException;

/**
 * Class AbstractResource
 * @package Gitter\Resources
 */
abstract class AbstractResource implements ResourceInterface
{
    /**
     * @var null
     */
    private $client;

    /**
     * AbstractResource constructor.
     * @param Client $client
     */
    public function __construct(Client $client)
    {
        $this->client = $client;

It seems like $client of type object<Gitter\Client> is incompatible with the declared type null of property $client.

    }

    /**
     * @return Client
     */
    protected function client(): Client
    {
        return $this->client;
    }

    /**
     * @param Route $route
     * @return array|mixed
     * @throws \GuzzleHttp\Exception\ClientException
     * @throws \GuzzleHttp\Exception\RequestException
     * @throws \Throwable
     * @throws \Exception
     * @throws \RuntimeException
     * @throws \InvalidArgumentException
     */
    protected function fetch(Route $route): array
    {
        $rescue = (new Evacuator(function () use ($route) {
            return (array)$this->viaHttp()->request($route);
        }))
            // If response has status code 4xx
            ->onError(function (ClientException $e) {
                $this->client->logger->error(get_class($e) . '  ' . $e->getMessage());

                switch ($e->getResponse()->getStatusCode()) {
                    case 429: // 429 Too Many Requests
                        sleep(2);
                        return null;
                }

                throw $e;
            })
            // On internal errors
            ->onError(function (RequestException $e) {
                $this->client->logger->error($e->getMessage());

                // Throws request exception if SSL error
                if (false !== strpos($e->getMessage(), 'SSL certificate problem')) {
                    throw $e;
                }
            })
            // Other
            ->onError(function (\Exception $e) {
                $this->client->logger->error($e->getMessage());
                throw $e;
            })
            ->retries($this->client->getRetriesCount())

The method getRetriesCount cannot be called on $this->client (of type null).

            ->invoke();

        return $rescue;
    }

    /**
     * @param Route $route
     * @return Observer
     * @throws \Throwable
     * @throws \InvalidArgumentException
     */
    protected function stream(Route $route): Observer
    {
        return (new Evacuator(function() use ($route) {
            return $this->viaStream()->request($route);

It seems like you code against a concrete implementation and not the interface Gitter\Adapters\AdapterInterface as the method request() does only exist in the following implementations of said interface: Gitter\Adapters\HttpAdapter, Gitter\Adapters\StreamAdapter.

        }))
            ->onError(function (\Exception $e) {
                $this->client->logger->error($e->getMessage());
            })
            ->retries($this->client->getRetriesCount())

The method getRetriesCount cannot be called on $this->client (of type null).

            ->invoke();
    }

    /**
     * @return AdapterInterface|HttpAdapter
     */
    protected function viaHttp(): HttpAdapter
    {
        return $this->client->viaHttp();

The method viaHttp cannot be called on $this->client (of type null).

    }

    /**
     * @return AdapterInterface|StreamAdapter
     */
    protected function viaStream(): StreamAdapter
    {
        return $this->client->viaStream();

The method viaStream cannot be called on $this->client (of type null).

    }
}